From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Zigotzky Subject: Re: use generic DMA mapping code in powerpc V4 Date: Fri, 18 Jan 2019 12:10:26 +0100 Message-ID: <871403f2-fa7d-de15-89eb-070432e15c69@xenosoft.de> References: <3504ee70-02de-049e-6402-2d530bf55a84@xenosoft.de> <23284859-bf0a-9cd5-a480-2a7fd7802056@xenosoft.de> <075f70e3-7a4a-732f-b501-05a1a8e3c853@xenosoft.de> <21f72a6a-9095-7034-f169-95e876228b2a@xenosoft.de> <27148ac2-2a92-5536-d886-2c0971ab43d9@xenosoft.de> <20190115133558.GA29225@lst.de> <685f0c06-af1b-0bec-ac03-f9bf1f7a2b35@xenosoft.de> <20190115151732.GA2325@lst.de> <20190118083539.GA30479@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190118083539.GA30479@lst.de> Content-Language: de-DE Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig Cc: linux-arch@vger.kernel.org, Darren Stevens , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Paul Mackerras , Olof Johansson , linuxppc-dev@lists.ozlabs.org List-Id: linux-arch.vger.kernel.org For which commit? -- Christian On 18 January 2019 at 09:35AM, Christoph Hellwig wrote: > Hi Christian, > > can you check if the debug printks in this patch trigger? > > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > index 355d16acee6d..e46c9b64ec0d 100644 > --- a/kernel/dma/direct.c > +++ b/kernel/dma/direct.c > @@ -118,8 +118,11 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, > page = NULL; > } > } > - if (!page) > + if (!page) { > page = alloc_pages_node(dev_to_node(dev), gfp, page_order); > + if (!page) > + pr_warn("failed to allocate memory with gfp 0x%x\n", gfp); > + } > > if (page && !dma_coherent_ok(dev, page_to_phys(page), size)) { > __free_pages(page, page_order); > @@ -139,6 +142,10 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, > } > } > > + if (!page) { > + pr_warn("failed to allocate DMA memory!\n"); > + dump_stack(); > + } > return page; > } > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.50]:22939 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbfARLKa (ORCPT ); Fri, 18 Jan 2019 06:10:30 -0500 Subject: Re: use generic DMA mapping code in powerpc V4 References: <3504ee70-02de-049e-6402-2d530bf55a84@xenosoft.de> <23284859-bf0a-9cd5-a480-2a7fd7802056@xenosoft.de> <075f70e3-7a4a-732f-b501-05a1a8e3c853@xenosoft.de> <21f72a6a-9095-7034-f169-95e876228b2a@xenosoft.de> <27148ac2-2a92-5536-d886-2c0971ab43d9@xenosoft.de> <20190115133558.GA29225@lst.de> <685f0c06-af1b-0bec-ac03-f9bf1f7a2b35@xenosoft.de> <20190115151732.GA2325@lst.de> <20190118083539.GA30479@lst.de> From: Christian Zigotzky Message-ID: <871403f2-fa7d-de15-89eb-070432e15c69@xenosoft.de> Date: Fri, 18 Jan 2019 12:10:26 +0100 MIME-Version: 1.0 In-Reply-To: <20190118083539.GA30479@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: de-DE Sender: linux-arch-owner@vger.kernel.org List-ID: To: Christoph Hellwig Cc: linux-arch@vger.kernel.org, Darren Stevens , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Paul Mackerras , Olof Johansson , linuxppc-dev@lists.ozlabs.org Message-ID: <20190118111026.mr1HbGxgOvoetNyo1ENSqPftiGk7-qAoMWgmoIPf0k0@z> For which commit? -- Christian On 18 January 2019 at 09:35AM, Christoph Hellwig wrote: > Hi Christian, > > can you check if the debug printks in this patch trigger? > > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > index 355d16acee6d..e46c9b64ec0d 100644 > --- a/kernel/dma/direct.c > +++ b/kernel/dma/direct.c > @@ -118,8 +118,11 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, > page = NULL; > } > } > - if (!page) > + if (!page) { > page = alloc_pages_node(dev_to_node(dev), gfp, page_order); > + if (!page) > + pr_warn("failed to allocate memory with gfp 0x%x\n", gfp); > + } > > if (page && !dma_coherent_ok(dev, page_to_phys(page), size)) { > __free_pages(page, page_order); > @@ -139,6 +142,10 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, > } > } > > + if (!page) { > + pr_warn("failed to allocate DMA memory!\n"); > + dump_stack(); > + } > return page; > } > >