From: Thomas Gleixner <tglx@linutronix.de>
To: Christoph Hellwig <hch@infradead.org>,
Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: mingo@redhat.com, keescook@chromium.org, arnd@arndb.de,
luto@amacapital.net, wad@chromium.org, rostedt@goodmis.org,
paul@paul-moore.com, eparis@redhat.com, oleg@redhat.com,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, kernel@collabora.com
Subject: Re: [PATCH 02/10] kernel: entry: Expose helpers to migrate TIF to SYSCALL_WORK flags
Date: Sun, 15 Nov 2020 19:28:36 +0100 [thread overview]
Message-ID: <871rgua2zv.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20201114112249.GA20070@infradead.org>
On Sat, Nov 14 2020 at 11:22, Christoph Hellwig wrote:
>> +#ifdef CONFIG_GENERIC_ENTRY
>> +static inline void __set_task_syscall_work(struct thread_info *ti, int flag)
>> +{
>> + set_bit(flag, (unsigned long *)&ti->syscall_work);
>> +}
>> +static inline int __test_task_syscall_work(struct thread_info *ti, int flag)
>> +{
>> + return test_bit(flag, (unsigned long *)&ti->syscall_work);
>> +}
>> +static inline void __clear_task_syscall_work(struct thread_info *ti, int flag)
>> +{
>> + return clear_bit(flag, (unsigned long *)&ti->syscall_work);
>
> The casts here look bogus.
Making sure that &(unsigned long) results in a pointer to unsigned long
is indeed silly.
Thanks,
tglx
next prev parent reply other threads:[~2020-11-15 18:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 3:29 [PATCH 00/10] Migrate syscall entry/exit work to SYSCALL_WORK flagset Gabriel Krisman Bertazi
2020-11-14 3:29 ` [PATCH 01/10] x86: Expose syscall_work field in thread_info Gabriel Krisman Bertazi
2020-11-14 3:29 ` [PATCH 02/10] kernel: entry: Expose helpers to migrate TIF to SYSCALL_WORK flags Gabriel Krisman Bertazi
2020-11-14 11:22 ` Christoph Hellwig
2020-11-15 18:28 ` Thomas Gleixner [this message]
2020-11-14 3:29 ` [PATCH 03/10] kernel: entry: Wire up syscall_work in common entry code Gabriel Krisman Bertazi
2020-11-15 18:38 ` Thomas Gleixner
2020-11-14 3:29 ` [PATCH 04/10] seccomp: Migrate to use SYSCALL_WORK flag Gabriel Krisman Bertazi
2020-11-15 18:35 ` Thomas Gleixner
2020-11-14 3:29 ` [PATCH 05/10] tracepoints: " Gabriel Krisman Bertazi
2020-11-15 18:41 ` Thomas Gleixner
2020-11-14 3:29 ` [PATCH 06/10] ptrace: Migrate to use SYSCALL_TRACE flag Gabriel Krisman Bertazi
2020-11-14 3:29 ` [PATCH 07/10] ptrace: Migrate TIF_SYSCALL_EMU to use SYSCALL_WORK flag Gabriel Krisman Bertazi
2020-11-14 3:29 ` [PATCH 08/10] audit: Migrate " Gabriel Krisman Bertazi
2020-11-14 3:29 ` [PATCH 09/10] kernel: entry: Drop usage of TIF flags in the generic syscall code Gabriel Krisman Bertazi
2020-11-14 3:29 ` [PATCH 10/10] x86: Reclaim unused x86 TI flags Gabriel Krisman Bertazi
2020-11-15 18:50 ` [PATCH 00/10] Migrate syscall entry/exit work to SYSCALL_WORK flagset Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rgua2zv.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=arnd@arndb.de \
--cc=eparis@redhat.com \
--cc=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=paul@paul-moore.com \
--cc=rostedt@goodmis.org \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox