* new uses of SYSCTL_SYSCALL
@ 2019-11-26 19:15 Eric W. Biederman
2019-11-26 19:27 ` Max Filippov
0 siblings, 1 reply; 3+ messages in thread
From: Eric W. Biederman @ 2019-11-26 19:15 UTC (permalink / raw)
To: Max Filippov; +Cc: linux-arch, linux-xtensa
Doing a test merge against linux-next I see that in the
tree git://github.com/jcmvbkbc/linux-xtensa.git#xtensa-for-next
a new defconfig is added:
arch/xtensa/configs/xip_kc705_defconfig
That defconfig adds CONFIG_SYSCTL_SYSCALL.
Is xtensa actually using this system call? So far I have not seen any
other users and I am serously proposing to remove it.
Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: new uses of SYSCTL_SYSCALL
2019-11-26 19:15 new uses of SYSCTL_SYSCALL Eric W. Biederman
@ 2019-11-26 19:27 ` Max Filippov
2019-11-26 20:05 ` Eric W. Biederman
0 siblings, 1 reply; 3+ messages in thread
From: Max Filippov @ 2019-11-26 19:27 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: Linux-Arch, open list:TENSILICA XTENSA PORT (xtensa)
Hi Eric,
On Tue, Nov 26, 2019 at 11:15 AM Eric W. Biederman
<ebiederm@xmission.com> wrote:
> Doing a test merge against linux-next I see that in the
> tree git://github.com/jcmvbkbc/linux-xtensa.git#xtensa-for-next
> a new defconfig is added:
>
> arch/xtensa/configs/xip_kc705_defconfig
>
> That defconfig adds CONFIG_SYSCTL_SYSCALL.
>
> Is xtensa actually using this system call? So far I have not seen any
> other users and I am serously proposing to remove it.
I'm sure that this config symbol was inherited from some other config
that I used as a base for the xip_kc705_defconfig. I didn't enable it
intentionally. I'll drop it from the config and fix up the patch that
introduced it.
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: new uses of SYSCTL_SYSCALL
2019-11-26 19:27 ` Max Filippov
@ 2019-11-26 20:05 ` Eric W. Biederman
0 siblings, 0 replies; 3+ messages in thread
From: Eric W. Biederman @ 2019-11-26 20:05 UTC (permalink / raw)
To: Max Filippov; +Cc: Linux-Arch, open list:TENSILICA XTENSA PORT (xtensa)
Max Filippov <jcmvbkbc@gmail.com> writes:
> Hi Eric,
>
> On Tue, Nov 26, 2019 at 11:15 AM Eric W. Biederman
> <ebiederm@xmission.com> wrote:
>> Doing a test merge against linux-next I see that in the
>> tree git://github.com/jcmvbkbc/linux-xtensa.git#xtensa-for-next
>> a new defconfig is added:
>>
>> arch/xtensa/configs/xip_kc705_defconfig
>>
>> That defconfig adds CONFIG_SYSCTL_SYSCALL.
>>
>> Is xtensa actually using this system call? So far I have not seen any
>> other users and I am serously proposing to remove it.
>
> I'm sure that this config symbol was inherited from some other config
> that I used as a base for the xip_kc705_defconfig. I didn't enable it
> intentionally. I'll drop it from the config and fix up the patch that
> introduced it.
Thank you for confirming that.
I would recommend an incremental commit/patch on top to change just this
one thing so you don't rebase just before you send a pull request and
cause Linus's to wonder if you have tested the code at all.
Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-26 20:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-26 19:15 new uses of SYSCTL_SYSCALL Eric W. Biederman
2019-11-26 19:27 ` Max Filippov
2019-11-26 20:05 ` Eric W. Biederman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox