From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH V3 2/2] powerpc/pseries: init fault_around_order for pseries Date: Tue, 29 Apr 2014 11:48:40 +0930 Message-ID: <877g686fpb.fsf@rustcorp.com.au> References: <1398675690-16186-1-git-send-email-maddy@linux.vnet.ibm.com> <1398675690-16186-3-git-send-email-maddy@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from ozlabs.org ([103.22.144.67]:54369 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbaD2Cgp (ORCPT ); Mon, 28 Apr 2014 22:36:45 -0400 In-Reply-To: <1398675690-16186-3-git-send-email-maddy@linux.vnet.ibm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org Cc: benh@kernel.crashing.org, paulus@samba.org, kirill.shutemov@linux.intel.com, akpm@linux-foundation.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com, Madhavan Srinivasan Madhavan Srinivasan writes: > diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c > index 2db8cc6..c87e6b6 100644 > --- a/arch/powerpc/platforms/pseries/setup.c > +++ b/arch/powerpc/platforms/pseries/setup.c > @@ -74,6 +74,8 @@ int CMO_SecPSP = -1; > unsigned long CMO_PageSize = (ASM_CONST(1) << IOMMU_PAGE_SHIFT_4K); > EXPORT_SYMBOL(CMO_PageSize); > > +extern unsigned int fault_around_order; > + It's considered bad form to do this. Put the declaration in linux/mm.h. Thanks, Rusty. PS. But we're getting there! :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org ([103.22.144.67]:54369 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbaD2Cgp (ORCPT ); Mon, 28 Apr 2014 22:36:45 -0400 From: Rusty Russell Subject: Re: [PATCH V3 2/2] powerpc/pseries: init fault_around_order for pseries In-Reply-To: <1398675690-16186-3-git-send-email-maddy@linux.vnet.ibm.com> References: <1398675690-16186-1-git-send-email-maddy@linux.vnet.ibm.com> <1398675690-16186-3-git-send-email-maddy@linux.vnet.ibm.com> Date: Tue, 29 Apr 2014 11:48:40 +0930 Message-ID: <877g686fpb.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-arch-owner@vger.kernel.org List-ID: To: Madhavan Srinivasan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org Cc: benh@kernel.crashing.org, paulus@samba.org, kirill.shutemov@linux.intel.com, akpm@linux-foundation.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com Message-ID: <20140429021840.PkZo0a760WbnhxKEXWzpT1wL90nn0Xq5ZQ5TI7AzCNM@z> Madhavan Srinivasan writes: > diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c > index 2db8cc6..c87e6b6 100644 > --- a/arch/powerpc/platforms/pseries/setup.c > +++ b/arch/powerpc/platforms/pseries/setup.c > @@ -74,6 +74,8 @@ int CMO_SecPSP = -1; > unsigned long CMO_PageSize = (ASM_CONST(1) << IOMMU_PAGE_SHIFT_4K); > EXPORT_SYMBOL(CMO_PageSize); > > +extern unsigned int fault_around_order; > + It's considered bad form to do this. Put the declaration in linux/mm.h. Thanks, Rusty. PS. But we're getting there! :)