From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: [PATCH 3/8] signal/sparc: Document a conflict with SI_USER with SIGFPE Date: Tue, 18 Jul 2017 08:43:14 -0500 Message-ID: <878tjlhnd9.fsf@xmission.com> References: <87efu22set.fsf@xmission.com> <20170630123906.8865-3-ebiederm@xmission.com> <20170630.124505.736865959393416284.davem@davemloft.net> <8737ahwdgr.fsf@xmission.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <8737ahwdgr.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> (Eric W. Biederman's message of "Fri, 30 Jun 2017 13:13:40 -0500") Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Miller Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, avagin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org, avagin-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org, xemul-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org, gorcunov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, w@1wt.eu, linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arch.vger.kernel.org ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) writes: > David Miller writes: > >> From: "Eric W. Biederman" >> Date: Fri, 30 Jun 2017 07:39:01 -0500 >> >>> diff --git a/arch/sparc/include/uapi/asm/siginfo.h b/arch/sparc/include/uapi/asm/siginfo.h >>> index 2d9b79ccaa50..6bc5c677e92f 100644 >>> --- a/arch/sparc/include/uapi/asm/siginfo.h >>> +++ b/arch/sparc/include/uapi/asm/siginfo.h >>> @@ -17,6 +17,11 @@ >>> #define SI_NOINFO 32767 /* no information in siginfo_t */ >>> >>> /* >>> + * SIGFPE si_codes >>> + */ >>> +#define FPE_FIXME (__SI_FAULT|0) /* Broken dup of SI_USER */ >>> + >>> +/* >>> * SIGEMT si_codes >>> */ >>> #define EMT_TAGOVF (__SI_FAULT|1) /* tag overflow */ >> >> It's one thing to say FIXME in a comment in a kernel local header or >> C file. >> >> It's quite another to put this into the name of a macro which has >> visibility in the global user compilation namespace. >> >> I don't think you should really do that. > > Good point. > > Sigh. It almost fits because we did do something off in the uapi > exported to userspace and we don't have a header file definition for > that case. > > Still. At this point arch/sparc/include/asm/siginfo.h is > a better fit for that definition. > > I will respin and fix that. Except arch//include/asm/siginfo.h has now been eliminated. So these definitions have to be #ifdef __KERNEL__ #define ..._FIXME #endif In the uapi but not visible in the headers outside of the kernel. Which seems appropriate for these values. Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out03.mta.xmission.com ([166.70.13.233]:59622 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbdGRNvX (ORCPT ); Tue, 18 Jul 2017 09:51:23 -0400 From: ebiederm@xmission.com (Eric W. Biederman) References: <87efu22set.fsf@xmission.com> <20170630123906.8865-3-ebiederm@xmission.com> <20170630.124505.736865959393416284.davem@davemloft.net> <8737ahwdgr.fsf@xmission.com> Date: Tue, 18 Jul 2017 08:43:14 -0500 In-Reply-To: <8737ahwdgr.fsf@xmission.com> (Eric W. Biederman's message of "Fri, 30 Jun 2017 13:13:40 -0500") Message-ID: <878tjlhnd9.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [PATCH 3/8] signal/sparc: Document a conflict with SI_USER with SIGFPE Sender: linux-arch-owner@vger.kernel.org List-ID: To: David Miller Cc: linux-kernel@vger.kernel.org, luto@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, oleg@redhat.com, avagin@virtuozzo.com, tglx@linutronix.de, greg@kroah.com, avagin@openvz.org, serge@hallyn.com, xemul@virtuozzo.com, gorcunov@openvz.org, peterz@infradead.org, w@1wt.eu, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, mtk.manpages@gmail.com, sparclinux@vger.kernel.org Message-ID: <20170718134314.Ng3elSNoD7_vs-Bpr-zrhGz8OmGFcebuHEp6dnVe3Qs@z> ebiederm@xmission.com (Eric W. Biederman) writes: > David Miller writes: > >> From: "Eric W. Biederman" >> Date: Fri, 30 Jun 2017 07:39:01 -0500 >> >>> diff --git a/arch/sparc/include/uapi/asm/siginfo.h b/arch/sparc/include/uapi/asm/siginfo.h >>> index 2d9b79ccaa50..6bc5c677e92f 100644 >>> --- a/arch/sparc/include/uapi/asm/siginfo.h >>> +++ b/arch/sparc/include/uapi/asm/siginfo.h >>> @@ -17,6 +17,11 @@ >>> #define SI_NOINFO 32767 /* no information in siginfo_t */ >>> >>> /* >>> + * SIGFPE si_codes >>> + */ >>> +#define FPE_FIXME (__SI_FAULT|0) /* Broken dup of SI_USER */ >>> + >>> +/* >>> * SIGEMT si_codes >>> */ >>> #define EMT_TAGOVF (__SI_FAULT|1) /* tag overflow */ >> >> It's one thing to say FIXME in a comment in a kernel local header or >> C file. >> >> It's quite another to put this into the name of a macro which has >> visibility in the global user compilation namespace. >> >> I don't think you should really do that. > > Good point. > > Sigh. It almost fits because we did do something off in the uapi > exported to userspace and we don't have a header file definition for > that case. > > Still. At this point arch/sparc/include/asm/siginfo.h is > a better fit for that definition. > > I will respin and fix that. Except arch//include/asm/siginfo.h has now been eliminated. So these definitions have to be #ifdef __KERNEL__ #define ..._FIXME #endif In the uapi but not visible in the headers outside of the kernel. Which seems appropriate for these values. Eric