From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Weimer Subject: Re: [PATCH] uapi: avoid namespace conflict in linux/posix_types.h Date: Mon, 17 Jun 2019 20:19:48 +0200 Message-ID: <87a7egdqgr.fsf@oldenburg2.str.redhat.com> References: <20190319165123.3967889-1-arnd@arndb.de> <87tvd2j9ye.fsf@oldenburg2.str.redhat.com> <871s05fd8o.fsf@oldenburg2.str.redhat.com> <87sgs8igfj.fsf@oldenburg2.str.redhat.com> <87k1dkdr9c.fsf@oldenburg2.str.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: (Linus Torvalds's message of "Mon, 17 Jun 2019 11:13:20 -0700") Sender: linux-kernel-owner@vger.kernel.org To: Linus Torvalds Cc: Joseph Myers , Arnd Bergmann , Linux API , linux-arch , Netdev , Laura Abbott , Paul Burton , Deepa Dinamani , Linux List Kernel Mailing List-Id: linux-arch.vger.kernel.org * Linus Torvalds: > On Mon, Jun 17, 2019 at 11:03 AM Florian Weimer wrote: >> >> There's also __kernel_fd_set in . I may have >> lumped this up with , but it has the same problem. > > Hmm. > > That one we might be able to just fix by renaming "fds_bits" to "__fds_bits". > > Unlike the "val[]" thing, I don't think anybody is supposed to access > those fields directly. Well, glibc already calls it __val … > I think fd_set and friends are now supposed to be in > anyway, and the "it was in " is all legacy. Do you suggest to create a header to mirror this? Thanks, Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:60978 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725764AbfFQSTx (ORCPT ); Mon, 17 Jun 2019 14:19:53 -0400 From: Florian Weimer Subject: Re: [PATCH] uapi: avoid namespace conflict in linux/posix_types.h References: <20190319165123.3967889-1-arnd@arndb.de> <87tvd2j9ye.fsf@oldenburg2.str.redhat.com> <871s05fd8o.fsf@oldenburg2.str.redhat.com> <87sgs8igfj.fsf@oldenburg2.str.redhat.com> <87k1dkdr9c.fsf@oldenburg2.str.redhat.com> Date: Mon, 17 Jun 2019 20:19:48 +0200 In-Reply-To: (Linus Torvalds's message of "Mon, 17 Jun 2019 11:13:20 -0700") Message-ID: <87a7egdqgr.fsf@oldenburg2.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: Joseph Myers , Arnd Bergmann , Linux API , linux-arch , Netdev , Laura Abbott , Paul Burton , Deepa Dinamani , Linux List Kernel Mailing Message-ID: <20190617181948.9ZQ5lY7k3iqQNgjf1ovH1XJWRvZ1Ec894Tvb-mlaR-g@z> * Linus Torvalds: > On Mon, Jun 17, 2019 at 11:03 AM Florian Weimer wrote: >> >> There's also __kernel_fd_set in . I may have >> lumped this up with , but it has the same problem. > > Hmm. > > That one we might be able to just fix by renaming "fds_bits" to "__fds_bits". > > Unlike the "val[]" thing, I don't think anybody is supposed to access > those fields directly. Well, glibc already calls it __val … > I think fd_set and friends are now supposed to be in > anyway, and the "it was in " is all legacy. Do you suggest to create a header to mirror this? Thanks, Florian