Re: [PATCH 4/9] signal: Factor start_group_exit out of complete_signal

kernel test robot
2021-06-25T08:48:50Z

[-- Attachment #1: Type: text/plain, Size: 17971 bytes --]

Hi "Eric,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.13-rc7 next-20210624]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Eric-W-Biederman/signal-sh-Use-force_sig-SIGKILL-instead-of-do_group_exit-SIGKILL/20210625-040018
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4a09d388f2ab382f217a764e6a152b3f614246f6
config: riscv-randconfig-s032-20210622 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/096b21cc14d8d22f557833af71ad16318cfe51f0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Eric-W-Biederman/signal-sh-Use-force_sig-SIGKILL-instead-of-do_group_exit-SIGKILL/20210625-040018
git checkout 096b21cc14d8d22f557833af71ad16318cfe51f0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=riscv

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
kernel/signal.c: note: in included file (through include/uapi/asm-generic/signal.h, include/asm-generic/signal.h, arch/riscv/include/generated/uapi/asm/signal.h, ...):
include/uapi/asm-generic/signal-defs.h:82:29: sparse: sparse: multiple address spaces given
kernel/signal.c:195:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:195:31: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:195:31: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:198:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:198:33: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:198:33: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:535:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:535:9: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:535:9: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:539:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:539:34: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:539:34: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:572:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:572:9: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:572:9: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:575:36: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:575:36: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:575:36: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:597:53: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct k_sigaction *ka @@ got struct k_sigaction [noderef] __rcu * @@
kernel/signal.c:597:53: sparse: expected struct k_sigaction *ka
kernel/signal.c:597:53: sparse: got struct k_sigaction [noderef] __rcu *
include/uapi/asm-generic/signal-defs.h:82:29: sparse: sparse: multiple address spaces given
kernel/signal.c:750:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:750:33: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:750:33: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:752:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:752:31: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:752:31: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:939:9: sparse: sparse: cast removes address space '__rcu' of expression
>> kernel/signal.c:1072:63: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct sighand_struct *const sighand @@ got struct sighand_struct [noderef] __rcu *sighand @@
kernel/signal.c:1072:63: sparse: expected struct sighand_struct *const sighand
kernel/signal.c:1072:63: sparse: got struct sighand_struct [noderef] __rcu *sighand
kernel/signal.c:1156:9: sparse: sparse: cast removes address space '__rcu' of expression
kernel/signal.c:1397:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:1397:9: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:1397:9: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:1398:16: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct k_sigaction *action @@ got struct k_sigaction [noderef] __rcu * @@
kernel/signal.c:1398:16: sparse: expected struct k_sigaction *action
kernel/signal.c:1398:16: sparse: got struct k_sigaction [noderef] __rcu *
kernel/signal.c:1415:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:1415:34: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:1415:34: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:1726:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:1726:17: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:1726:17: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:1728:42: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:1728:42: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:1728:42: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:1932:36: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:1932:36: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:1932:36: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:2042:44: sparse: sparse: cast removes address space '__rcu' of expression
kernel/signal.c:2061:65: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *tsk @@ got struct task_struct [noderef] __rcu *parent @@
kernel/signal.c:2061:65: sparse: expected struct task_struct *tsk
kernel/signal.c:2061:65: sparse: got struct task_struct [noderef] __rcu *parent
kernel/signal.c:2062:40: sparse: sparse: cast removes address space '__rcu' of expression
kernel/signal.c:2080:14: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sighand_struct *psig @@ got struct sighand_struct [noderef] __rcu *[noderef] __rcu sighand @@
kernel/signal.c:2080:14: sparse: expected struct sighand_struct *psig
kernel/signal.c:2080:14: sparse: got struct sighand_struct [noderef] __rcu *[noderef] __rcu sighand
kernel/signal.c:2109:46: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected struct task_struct *t @@ got struct task_struct [noderef] __rcu *parent @@
kernel/signal.c:2109:46: sparse: expected struct task_struct *t
kernel/signal.c:2109:46: sparse: got struct task_struct [noderef] __rcu *parent
kernel/signal.c:2110:34: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct task_struct *parent @@ got struct task_struct [noderef] __rcu *parent @@
kernel/signal.c:2110:34: sparse: expected struct task_struct *parent
kernel/signal.c:2110:34: sparse: got struct task_struct [noderef] __rcu *parent
kernel/signal.c:2139:24: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct task_struct *parent @@ got struct task_struct [noderef] __rcu *parent @@
kernel/signal.c:2139:24: sparse: expected struct task_struct *parent
kernel/signal.c:2139:24: sparse: got struct task_struct [noderef] __rcu *parent
kernel/signal.c:2142:24: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct task_struct *parent @@ got struct task_struct [noderef] __rcu *real_parent @@
kernel/signal.c:2142:24: sparse: expected struct task_struct *parent
kernel/signal.c:2142:24: sparse: got struct task_struct [noderef] __rcu *real_parent
kernel/signal.c:2175:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sighand_struct *sighand @@ got struct sighand_struct [noderef] __rcu *sighand @@
kernel/signal.c:2175:17: sparse: expected struct sighand_struct *sighand
kernel/signal.c:2175:17: sparse: got struct sighand_struct [noderef] __rcu *sighand
kernel/signal.c:2250:41: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:2250:41: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:2250:41: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:2252:39: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:2252:39: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:2252:39: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:2300:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:2300:33: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:2300:33: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:2355:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:2355:31: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:2355:31: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:2389:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:2389:31: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:2389:31: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:2391:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:2391:33: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:2391:33: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:2488:41: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:2488:41: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:2488:41: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:2573:41: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:2573:41: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:2573:41: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:2585:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:2585:33: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:2585:33: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:2623:52: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct task_struct *tsk @@ got struct task_struct [noderef] __rcu *parent @@
kernel/signal.c:2623:52: sparse: expected struct task_struct *tsk
kernel/signal.c:2623:52: sparse: got struct task_struct [noderef] __rcu *parent
kernel/signal.c:2625:49: sparse: sparse: cast removes address space '__rcu' of expression
kernel/signal.c:2662:49: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct sighand_struct *sighand @@ got struct sighand_struct [noderef] __rcu *sighand @@
kernel/signal.c:2662:49: sparse: expected struct sighand_struct *sighand
kernel/signal.c:2662:49: sparse: got struct sighand_struct [noderef] __rcu *sighand
kernel/signal.c:2991:27: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:2991:27: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:2991:27: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:3011:29: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:3011:29: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:3011:29: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:3078:27: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:3078:27: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:3078:27: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:3080:29: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:3080:29: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:3080:29: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:3231:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:3231:31: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:3231:31: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:3234:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:3234:33: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:3234:33: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:3617:27: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@
kernel/signal.c:3617:27: sparse: expected struct spinlock [usertype] *lock
kernel/signal.c:3617:27: sparse: got struct spinlock [noderef] __rcu *
kernel/signal.c:3629:37: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct spinlock [usertype] *lock @@ got struct spinlock [noderef] __rcu * @@

vim +1072 kernel/signal.c

1068
1069 void start_group_exit(int exit_code)
1070 {
1071 if (!fatal_signal_pending(current)) {
> 1072 struct sighand_struct *const sighand = current->sighand;
1073
1074 spin_lock_irq(&sighand->siglock);
1075 if (!fatal_signal_pending(current))
1076 start_group_exit_locked(current->signal, exit_code);
1077 spin_unlock_irq(&sighand->siglock);
1078 }
1079 }
1080

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29916 bytes --]