From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshinori Sato Subject: Re: [PATCH v9 00/17] Re-introduce h8300 architecture Date: Tue, 28 Apr 2015 18:09:48 +0900 Message-ID: <87fv7kvctf.wl-ysato@users.sourceforge.jp> References: <1430112924-1134-1-git-send-email-ysato@users.sourceforge.jp> <4238542.6HRp7rHay7@wuerfel> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from mail1.asahi-net.or.jp ([202.224.39.197]:16328 "EHLO mail1.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932454AbbD1JJu (ORCPT ); Tue, 28 Apr 2015 05:09:50 -0400 In-Reply-To: <4238542.6HRp7rHay7@wuerfel> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Stephen Rothwell At Mon, 27 Apr 2015 11:11:28 +0200, Arnd Bergmann wrote: > > On Monday 27 April 2015 14:35:07 Yoshinori Sato wrote: > > Hello. > > I will re-introducing h8300. > > > > I've done one more pass through all of your code. Generally I think you > should at this point ask Stephen Rothwell to add your git tree to linux-next, > and not rewrite the patches any more but instead add patches on top to fix > the remaining issues. OK. > My comments are in several areas: > > - device initialization. This should be updated to use a more modern version > and replace the use of early_platform and static platform_device definitions. > Hmm... A variant isn't probably added, so I think there are no advantages that DeviceTree is adopted. It's considered. > - asm/io.h needs should be rethought OK. > - header files that are functionally identical to the asm-generic variant > and could be replaced with a 'generic-y' Makefile statement OK. > I think all of these should be addressed, but they are not big issues that > would stop you from merging the code in linux-4.2. > > Arnd Thanks. -- Yoshinori Sato