Re: [PATCH v11 00/10] Application Data Integrity feature introduced by SPARC M7

Steven Sistare
2018-02-02T14:16:04Z

On 2/1/2018 9:29 PM, ebiederm@xmission.com wrote:
> Khalid Aziz <khalid.aziz@oracle.com> writes:
>
>> V11 changes:
>> This series is same as v10 and was simply rebased on 4.15 kernel. Can
>> mm maintainers please review patches 2, 7, 8 and 9 which are arch
>> independent, and include/linux/mm.h and mm/ksm.c changes in patch 10
>> and ack these if everything looks good?
>
> I am a bit puzzled how this differs from the pkey's that other
> architectures are implementing to achieve a similar result.
>
> I am a bit mystified why you don't store the tag in a vma
> instead of inventing a new way to store data on page out.
>
> Can you please use force_sig_fault to send these signals instead
> of force_sig_info. Emperically I have found that it is very
> error prone to generate siginfo's by hand, especially on code
> paths where several different si_codes may apply. So it helps
> to go through a helper function to ensure the fiddly bits are
> all correct. AKA the unused bits all need to be set to zero before
> struct siginfo is copied to userspace.
>
> Eric

The ADI tag can be set at a cacheline (64B) granularity, as opposed
to the per-page granularity of pkeys. This allows an object allocator
to color each object differently within a page (rounding to 64B boundaries),
such that a pointer overrun bug from one object to the next will cause a
fault. When pages are paged out, the tags must be saved, hence the
new scheme for storing them. One tag per vma is too coarse.

The combination of fine granularity and pageability makes for a powerful
memory-reference error-detection framework.

This was discussed in more detail when earlier patches were submitted,
but it's been a while, and the distribution was probably narrower.

Khalid can respond to the sig_fault comment.

- Steve