From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v2 15/28] arm64: cpufeature: Move sys_caps_initialised declarations Date: Thu, 14 Sep 2017 10:33:34 +0100 Message-ID: <87h8w5aakx.fsf@linaro.org> References: <1504198860-12951-1-git-send-email-Dave.Martin@arm.com> <1504198860-12951-16-git-send-email-Dave.Martin@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wm0-f43.google.com ([74.125.82.43]:45470 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476AbdINJdh (ORCPT ); Thu, 14 Sep 2017 05:33:37 -0400 Received: by mail-wm0-f43.google.com with SMTP id g206so8970120wme.0 for ; Thu, 14 Sep 2017 02:33:37 -0700 (PDT) In-reply-to: <1504198860-12951-16-git-send-email-Dave.Martin@arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Dave Martin Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Ard Biesheuvel , Szabolcs Nagy , Richard Sandiford , kvmarm@lists.cs.columbia.edu, libc-alpha@sourceware.org, linux-arch@vger.kernel.org, Suzuki K Poulose Dave Martin writes: > update_cpu_features() currently cannot tell whether it is being > called during early or late secondary boot. This doesn't > desperately matter for anything it currently does. > > However, SVE will need to know here whether the set of available > vector lengths is fixed of still to be determined when booting a > CPU so that it can be updated appropriately. > > This patch simply moves the sys_caps_initialised stuff to the top > of the file so that it can be more widely. There doesn't seem to > be a more obvious place to put it. > > Signed-off-by: Dave Martin > Cc: Suzuki K Poulose Reviewed-by: Alex Bennée > --- > arch/arm64/kernel/cpufeature.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index cd52d36..43ba8df 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -51,6 +51,21 @@ unsigned int compat_elf_hwcap2 __read_mostly; > DECLARE_BITMAP(cpu_hwcaps, ARM64_NCAPS); > EXPORT_SYMBOL(cpu_hwcaps); > > +/* > + * Flag to indicate if we have computed the system wide > + * capabilities based on the boot time active CPUs. This > + * will be used to determine if a new booting CPU should > + * go through the verification process to make sure that it > + * supports the system capabilities, without using a hotplug > + * notifier. > + */ > +static bool sys_caps_initialised; > + > +static inline void set_sys_caps_initialised(void) > +{ > + sys_caps_initialised = true; > +} > + > static int dump_cpu_hwcaps(struct notifier_block *self, unsigned long v, void *p) > { > /* file-wide pr_fmt adds "CPU features: " prefix */ > @@ -1041,21 +1056,6 @@ void __init enable_cpu_capabilities(const struct arm64_cpu_capabilities *caps) > } > > /* > - * Flag to indicate if we have computed the system wide > - * capabilities based on the boot time active CPUs. This > - * will be used to determine if a new booting CPU should > - * go through the verification process to make sure that it > - * supports the system capabilities, without using a hotplug > - * notifier. > - */ > -static bool sys_caps_initialised; > - > -static inline void set_sys_caps_initialised(void) > -{ > - sys_caps_initialised = true; > -} > - > -/* > * Check for CPU features that are used in early boot > * based on the Boot CPU value. > */ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com ([74.125.82.43]:45470 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476AbdINJdh (ORCPT ); Thu, 14 Sep 2017 05:33:37 -0400 Received: by mail-wm0-f43.google.com with SMTP id g206so8970120wme.0 for ; Thu, 14 Sep 2017 02:33:37 -0700 (PDT) References: <1504198860-12951-1-git-send-email-Dave.Martin@arm.com> <1504198860-12951-16-git-send-email-Dave.Martin@arm.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v2 15/28] arm64: cpufeature: Move sys_caps_initialised declarations In-reply-to: <1504198860-12951-16-git-send-email-Dave.Martin@arm.com> Date: Thu, 14 Sep 2017 10:33:34 +0100 Message-ID: <87h8w5aakx.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Dave Martin Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Ard Biesheuvel , Szabolcs Nagy , Richard Sandiford , kvmarm@lists.cs.columbia.edu, libc-alpha@sourceware.org, linux-arch@vger.kernel.org, Suzuki K Poulose Message-ID: <20170914093334.EtGbPdNOcJG1rnJSEdwalZsXZ768HtXE6JYHcWUoZbE@z> Dave Martin writes: > update_cpu_features() currently cannot tell whether it is being > called during early or late secondary boot. This doesn't > desperately matter for anything it currently does. > > However, SVE will need to know here whether the set of available > vector lengths is fixed of still to be determined when booting a > CPU so that it can be updated appropriately. > > This patch simply moves the sys_caps_initialised stuff to the top > of the file so that it can be more widely. There doesn't seem to > be a more obvious place to put it. > > Signed-off-by: Dave Martin > Cc: Suzuki K Poulose Reviewed-by: Alex Bennée > --- > arch/arm64/kernel/cpufeature.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index cd52d36..43ba8df 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -51,6 +51,21 @@ unsigned int compat_elf_hwcap2 __read_mostly; > DECLARE_BITMAP(cpu_hwcaps, ARM64_NCAPS); > EXPORT_SYMBOL(cpu_hwcaps); > > +/* > + * Flag to indicate if we have computed the system wide > + * capabilities based on the boot time active CPUs. This > + * will be used to determine if a new booting CPU should > + * go through the verification process to make sure that it > + * supports the system capabilities, without using a hotplug > + * notifier. > + */ > +static bool sys_caps_initialised; > + > +static inline void set_sys_caps_initialised(void) > +{ > + sys_caps_initialised = true; > +} > + > static int dump_cpu_hwcaps(struct notifier_block *self, unsigned long v, void *p) > { > /* file-wide pr_fmt adds "CPU features: " prefix */ > @@ -1041,21 +1056,6 @@ void __init enable_cpu_capabilities(const struct arm64_cpu_capabilities *caps) > } > > /* > - * Flag to indicate if we have computed the system wide > - * capabilities based on the boot time active CPUs. This > - * will be used to determine if a new booting CPU should > - * go through the verification process to make sure that it > - * supports the system capabilities, without using a hotplug > - * notifier. > - */ > -static bool sys_caps_initialised; > - > -static inline void set_sys_caps_initialised(void) > -{ > - sys_caps_initialised = true; > -} > - > -/* > * Check for CPU features that are used in early boot > * based on the Boot CPU value. > */ -- Alex Bennée