From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH v5 01/16] x86/cpu: create Dhyana init file and register new cpu_dev to system Date: Wed, 29 Aug 2018 12:35:59 -0700 Message-ID: <87mut52cf4.fsf@linux.intel.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Pu Wen's message of "Wed, 29 Aug 2018 20:42:49 +0800") Sender: linux-kernel-owner@vger.kernel.org To: Pu Wen Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, thomas.lendacky@amd.com, bp@alien8.de, pbonzini@redhat.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org Pu Wen writes: > Add x86 architecture support for new processor Hygon Dhyana Family 18h. > Rework to create a separated file(arch/x86/kernel/cpu/hygon.c) from the > AMD init one(arch/x86/kernel/cpu/amd.c) to initialize Dhyana CPU. Standard approach would be to move the shared code into a different file and call it from both amd.c and hygon.c instead of duplicating. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com ([192.55.52.93]:34795 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727392AbeH2Xe3 (ORCPT ); Wed, 29 Aug 2018 19:34:29 -0400 From: Andi Kleen Subject: Re: [PATCH v5 01/16] x86/cpu: create Dhyana init file and register new cpu_dev to system References: Date: Wed, 29 Aug 2018 12:35:59 -0700 In-Reply-To: (Pu Wen's message of "Wed, 29 Aug 2018 20:42:49 +0800") Message-ID: <87mut52cf4.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-arch-owner@vger.kernel.org List-ID: To: Pu Wen Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, thomas.lendacky@amd.com, bp@alien8.de, pbonzini@redhat.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Message-ID: <20180829193559.vWAS5TLhaxkK_Dq5QauZv6_vrPUKEOWBNJbWGooaCYM@z> Pu Wen writes: > Add x86 architecture support for new processor Hygon Dhyana Family 18h. > Rework to create a separated file(arch/x86/kernel/cpu/hygon.c) from the > AMD init one(arch/x86/kernel/cpu/amd.c) to initialize Dhyana CPU. Standard approach would be to move the shared code into a different file and call it from both amd.c and hygon.c instead of duplicating. -Andi