From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Axtens Subject: Re: [PATCH v2 1/2] kasan: support instrumented bitops combined with generic bitops Date: Wed, 04 Dec 2019 10:39:44 +1100 Message-ID: <87pnh5dlmn.fsf@dja-thinkpad.axtens.net> References: <20190820024941.12640-1-dja@axtens.net> <877e6vutiu.fsf@dja-thinkpad.axtens.net> <878sp57z44.fsf@dja-thinkpad.axtens.net> <87a78xgu8o.fsf@dja-thinkpad.axtens.net> <87y2wbf0xx.fsf@dja-thinkpad.axtens.net> <87r21lef1k.fsf@mpe.ellerman.id.au> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <87r21lef1k.fsf@mpe.ellerman.id.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Michael Ellerman , Marco Elver Cc: linux-arch , linux-s390@vger.kernel.org, the arch/x86 maintainers , linuxppc-dev@lists.ozlabs.org, kasan-dev List-Id: linux-arch.vger.kernel.org Hi Michael, > I only just noticed this thread as I was about to send a pull request > for these two commits. > > I think I agree that test_bit() shouldn't move (yet), but I dislike that > the documentation ends up being confusing due to this patch. > > So I'm inclined to append or squash in the patch below, which removes > the new headers from the documentation. The end result is the docs look > more or less the same, just the ordering of some of the functions > changes. But we don't end up with test_bit() under the "Non-atomic" > header, and then also documented in Documentation/atomic_bitops.txt. > > Thoughts? That sounds good to me. Regards, Daniel > > cheers > > > diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst > index 2caaeb55e8dd..4ac53a1363f6 100644 > --- a/Documentation/core-api/kernel-api.rst > +++ b/Documentation/core-api/kernel-api.rst > @@ -57,21 +57,12 @@ The Linux kernel provides more basic utility functions. > Bit Operations > -------------- > > -Atomic Operations > -~~~~~~~~~~~~~~~~~ > - > .. kernel-doc:: include/asm-generic/bitops/instrumented-atomic.h > :internal: > > -Non-atomic Operations > -~~~~~~~~~~~~~~~~~~~~~ > - > .. kernel-doc:: include/asm-generic/bitops/instrumented-non-atomic.h > :internal: > > -Locking Operations > -~~~~~~~~~~~~~~~~~~ > - > .. kernel-doc:: include/asm-generic/bitops/instrumented-lock.h > :internal: > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-f67.google.com ([209.85.216.67]:33476 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726224AbfLCXjt (ORCPT ); Tue, 3 Dec 2019 18:39:49 -0500 Received: by mail-pj1-f67.google.com with SMTP id r67so2170151pjb.0 for ; Tue, 03 Dec 2019 15:39:48 -0800 (PST) From: Daniel Axtens Subject: Re: [PATCH v2 1/2] kasan: support instrumented bitops combined with generic bitops In-Reply-To: <87r21lef1k.fsf@mpe.ellerman.id.au> References: <20190820024941.12640-1-dja@axtens.net> <877e6vutiu.fsf@dja-thinkpad.axtens.net> <878sp57z44.fsf@dja-thinkpad.axtens.net> <87a78xgu8o.fsf@dja-thinkpad.axtens.net> <87y2wbf0xx.fsf@dja-thinkpad.axtens.net> <87r21lef1k.fsf@mpe.ellerman.id.au> Date: Wed, 04 Dec 2019 10:39:44 +1100 Message-ID: <87pnh5dlmn.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-arch-owner@vger.kernel.org List-ID: To: Michael Ellerman , Marco Elver Cc: linux-s390@vger.kernel.org, the arch/x86 maintainers , kasan-dev , linux-arch , linuxppc-dev@lists.ozlabs.org Message-ID: <20191203233944.RaNkZl3fV8AAiOBoKpTI3ZrDaUg-Sl8OL_6OdMNP6Ik@z> Hi Michael, > I only just noticed this thread as I was about to send a pull request > for these two commits. > > I think I agree that test_bit() shouldn't move (yet), but I dislike that > the documentation ends up being confusing due to this patch. > > So I'm inclined to append or squash in the patch below, which removes > the new headers from the documentation. The end result is the docs look > more or less the same, just the ordering of some of the functions > changes. But we don't end up with test_bit() under the "Non-atomic" > header, and then also documented in Documentation/atomic_bitops.txt. > > Thoughts? That sounds good to me. Regards, Daniel > > cheers > > > diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst > index 2caaeb55e8dd..4ac53a1363f6 100644 > --- a/Documentation/core-api/kernel-api.rst > +++ b/Documentation/core-api/kernel-api.rst > @@ -57,21 +57,12 @@ The Linux kernel provides more basic utility functions. > Bit Operations > -------------- > > -Atomic Operations > -~~~~~~~~~~~~~~~~~ > - > .. kernel-doc:: include/asm-generic/bitops/instrumented-atomic.h > :internal: > > -Non-atomic Operations > -~~~~~~~~~~~~~~~~~~~~~ > - > .. kernel-doc:: include/asm-generic/bitops/instrumented-non-atomic.h > :internal: > > -Locking Operations > -~~~~~~~~~~~~~~~~~~ > - > .. kernel-doc:: include/asm-generic/bitops/instrumented-lock.h > :internal: >