From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshinori Sato Subject: Re: [PATCH v3 01/15] h8300: Assembly headers. Date: Tue, 17 Feb 2015 16:39:42 +0900 Message-ID: <87sie5kmv5.wl-ysato@users.sourceforge.jp> References: <1423986573-2329-1-git-send-email-ysato@users.sourceforge.jp> <1423986573-2329-2-git-send-email-ysato@users.sourceforge.jp> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from mail1.asahi-net.or.jp ([202.224.39.197]:45029 "EHLO mail1.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753062AbbBQHjo (ORCPT ); Tue, 17 Feb 2015 02:39:44 -0500 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: "linux-kernel@vger.kernel.org" , Linux-Arch At Sun, 15 Feb 2015 10:11:58 +0100, Geert Uytterhoeven wrote: > > Hi Sato-san, > > On Sun, Feb 15, 2015 at 8:49 AM, Yoshinori Sato > wrote: > > --- /dev/null > > +++ b/arch/h8300/include/asm/io.h > > @@ -0,0 +1,372 @@ > > +#ifndef _H8300_IO_H > > +#define _H8300_IO_H > > + > > +#ifdef __KERNEL__ > > + > > +#include > > + > > +/* > > + * These are for ISA/PCI shared memory _only_ and should never be used > > + * on any other type of memory, including Zorro memory. They are meant to > > + * access the bus in the bus byte order which is little-endian!. > > + * > > + * readX/writeX() are used to access memory mapped devices. On some > > + * architectures the memory mapped IO stuff needs to be accessed > > + * differently. On the m68k architecture, we just read/write the > > + * memory location directly. > > + */ > > +/* ++roman: The assignments to temp. vars avoid that gcc sometimes generates > > + * two accesses to memory, which may be undesirable for some devices. > > + */ > > While some of the above applies to h8300, I think you should remove > the parts that don't apply. It's necessary by several drivers, so it has been left. An unnecessary part is also included, so I have to remove the part. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Yoshinori Sato