From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66FEB3EBF19; Wed, 15 Jul 2026 09:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784106239; cv=none; b=C6kBO71TALRpemTcAZ/QRk0zIfOPDnwC+AFv0+oa9tqUExs0a3nLLWHj3jjytNNXnwiWf3VKIGh2x7gD8SLgjJbWGlyKyYP2QOmds96s+yBTmmAm+TTX8RvE6zPGSsa5MIpxuVyMJCcyAgOGmO44wza2EyWk/paEsp0+YX7KxsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784106239; c=relaxed/simple; bh=VX7v5KznOGst/S32zIq13isYK9aQbcFUdNYlBguUuc0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=txYEbw9RYV8GTRaHxLgMlMDh31ZiqNr39Rdt+sq2bE3oum+k7DfOJqlnqPr5netxxI6rN7kLozxie73tQS0fmda7Lgf0gKwUqPNRcomrQJY+8TRfpc0e6kVYKEXcd3vEqzp9amoVjTol8crrDbG3szKV/ZLoPRLliNrsgvEfPY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Mp9b9tA1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mp9b9tA1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 110871F000E9; Wed, 15 Jul 2026 09:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784106230; bh=VX7v5KznOGst/S32zIq13isYK9aQbcFUdNYlBguUuc0=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=Mp9b9tA1KsQJcysDV5RgBKBMJTWV+8PyD1YK/DtL5YbfSJnfI2mdI68YW8UhLCZsN yHzbUs5VcVEC4mFb+D2l+PtQWybslLwNtVqM7ljXGi8kYsmMs56+Ijv0vyr+iRpsC8 vOP7qSTE8VGiPtNWfpzA4RhaYAMQMF0cuxho3kGHt/9zuP7emOkG0JxyBE2dIs4Zzj i7WyuimjZqPZ6UkZO9oPeX19hsIGSbz06E13ot/gmtLrxK24748nIGVEqQI+cbKF/d Sm4O626cWSzvQEDbEtTWkY9c4yJvyd4TGLZfKBAuRRkw7ohLEo2/kz0DKlHbUrG8lY ZgWrFIC1PQf0w== From: Thomas Gleixner To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= Cc: Arnd Bergmann , Andy Lutomirski , Vincenzo Frascino , Nathan Chancellor , Nicolas Schier , Thomas Bogendoerfer , Daniel Lezcano , Mark Rutland , Marc Zyngier , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Huacai Chen , WANG Xuerui , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, loongarch@lists.linux.dev Subject: Re: [PATCH 3/7] MIPS: csrc-r4k: Replace CONFIG_GENERIC_GETTIMEOFDAY ifdeffery with IS_ENABLED() In-Reply-To: <20260715102751-d1ed7195-f541-484e-9843-73ee4237b7b5@linutronix.de> References: <20260709-vdso-arch-clockmodes-v1-0-3fd780bbf851@linutronix.de> <20260709-vdso-arch-clockmodes-v1-3-3fd780bbf851@linutronix.de> <87wluwoe1c.ffs@fw13> <20260715102751-d1ed7195-f541-484e-9843-73ee4237b7b5@linutronix.de> Date: Wed, 15 Jul 2026 11:03:47 +0200 Message-ID: <87tsq0oc98.ffs@fw13> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Jul 15 2026 at 10:43, Thomas Wei=C3=9Fschuh wrote: > On Wed, Jul 15, 2026 at 10:25:19AM +0200, Thomas Gleixner wrote: >> and then you can just unconditionally set clocksource::vdso_clock_mode >> in all drivers. >>=20 >> No? > > It will weaken the sanity check in __clocksouce_register_scale() if > CONFIG_GENERIC_GETTIMEOFDAY=3Dn. I am not sure what that sanity check > is supposed to protect against, so I left it as is. > If we can weaken the check, or maybe even remove it, > I'm all for your simpler aproach. The sanity check is there to catch random numbers being assigned. I does not weaken when it's actually unused :)