From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [REVIEW][PATCH 08/20] signal/x86/traps: Move setting error_code and trap_nr into do_trap_no_signal Date: Fri, 21 Sep 2018 15:39:19 +0200 Message-ID: <87tvmj3r7c.fsf@xmission.com> References: <87y3bzk6yv.fsf@xmission.com> <20180918000546.12552-8-ebiederm@xmission.com> <877ejf58aa.fsf@xmission.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <877ejf58aa.fsf@xmission.com> (Eric W. Biederman's message of "Fri, 21 Sep 2018 14:45:01 +0200") Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Ingo Molnar , x86@kernel.org List-Id: linux-arch.vger.kernel.org ebiederm@xmission.com (Eric W. Biederman) writes: > I also realized for clarity of the code I could have moved show_signal > into do_trap_no_signal as well. I will post a follow up change where I > do that. Except of course do_trap_no_signal does not take a signal number show it can't call show signal. On second glance I don't see enough gain to make it worth moving show_signal into do_trap_no_signal. So I am just going to skip that for now. Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out02.mta.xmission.com ([166.70.13.232]:60095 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728365AbeIUT20 (ORCPT ); Fri, 21 Sep 2018 15:28:26 -0400 From: ebiederm@xmission.com (Eric W. Biederman) References: <87y3bzk6yv.fsf@xmission.com> <20180918000546.12552-8-ebiederm@xmission.com> <877ejf58aa.fsf@xmission.com> Date: Fri, 21 Sep 2018 15:39:19 +0200 In-Reply-To: <877ejf58aa.fsf@xmission.com> (Eric W. Biederman's message of "Fri, 21 Sep 2018 14:45:01 +0200") Message-ID: <87tvmj3r7c.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [REVIEW][PATCH 08/20] signal/x86/traps: Move setting error_code and trap_nr into do_trap_no_signal Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Ingo Molnar , x86@kernel.org Message-ID: <20180921133919.UWf0nMmdfipR-WAocfRWj3Tu4UmRetv7-KPmopKTFkU@z> ebiederm@xmission.com (Eric W. Biederman) writes: > I also realized for clarity of the code I could have moved show_signal > into do_trap_no_signal as well. I will post a follow up change where I > do that. Except of course do_trap_no_signal does not take a signal number show it can't call show signal. On second glance I don't see enough gain to make it worth moving show_signal into do_trap_no_signal. So I am just going to skip that for now. Eric