From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB010C433F5 for ; Tue, 17 May 2022 15:38:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350357AbiEQPiL (ORCPT ); Tue, 17 May 2022 11:38:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350412AbiEQPiA (ORCPT ); Tue, 17 May 2022 11:38:00 -0400 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D06955047D; Tue, 17 May 2022 08:37:04 -0700 (PDT) Received: from in01.mta.xmission.com ([166.70.13.51]:55038) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nqzFo-00HUt8-UL; Tue, 17 May 2022 09:36:56 -0600 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:38510 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nqzFn-00CCn9-VR; Tue, 17 May 2022 09:36:56 -0600 From: "Eric W. Biederman" To: Huacai Chen Cc: WANG Xuerui , Huacai Chen , Arnd Bergmann , Andy Lutomirski , Thomas Gleixner , Peter Zijlstra , Andrew Morton , David Airlie , Jonathan Corbet , Linus Torvalds , "" , "open list:DOCUMENTATION" , LKML , Xuefeng Li , Yanteng Si , Guo Ren , Jiaxun Yang , Stephen Rothwell , Al Viro References: <20220514080402.2650181-1-chenhuacai@loongson.cn> <20220514080402.2650181-15-chenhuacai@loongson.cn> <87bkvxd12b.fsf@email.froward.int.ebiederm.org> Date: Tue, 17 May 2022 10:36:48 -0500 In-Reply-To: (Huacai Chen's message of "Tue, 17 May 2022 10:08:18 +0800") Message-ID: <87v8u49nn3.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1nqzFn-00CCn9-VR;;;mid=<87v8u49nn3.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX1/z8zdXGiWLxn4UIls5cu+131SNiPOvwrA= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH V10 14/22] LoongArch: Add signal handling support X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org Huacai Chen writes: > Hi, Eric, > > On Mon, May 16, 2022 at 10:07 PM Eric W. Biederman > wrote: >> >> I can understand exporting these values but the names aren't very >> well namespaced at all. Which means they could accidentially >> conflict with things. >> >> It would probably be better to do: >> SC_USED_FP >> SC_ADDRERR_RD >> SC_ADDRERR_WR > SC_ prefix is good, but ADRERR_RD/ADRERR_WR is used together with > SIGSEGV/SIGBUS, so I want to keep the same as BUS_ADRERR (a single D) > if possible. Fair enough about the single D. Please add the prefix in the next version. Especially for kabi symbols in a namespace is a very good idea. >> Given that neither lsx_context nor lasx_context are used in the kernel >> code yet I would very much prefer that their inclusion wait until there >> is actual code that needs them. >> >> If nothing else that will put the definitions in context so people can >> more easily see the big picture and understand how the pieces fit. > OK, I will remove lsx_context/lasx_context in the next version. Thanks, Eric