public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Khalid Aziz <khalid.aziz@oracle.com>
Cc: davem@davemloft.net, dave.hansen@linux.intel.com,
	aarcange@redhat.com, akpm@linux-foundation.org,
	allen.pais@oracle.com, anthony.yznaga@oracle.com, arnd@arndb.de,
	babu.moger@oracle.com, benh@kernel.crashing.org,
	bob.picco@oracle.com, bsingharora@gmail.com, corbet@lwn.net,
	dan.j.williams@intel.com, dave.jiang@intel.com,
	david.j.aldridge@oracle.com, elena.reshetova@intel.com,
	glx@linutronix.de, gregkh@linuxfoundation.org,
	hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, hpa@zytor.com,
	hughd@google.com, imbrenda@linux.vnet.ibm.com, jack@suse.cz,
	jag.raman@oracle.com, jane.chu@oracle.com, jglisse@redhat.com,
	jroedel@suse.de, khalid@gonehiking.org,
	khandual@linux.vnet.ibm.com, kirill.shutemov@linux.intel.com,
	kstewart@linuxfoundation.org, ktkhai@virtuozzo.com,
	liam.merwick@oracle.com, linux-arch@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vg
Subject: Re: [PATCH v11 00/10] Application Data Integrity feature introduced by SPARC M7
Date: Thu, 01 Feb 2018 20:29:14 -0600	[thread overview]
Message-ID: <87wozwi0p1.fsf@xmission.com> (raw)
In-Reply-To: <cover.1517497017.git.khalid.aziz@oracle.com> (Khalid Aziz's message of "Thu, 1 Feb 2018 11:01:08 -0700")

Khalid Aziz <khalid.aziz@oracle.com> writes:

> V11 changes:
> This series is same as v10 and was simply rebased on 4.15 kernel. Can
> mm maintainers please review patches 2, 7, 8 and 9 which are arch
> independent, and include/linux/mm.h and mm/ksm.c changes in patch 10
> and ack these if everything looks good?

I am a bit puzzled how this differs from the pkey's that other
architectures are implementing to achieve a similar result.

I am a bit mystified why you don't store the tag in a vma
instead of inventing a new way to store data on page out.

Can you please use force_sig_fault to send these signals instead
of force_sig_info.  Emperically I have found that it is very
error prone to generate siginfo's by hand, especially on code
paths where several different si_codes may apply.  So it helps
to go through a helper function to ensure the fiddly bits are
all correct.  AKA the unused bits all need to be set to zero before
struct siginfo is copied to userspace.

Eric

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Khalid Aziz <khalid.aziz@oracle.com>
Cc: davem@davemloft.net, dave.hansen@linux.intel.com,
	aarcange@redhat.com, akpm@linux-foundation.org,
	allen.pais@oracle.com, anthony.yznaga@oracle.com, arnd@arndb.de,
	babu.moger@oracle.com, benh@kernel.crashing.org,
	bob.picco@oracle.com, bsingharora@gmail.com, corbet@lwn.net,
	dan.j.williams@intel.com, dave.jiang@intel.com,
	david.j.aldridge@oracle.com, elena.reshetova@intel.com,
	glx@linutronix.de, gregkh@linuxfoundation.org,
	hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, hpa@zytor.com,
	hughd@google.com, imbrenda@linux.vnet.ibm.com, jack@suse.cz,
	jag.raman@oracle.com, jane.chu@oracle.com, jglisse@redhat.com,
	jroedel@suse.de, khalid@gonehiking.org,
	khandual@linux.vnet.ibm.com, kirill.shutemov@linux.intel.com,
	kstewart@linuxfoundation.org, ktkhai@virtuozzo.com,
	liam.merwick@oracle.com, linux-arch@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	linux@roeck-us.net, me@tobin.cc, mgorman@suse.de,
	mgorman@techsingularity.net, mhocko@suse.com,
	mike.kravetz@oracle.com, minchan@kernel.org, mingo@kernel.org,
	mingo@redhat.com, mpe@ellerman.id.au, nadav.amit@gmail.com,
	nagarathnam.muthusamy@oracle.com, nborisov@suse.com,
	n-horiguchi@ah.jp.nec.com, nick.alcock@oracle.com,
	nitin.m.gupta@oracle.com, ombredanne@nexb.com,
	pasha.tatashin@oracle.com, paulus@samba.org,
	pombredanne@nexb.com, punit.agrawal@arm.com,
	rob.gardner@oracle.com, ross.zwisler@linux.intel.com,
	shannon.nelson@oracle.com, shli@fb.com,
	sparclinux@vger.kernel.org, steven.sistare@oracle.com,
	tglx@linutronix.de, thomas.tai@oracle.com, tklauser@distanz.ch,
	tom.hromatka@oracle.com, vegard.nossum@oracle.com,
	vijay.ac.kumar@oracle.com, willy@infradead.org, x86@kernel.org,
	zi.yan@cs.rutgers.edu
Subject: Re: [PATCH v11 00/10] Application Data Integrity feature introduced by SPARC M7
Date: Thu, 01 Feb 2018 20:29:14 -0600	[thread overview]
Message-ID: <87wozwi0p1.fsf@xmission.com> (raw)
Message-ID: <20180202022914.RCp8XKuUuL7wlN41XmTg04Mxcrv5M8iR1Jxx6M-vo0w@z> (raw)
In-Reply-To: <cover.1517497017.git.khalid.aziz@oracle.com> (Khalid Aziz's message of "Thu, 1 Feb 2018 11:01:08 -0700")

Khalid Aziz <khalid.aziz@oracle.com> writes:

> V11 changes:
> This series is same as v10 and was simply rebased on 4.15 kernel. Can
> mm maintainers please review patches 2, 7, 8 and 9 which are arch
> independent, and include/linux/mm.h and mm/ksm.c changes in patch 10
> and ack these if everything looks good?

I am a bit puzzled how this differs from the pkey's that other
architectures are implementing to achieve a similar result.

I am a bit mystified why you don't store the tag in a vma
instead of inventing a new way to store data on page out.

Can you please use force_sig_fault to send these signals instead
of force_sig_info.  Emperically I have found that it is very
error prone to generate siginfo's by hand, especially on code
paths where several different si_codes may apply.  So it helps
to go through a helper function to ensure the fiddly bits are
all correct.  AKA the unused bits all need to be set to zero before
struct siginfo is copied to userspace.

Eric

  parent reply	other threads:[~2018-02-02  2:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-01 18:01 [PATCH v11 00/10] Application Data Integrity feature introduced by SPARC M7 Khalid Aziz
2018-02-01 18:01 ` Khalid Aziz
2018-02-01 18:01 ` [PATCH v11 01/10] signals, sparc: Add signal codes for ADI violations Khalid Aziz
2018-02-01 18:01   ` Khalid Aziz
2018-02-01 18:01 ` [PATCH v11 02/10] mm, swap: Add infrastructure for saving page metadata on swap Khalid Aziz
2018-02-01 18:01   ` Khalid Aziz
2018-02-02  2:29 ` Eric W. Biederman [this message]
2018-02-02  2:29   ` [PATCH v11 00/10] Application Data Integrity feature introduced by SPARC M7 Eric W. Biederman
2018-02-02 14:13   ` Steven Sistare
2018-02-02 14:13     ` Steven Sistare
2018-02-02 14:59   ` Khalid Aziz
2018-02-02 14:59     ` Khalid Aziz
2018-02-07  7:38     ` Eric W. Biederman
2018-02-07  7:38       ` Eric W. Biederman
2018-02-07 16:04       ` Khalid Aziz
2018-02-07 16:04         ` Khalid Aziz
2018-02-07 17:42         ` Eric W. Biederman
2018-02-07 17:42           ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wozwi0p1.fsf@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=allen.pais@oracle.com \
    --cc=anthony.yznaga@oracle.com \
    --cc=arnd@arndb.de \
    --cc=babu.moger@oracle.com \
    --cc=benh@kernel.crashing.org \
    --cc=bob.picco@oracle.com \
    --cc=bsingharora@gmail.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=davem@davemloft.net \
    --cc=david.j.aldridge@oracle.com \
    --cc=elena.reshetova@intel.com \
    --cc=glx@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=hillf.zj@alibaba-inc.com \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=imbrenda@linux.vnet.ibm.com \
    --cc=jack@suse.cz \
    --cc=jag.raman@oracle.com \
    --cc=jane.chu@oracle.com \
    --cc=jglisse@redhat.com \
    --cc=jroedel@suse.de \
    --cc=khalid.aziz@oracle.com \
    --cc=khalid@gonehiking.org \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=ktkhai@virtuozzo.com \
    --cc=liam.merwick@oracle.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox