From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4300F38F97 for ; Tue, 20 Feb 2024 02:03:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708394630; cv=none; b=NkuiFlGadQPNhznrtEv0olHfC2xf3BmzS/Vfl4ipTYUywFpARJpBuZ1iYv3HV/jJZDGnXcKJBCGQ9KdaoixOGI3tcT+DvExh7FkuDICqP6RAXmqmTZIVbQirUok2VlrT+/zZyl3QUeSBCZpHOGCs26A6De+qfAoP9BfyY72OXo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708394630; c=relaxed/simple; bh=tl0G24XOjbGzUHwVuSKAML2L5w2w/ukL5jhI0xL8Wbk=; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID: MIME-Version:Content-Type; b=RBXJzC7aL0vMZayZIpWZLzi0aWuN/0DkqE2YM3bukT6KJTH5GlEFzPux3t10f77kQFxtewbeOJEvv0Xof0q7FeBhoyrydOotFMBQfTT857qyfnOJRbOQSlB7sNmkqSKIeKQCuP/NWLuhTTdanEqNsdXUPFf39LAnU+KNbURIi5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Suls8slr; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Suls8slr" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1dc0e5b223eso6307775ad.1 for ; Mon, 19 Feb 2024 18:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708394628; x=1708999428; darn=vger.kernel.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=Ut8HYrvCDFac0esrbFqk2cfgA544kkLlPQaAT6Wttz0=; b=Suls8slrlKu1GWrkWeiJyMMq8d8OmJjG4HQRDqGKkDxCGvnQXj3NkpLK8YeFHW7jhR AAgjw2yso4yD4zEgGmYJfcDHbqiouKzolEOKeB9Hpxwi19d8pL2q8lCXZca3vncoL3SQ k1hTGX6ajH2IjdKm0iQkpPvFirt5Q8PlGudv6VB60Whz+Po+CFzEzUCM9fOo5UdvTl46 /WqgZXqtFBCVds2NvymzgcVNOQjTg/hfB6M8TJj69Kh9PyDrR2Elmf2U9h2Hl0j/gZpQ F6wCGVVpNXxcahTQO8wAAuZ+Rk1Z1zsipM4+hqxCKo7TiqlZofPkHZXHt+ViOklVfoLN dfWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708394628; x=1708999428; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ut8HYrvCDFac0esrbFqk2cfgA544kkLlPQaAT6Wttz0=; b=sYtZGHNjrtvmPoQEz4alRCM+W45xYcInOlwSOajSeOdp+kgBjPddRG15737If8ZvV6 ElcmZlWCRdGuqHWy1jeZ6bptbT6U4h54UeY0nL6w+4o/ZTBj47XeEqUEEB49210Ev57w +3EHFfcBSi1v0uCTY5D2lZwAEqOkwG5/iAFDAyhvJZfWaLTFerH04aEmWCGtFUrfMUd0 CJsSEX1WaGxrGjrYWloE8h2DWQaemZ0xwMPSCejJse7hKMQ5Ylyy6iw6+5njtRLN79EY xtKnhgmoyDO7SHbZ+7OZgn2U8lzfjNzkWloIbmiM+WzIZgRtgcuihOvXzSxzPBqJ1yHA 4Ewg== X-Forwarded-Encrypted: i=1; AJvYcCWUaP+Gy8Ux33eCh8GqoF/ReSLgc2p9YGKUPdKPsRv4kJ288leqMYdTCMpaZzKt46cPkCQ0+5gNEwTtjqMzq9VWZyBB06AMCSPeJw== X-Gm-Message-State: AOJu0YwYQ5IlMQha343lE+vs+cgvS5sSSzqGWAm+nxrVuDFzvV0mdTQb rEt10/63tQFTMna41gEKZ8LSyoRHU8V776uF1DPYchWdSZdClcfMYQObzsGcPhs= X-Google-Smtp-Source: AGHT+IGPIHUy8hPqScHiSoGgxRjrCJE9JJnAWETOMrecbYtciaMsbgwu6AZ9cPzFGRlUwvHmQwNF1w== X-Received: by 2002:a17:902:e5c3:b0:1db:fcc8:7d96 with SMTP id u3-20020a170902e5c300b001dbfcc87d96mr4258933plf.14.1708394628501; Mon, 19 Feb 2024 18:03:48 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:a328:9cae:8aed:4821]) by smtp.gmail.com with ESMTPSA id kg3-20020a170903060300b001dbbd4ee1f6sm5058425plb.11.2024.02.19.18.03.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 18:03:48 -0800 (PST) References: <20240203-arm64-gcs-v8-0-c9fec77673ef@kernel.org> <20240203-arm64-gcs-v8-23-c9fec77673ef@kernel.org> User-agent: mu4e 1.10.8; emacs 29.1 From: Thiago Jung Bauermann To: Mark Brown Cc: Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Kees Cook , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v8 23/38] arm64/signal: Set up and restore the GCS context for signal handlers In-reply-to: <20240203-arm64-gcs-v8-23-c9fec77673ef@kernel.org> Date: Mon, 19 Feb 2024 23:03:46 -0300 Message-ID: <87zfvv7uyl.fsf@linaro.org> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Mark Brown writes: > +#ifdef CONFIG_ARM64_GCS > +static int gcs_restore_signal(void) > +{ > + u64 gcspr_el0, cap; > + int ret; > + > + if (!system_supports_gcs()) > + return 0; > + > + if (!(current->thread.gcs_el0_mode & PR_SHADOW_STACK_ENABLE)) > + return 0; > + > + gcspr_el0 = read_sysreg_s(SYS_GCSPR_EL0); > + > + /* > + * GCSPR_EL0 should be pointing at a capped GCS, read the cap... > + */ > + gcsb_dsync(); > + ret = copy_from_user(&cap, (__user void*)gcspr_el0, sizeof(cap)); > + if (ret) > + return -EFAULT; > + > + /* > + * ...then check that the cap is the actual GCS before > + * restoring it. > + */ > + if (!gcs_signal_cap_valid(gcspr_el0, cap)) > + return -EINVAL; > + > + /* Invalidate the token to prevent reuse */ > + put_user_gcs(0, (__user void*)gcspr_el0, &ret); > + if (ret != 0) > + return -EFAULT; You had mentioned that "ideally we'd be doing a compare and exchange here to substitute in a zero". Is a compare and exchange not necessary anymore, or is it just being left for later? In the latter case, a TODO or FIXME comment mentioning it would be useful here. > + > + current->thread.gcspr_el0 = gcspr_el0 + sizeof(cap); > + write_sysreg_s(current->thread.gcspr_el0, SYS_GCSPR_EL0); > + > + return 0; > +} -- Thiago