From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEA0DC433DB for ; Wed, 27 Jan 2021 23:56:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB8C461601 for ; Wed, 27 Jan 2021 23:56:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231145AbhA0X4c (ORCPT ); Wed, 27 Jan 2021 18:56:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231649AbhA0X4N (ORCPT ); Wed, 27 Jan 2021 18:56:13 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBAFCC061573; Wed, 27 Jan 2021 15:55:28 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id E6EB31F44BF5 From: Gabriel Krisman Bertazi To: Yuxuan Shui Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH] ptrace: restore the previous single step reporting behavior In-Reply-To: <877do3gaq9.fsf@m5Zedd9JOGzJrf0> (Yuxuan Shui's message of "Sat, 23 Jan 2021 03:21:32 -0800 (PST)") Organization: Collabora References: <877do3gaq9.fsf@m5Zedd9JOGzJrf0> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Wed, 27 Jan 2021 20:55:20 -0300 Message-ID: <87zh0u540n.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org Yuxuan Shui writes: > Commit 64eb35f701f04b30706e21d1b02636b5d31a37d2 changed when single step > is reported. > > Specifically, the report_single_step is changed so that single steps are > only reported when both SYSCALL_EMU and _TIF_SINGLESTEP are set, while > previously they are reported when _TIF_SINGLESTEP is set without > _TIF_SYSCALL_EMU being set. > > This behavior change breaks rr [1] > > This commit restores the old behavior. > > [1]: https://github.com/rr-debugger/rr/issues/2793 > > Signed-off-by: Yuxuan Shui Looks correct to me. To gather the right attention, you should directly CC the correct maintainers. Fixes: 64eb35f701f0 ("ptrace: Migrate TIF_SYSCALL_EMU to use SYSCALL_WORK flag") Reviewed-by: Gabriel Krisman Bertazi -- Gabriel Krisman Bertazi