From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [patch 08/34] arm: Use generic idle loop Date: Fri, 22 Mar 2013 14:24:53 -0700 Message-ID: <87zjxv9lga.fsf@linaro.org> References: <20130321214930.752934102@linutronix.de> <20130321215233.826238797@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20130321215233.826238797@linutronix.de> (Thomas Gleixner's message of "Thu, 21 Mar 2013 21:53:02 -0000") Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: LKML , linux-arch@vger.kernel.org, Linus Torvalds , Andrew Morton , Rusty Russell , Paul McKenney , Ingo Molnar , Peter Zijlstra , "Srivatsa S. Bhat" , Magnus Damm , Russell King List-Id: linux-arch.vger.kernel.org Hi Thomas, Thomas Gleixner writes: > Use the generic idle loop and replace enable/disable_hlt with the > respective core functions. > > Signed-off-by: Thomas Gleixner > Cc: Russell King I gave patches 1-5 + this a quick spin on ARM (specifially some OMAP3 and OMAP4 platforms, with and without CPUidle enabled.) The OMAP stuff needed a couple minor compile fixes (below), but otherwise it passes the quick "seems to work" test. So at least for ARM/OMAP: Tested-by: Kevin Hilman Kevin diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c index 23c653a..db37f49 100644 --- a/arch/arm/mach-omap1/pm.c +++ b/arch/arm/mach-omap1/pm.c @@ -43,6 +43,7 @@ #include #include #include +#include #include #include diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 3a6c6b8..2f17f95 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/mach-omap2/omap_hwmod.c @@ -138,6 +138,7 @@ #include #include #include +#include #include From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f49.google.com ([209.85.220.49]:37323 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423310Ab3CVVak (ORCPT ); Fri, 22 Mar 2013 17:30:40 -0400 Received: by mail-pa0-f49.google.com with SMTP id kp6so67853pab.8 for ; Fri, 22 Mar 2013 14:30:39 -0700 (PDT) From: Kevin Hilman Subject: Re: [patch 08/34] arm: Use generic idle loop References: <20130321214930.752934102@linutronix.de> <20130321215233.826238797@linutronix.de> Date: Fri, 22 Mar 2013 14:24:53 -0700 In-Reply-To: <20130321215233.826238797@linutronix.de> (Thomas Gleixner's message of "Thu, 21 Mar 2013 21:53:02 -0000") Message-ID: <87zjxv9lga.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner Cc: LKML , linux-arch@vger.kernel.org, Linus Torvalds , Andrew Morton , Rusty Russell , Paul McKenney , Ingo Molnar , Peter Zijlstra , "Srivatsa S. Bhat" , Magnus Damm , Russell King Message-ID: <20130322212453.grkY1PkD8FvdPOgQhPDkqgnWogGs2fhZeuSYxYT6RYY@z> Hi Thomas, Thomas Gleixner writes: > Use the generic idle loop and replace enable/disable_hlt with the > respective core functions. > > Signed-off-by: Thomas Gleixner > Cc: Russell King I gave patches 1-5 + this a quick spin on ARM (specifially some OMAP3 and OMAP4 platforms, with and without CPUidle enabled.) The OMAP stuff needed a couple minor compile fixes (below), but otherwise it passes the quick "seems to work" test. So at least for ARM/OMAP: Tested-by: Kevin Hilman Kevin diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c index 23c653a..db37f49 100644 --- a/arch/arm/mach-omap1/pm.c +++ b/arch/arm/mach-omap1/pm.c @@ -43,6 +43,7 @@ #include #include #include +#include #include #include diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 3a6c6b8..2f17f95 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/mach-omap2/omap_hwmod.c @@ -138,6 +138,7 @@ #include #include #include +#include #include