From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F5E03EB113 for ; Thu, 9 Jul 2026 11:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783595843; cv=none; b=H4w6kqRHBqRfuQevCr/orZOyQTewv2SMOgQI9/UL+X2UnvVnM28wfSN68P6UaPK2lFhgYrDNCMtVOHI86FuFFLWaQjn9EIgdLNbKlzxZjErcPJeGMUPyKYUmOXMNuW4IlWytaYXeTwR48vK4kR1b/i8XkO6tyS0pqh7sqLhlxqE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783595843; c=relaxed/simple; bh=nrb0ag4EBTliR8HEhFNdNbVVIK/JUBRD2JKlM2G1ar0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sp7+g/Se+Y4+baPcKnmQnasNfAK2+uh78BW/Gnh9++iui5dHbNz+QNsMuu+OAocXjl811MLutDpFeYMmeE9hf9olk/i+8bWGxy/zvHpjZ0CpaeYc/lYHyEzF4YyikbxDPL/4WOAmLYj5y9nzI3y16S/x33zY1cGLsS0pzPmmGKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=L5+SzP63; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gtO1PuCP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="L5+SzP63"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gtO1PuCP" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 669AwuRq1614087 for ; Thu, 9 Jul 2026 11:17:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6mSNoqY3wyokI6LMIu3gKte85FSyTicRshSy0RusydY=; b=L5+SzP63bgPAWhp4 W0cUVg2l9n9I+4k0Akz43rpejx4oS0/IbbWAmLMXE7C9F37E36sY/GsXk3zuJt0e 7WRl8xWn74pDgWLAKB7VqpUweKGfDHpjZadrDE/thxVaWuDjHJ729famrINqKMDx 0upb87A5cv2e3e9cOgTo/VDABpH4Tf/6q96s0WSa2IFCTqdWIxx3GVEJhdklhdir gMzNGoVv54cFMR8lTrj5sNzMMQDcUrBjV8bPTBpznG6YMJOrkgy1v18t2RPVEfx/ 2v3dDdCotvg9oshrPidheW6ip0HZ0YECDQHkCxRsQPUi1HLjdw3FRE6oVFrVR41W qvGWIw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fa418hsxy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 09 Jul 2026 11:17:22 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c1a97644aso12208511cf.2 for ; Thu, 09 Jul 2026 04:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783595841; x=1784200641; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=6mSNoqY3wyokI6LMIu3gKte85FSyTicRshSy0RusydY=; b=gtO1PuCPVSA3pcxofYSwzSptyCP8fplhGA0gMAQmi2dxDkJtaOaut5/NCmYMcZ66yp ANnNK9rb7kxDIPXzoyfVDt947Ta0of89XonsQf2ieDZ9TcHUuSK7ZKUfimsVYxjXJTJO kU43zaFkytMyc1foFpfmHGxGayaY8QZw1+eaUTZKTy4oMk9XSsJBa32zlN6H29CVuyNA rSSfYeAf1jGHIDl5pyypQVfyjMATyRCcOiIdur5rcViEEVLFcOtNuI1/WYo9Ufcvo0Rn vPZTO8rXfaXRIYTdSlFwq71J1495hyT9KjxVzsTQBjzpTY1aK9RZGnpINh1izwamCSLB k9nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783595841; x=1784200641; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6mSNoqY3wyokI6LMIu3gKte85FSyTicRshSy0RusydY=; b=dDopZug+rGXHEOaWjH8M+XR+ISMjTH7JmkWuSand3G3vkDx/uGQAk+0O1OVZMvecPW a/fvkYz+A3IWPAguGVsBvB4ziUdFI+9zdG30gtUL9xj/oocrE1PLRAPkfnIMbsozbVEl kplonwr6XWlqnN3OsaVLl7uxEOFQAwEt1cPhQDmQAX5s7k2+L3gwi8u4ad5MxvgESFb4 iaZmA/4OFgTPGSLt3fLD3LCr6fHVTVap7UhH+yYU2LJmXET+rDAQyfNM1dHvSyk5/ILQ +nSBcgx8iHWoD0ufQZASkfK/Ti1mHIirf3nRZR+SUmX9sw1959AG/NSMNOxX/Z4ZNlu7 hNeA== X-Forwarded-Encrypted: i=1; AHgh+RqPZnVai55HKK+zcy329lpoD700jX7LAJS0Fjh4NQKxydv861pvifQXLVw9xKsJEMpBD49bLs4alE5u@vger.kernel.org X-Gm-Message-State: AOJu0YxAA+5QlG9eS/NdvJX5moKVW3NP7CvGOcTK9/imytomHYPrPA1+ vizx6GsDSXGhMpoqemKaZvgbpFdrhKVeHJp05sMZu1/21q84tyqz9xFbMBKCbPaLulq2TpwNeXO mbh0j46QbTLpw69aP8w/WLhTnDO/QfuoZkD/+uulNJQXddQ2QjqTG06C5OdDoCChU X-Gm-Gg: AfdE7ck6sA9uLm/I8eHoyMLLBY1+XAC456qSN3H1KmKOTyvP5jirET3kZIesCFEi3uu qgmBC5xmlsAPnk2LiYxTXZA+m9mUwUFBkQFkX8T5jqPJtKH/LTjkzaZ5pw1DOVh9Mdi5JvHmva1 7CBC/ZPNhnLnoI7DTjHMghOrwP3wll7UAZpQJxa5qcTkIu3h/qOEKXV51zvWe9kZYihbbWelQjC ELEJWQaJvspdi1KM2dV4F/nB2tREYyL1LZYGaZmCqgh5lH6A3VT9oUa522HCWWXxb4yT7RsQV0i w9EflKPL4Ueik4eW/mrlIUesNDQG+P6T5F/DB+TN+Hx5HWcDQ3BjYNdreX3+h2zU7dBmJPOXg5e 9CsJcTJ285h5zedCRcfuR3Vxxs2nbD7TWQs0zS/gyB8zFrWRS2Du0Q6xVSylz+Q== X-Received: by 2002:a05:622a:c86:b0:51c:7b11:41b2 with SMTP id d75a77b69052e-51c8b51c97cmr72541671cf.78.1783595841160; Thu, 09 Jul 2026 04:17:21 -0700 (PDT) X-Received: by 2002:a05:622a:c86:b0:51c:7b11:41b2 with SMTP id d75a77b69052e-51c8b51c97cmr72541381cf.78.1783595840774; Thu, 09 Jul 2026 04:17:20 -0700 (PDT) Received: from [192.168.69.219] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6cccfdsm54034235e9.1.2026.07.09.04.17.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 04:17:20 -0700 (PDT) Message-ID: <8d15c107-30b1-48df-9e69-a7e8520f4e36@oss.qualcomm.com> Date: Thu, 9 Jul 2026 13:17:17 +0200 Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [patch 07/18] s390/syscall: Use enter_from_user_mode_randomize_stack() Content-Language: en-US To: Jinjie Ruan , Thomas Gleixner , LKML Cc: Peter Zijlstra , Sven Schnelle , linux-s390@vger.kernel.org, Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Kees Cook , Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, x86@kernel.org, Mark Rutland , Andy Lutomirski , Oleg Nesterov , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, =?UTF-8?Q?Michal_Such=C3=A1nek?= , Jonathan Corbet , linux-doc@vger.kernel.org References: <20260707181957.433213175@kernel.org> <20260707190254.030598804@kernel.org> <499eca86-8def-4044-8b69-8f290528e10f@huawei.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <499eca86-8def-4044-8b69-8f290528e10f@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=UI3t2ify c=1 sm=1 tr=0 ts=6a4f8342 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=EUspDBNiAAAA:8 a=LfsA7Cq2GQzuzbZ-N0YA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA5MDEwOCBTYWx0ZWRfX7aHPSvz38Gpd 5I9pp/zfvGGO8Gqt7IfoHLGVQNZi2/0GYfAj7UgibQ1Z2TZTo5Lm42/TaZMwOS1Vi+bJLYIukCu XOaNHHpDyO5q+lBm8R0xpFU4b2Bhng7eXAPvuWtjL+p9H+PPpkYiBGANOf+1CEQFG/+jl2RtLcQ uQWcujIAxNRf7geD5AC0ay0dWG38Ju+MaSAd3P8yS3045U8zEbjR/aPf/XmmuTGPYYMfnfCEIzC lRBKIizApg/MziVVyOKgVdW8V2uZkuT9PhWb5oKFVWPwdFxFkqsnkOnDg8RK8BxcNdV03mXeP4D ViQ6s0uFwxtRnqw4FblmaLzzuWZjhOdnfSUa1485qkY+fF9kMb5tXmuhe3I7a9bLyDZehg2MgY5 YOdaYZj9kkALVe9ARELN2aKgM3N7vBdGLuY6mmIhkuNoGFd1EaBAPh/5/sMD9GKkNb6u/FDv/Y7 P+YTltlTEIS6Dkhui+g== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA5MDEwOCBTYWx0ZWRfX6q4eToiGiQJY Y2dyZqGojMQec1ZfPzvALekeADVDYO7ogkqDeAo1qqrnDLh6pjfO03BQ2LTS+khBFfj0x3WJmHA L3/pWN4wnffm9qHyLY8MEjXWgSfxfiY= X-Proofpoint-GUID: t7pXU2vxkBo8Y0lV_KCVrXivSa49uqIl X-Proofpoint-ORIG-GUID: t7pXU2vxkBo8Y0lV_KCVrXivSa49uqIl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-09_02,2026-07-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607090108 On 9/7/26 04:46, Jinjie Ruan wrote: > > > On 7/8/2026 3:06 AM, Thomas Gleixner wrote: >> enter_from_user_mode_randomize_stack() replaces enter_from_user_mode() and >> the subsequent invocation of add_random_kstack_offset_irqsoff(). >> >> As a bonus this avoids the overhead of get/put_cpu_var() in >> add_random_kstack_offset(). >> >> No functional change. >> >> Signed-off-by: Thomas Gleixner >> Cc: Sven Schnelle >> Cc: linux-s390@vger.kernel.org >> --- >> arch/s390/kernel/syscall.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> --- a/arch/s390/kernel/syscall.c >> +++ b/arch/s390/kernel/syscall.c >> @@ -97,8 +97,8 @@ void noinstr __do_syscall(struct pt_regs >> { >> unsigned long nr; >> >> - enter_from_user_mode(regs); >> - add_random_kstack_offset(); >> + enter_from_user_mode_randomize_stack(regs); > > The #include can be removed. Reviewed-by: Philippe Mathieu-Daudé