From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu-cheng Yu Subject: Re: [PATCH v8 02/27] x86/cpufeatures: Add CET CPU feature flags for Control-flow Enforcement Technology (CET) Date: Wed, 21 Aug 2019 07:46:32 -0700 Message-ID: <8d2e5bc4496075032393ff9ae81a26f7fbc711e6.camel@intel.com> References: <20190813205225.12032-1-yu-cheng.yu@intel.com> <20190813205225.12032-3-yu-cheng.yu@intel.com> <20190821102052.GD6752@zn.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190821102052.GD6752@zn.tnic> Sender: linux-kernel-owner@vger.kernel.org To: Borislav Petkov Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pa List-Id: linux-arch.vger.kernel.org On Wed, 2019-08-21 at 12:20 +0200, Borislav Petkov wrote: > On Tue, Aug 13, 2019 at 01:52:00PM -0700, Yu-cheng Yu wrote: > > Add CPU feature flags for Control-flow Enforcement Technology (CET). > > > > [...] > > diff --git a/arch/x86/kernel/cpu/cpuid-deps.c b/arch/x86/kernel/cpu/cpuid- > > deps.c > > index b5353244749b..9bf35f081080 100644 > > --- a/arch/x86/kernel/cpu/cpuid-deps.c > > +++ b/arch/x86/kernel/cpu/cpuid-deps.c > > @@ -68,6 +68,8 @@ static const struct cpuid_dep cpuid_deps[] = { > > { X86_FEATURE_CQM_MBM_TOTAL, X86_FEATURE_CQM_LLC }, > > { X86_FEATURE_CQM_MBM_LOCAL, X86_FEATURE_CQM_LLC }, > > { X86_FEATURE_AVX512_BF16, X86_FEATURE_AVX512VL }, > > + { X86_FEATURE_SHSTK, X86_FEATURE_XSAVES }, > > + { X86_FEATURE_IBT, X86_FEATURE_XSAVES }, > > This hunk needs re-tabbing after: > > 1e0c08e3034d ("cpu/cpuid-deps: Add a tab to cpuid dependent features") Thanks, I will fix it. Yu-cheng From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:41312 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727286AbfHUOzk (ORCPT ); Wed, 21 Aug 2019 10:55:40 -0400 Message-ID: <8d2e5bc4496075032393ff9ae81a26f7fbc711e6.camel@intel.com> Subject: Re: [PATCH v8 02/27] x86/cpufeatures: Add CET CPU feature flags for Control-flow Enforcement Technology (CET) From: Yu-cheng Yu Date: Wed, 21 Aug 2019 07:46:32 -0700 In-Reply-To: <20190821102052.GD6752@zn.tnic> References: <20190813205225.12032-1-yu-cheng.yu@intel.com> <20190813205225.12032-3-yu-cheng.yu@intel.com> <20190821102052.GD6752@zn.tnic> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Borislav Petkov Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin Message-ID: <20190821144632.XbIq3uyyBBpzdyXO5cY3xclObYbGIJIsTtUGBlPJnuo@z> On Wed, 2019-08-21 at 12:20 +0200, Borislav Petkov wrote: > On Tue, Aug 13, 2019 at 01:52:00PM -0700, Yu-cheng Yu wrote: > > Add CPU feature flags for Control-flow Enforcement Technology (CET). > > > > [...] > > diff --git a/arch/x86/kernel/cpu/cpuid-deps.c b/arch/x86/kernel/cpu/cpuid- > > deps.c > > index b5353244749b..9bf35f081080 100644 > > --- a/arch/x86/kernel/cpu/cpuid-deps.c > > +++ b/arch/x86/kernel/cpu/cpuid-deps.c > > @@ -68,6 +68,8 @@ static const struct cpuid_dep cpuid_deps[] = { > > { X86_FEATURE_CQM_MBM_TOTAL, X86_FEATURE_CQM_LLC }, > > { X86_FEATURE_CQM_MBM_LOCAL, X86_FEATURE_CQM_LLC }, > > { X86_FEATURE_AVX512_BF16, X86_FEATURE_AVX512VL }, > > + { X86_FEATURE_SHSTK, X86_FEATURE_XSAVES }, > > + { X86_FEATURE_IBT, X86_FEATURE_XSAVES }, > > This hunk needs re-tabbing after: > > 1e0c08e3034d ("cpu/cpuid-deps: Add a tab to cpuid dependent features") Thanks, I will fix it. Yu-cheng