From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH] UAPI: Remove empty Kbuild files Date: Tue, 26 Mar 2013 23:32:40 +0000 Message-ID: <902.1364340760@warthog.procyon.org.uk> References: <51522F62.4030108@suse.cz> <51521769.7010707@suse.cz> <20130326140520.3100447ee78322d52e6be7af@linux-foundation.org> <20130326131828.209aff73e38d3273d078bb2e@linux-foundation.org> <20130326174853.10144.36253.stgit@warthog.procyon.org.uk> <29647.1364331583@warthog.procyon.org.uk> <30061.1364333234@warthog.procyon.org.uk> <32381.1364338459@warthog.procyon.org.uk> Return-path: In-Reply-To: <51522F62.4030108@suse.cz> Sender: linux-kernel-owner@vger.kernel.org To: Michal Marek Cc: dhowells@redhat.com, Andrew Morton , torvalds@linux-foundation.org, arnd@arndb.de, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arch.vger.kernel.org Michal Marek wrote: > >>> I want to know whether I should extend my patch to remove include/Kbuild > >>> and any refs to it. > >> > >> make headers_install starts at include/uapi, so include/Kbuild is not > >> needed. And new exported headers end up in inclde/uapi, so there will > >> probably not be need for include/Kbuild in the future either. IMO, just > >> remove it. > > > > That's not all Kbuild does. It also handles autogenerated headers. > > That's true. But include/generated is handled by the main Makefile > directly as well. But there are generated header files that aren't so handled - though those are only currently to be found in arch/. I don't mind removing it, it's just that I don't want to preclude anyone's use of it. David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:13341 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753461Ab3CZXd3 (ORCPT ); Tue, 26 Mar 2013 19:33:29 -0400 From: David Howells In-Reply-To: <51522F62.4030108@suse.cz> References: <51522F62.4030108@suse.cz> <51521769.7010707@suse.cz> <20130326140520.3100447ee78322d52e6be7af@linux-foundation.org> <20130326131828.209aff73e38d3273d078bb2e@linux-foundation.org> <20130326174853.10144.36253.stgit@warthog.procyon.org.uk> <29647.1364331583@warthog.procyon.org.uk> <30061.1364333234@warthog.procyon.org.uk> <32381.1364338459@warthog.procyon.org.uk> Subject: Re: [PATCH] UAPI: Remove empty Kbuild files Date: Tue, 26 Mar 2013 23:32:40 +0000 Message-ID: <902.1364340760@warthog.procyon.org.uk> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Michal Marek Cc: dhowells@redhat.com, Andrew Morton , torvalds@linux-foundation.org, arnd@arndb.de, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20130326233240.I7IMIhxknPj-xK3hAUEJNyFO_2fdw4jP-MIbqoMZ4TE@z> Michal Marek wrote: > >>> I want to know whether I should extend my patch to remove include/Kbuild > >>> and any refs to it. > >> > >> make headers_install starts at include/uapi, so include/Kbuild is not > >> needed. And new exported headers end up in inclde/uapi, so there will > >> probably not be need for include/Kbuild in the future either. IMO, just > >> remove it. > > > > That's not all Kbuild does. It also handles autogenerated headers. > > That's true. But include/generated is handled by the main Makefile > directly as well. But there are generated header files that aren't so handled - though those are only currently to be found in arch/. I don't mind removing it, it's just that I don't want to preclude anyone's use of it. David