Re: [PATCH v5 05/10] serial: termbits: ADDRB to indicate 9th bit addressing mode

Greg KH
2022-04-26T12:52:23Z

On Tue, Apr 26, 2022 at 03:24:43PM +0300, Ilpo Järvinen wrote:
> Add ADDRB to termbits to indicate 9th bit addressing mode. This change
> is necessary for supporting devices with RS485 multipoint addressing
> [*]. A later patch in the patch series adds support for Synopsys
> Designware UART capable for 9th bit addressing mode. In this mode, 9th
> bit is used to indicate an address (byte) within the communication
> line. The 9th bit addressing mode is selected using ADDRB introduced by
> an earlier patch.
>
> [*] Technically, RS485 is just an electronic spec and does not itself
> specify the 9th bit addressing mode but 9th bit seems at least
> "semi-standard" way to do addressing with RS485.
>
> Cc: linux-api@vger.kernel.org
> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> Cc: Matt Turner <mattst88@gmail.com>
> Cc: linux-alpha@vger.kernel.org
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-parisc@vger.kernel.org
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-arch@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> arch/alpha/include/uapi/asm/termbits.h | 1 +
> arch/mips/include/uapi/asm/termbits.h | 1 +
> arch/parisc/include/uapi/asm/termbits.h | 1 +
> arch/powerpc/include/uapi/asm/termbits.h | 1 +
> arch/sparc/include/uapi/asm/termbits.h | 1 +
> drivers/char/pcmcia/synclink_cs.c | 2 ++
> drivers/ipack/devices/ipoctal.c | 2 ++
> drivers/mmc/core/sdio_uart.c | 2 ++
> drivers/net/usb/hso.c | 3 ++-
> drivers/s390/char/tty3270.c | 3 +++
> drivers/staging/greybus/uart.c | 2 ++
> drivers/tty/amiserial.c | 6 +++++-
> drivers/tty/moxa.c | 1 +
> drivers/tty/mxser.c | 1 +
> drivers/tty/serial/serial_core.c | 2 ++
> drivers/tty/synclink_gt.c | 2 ++
> drivers/tty/tty_ioctl.c | 2 ++
> drivers/usb/class/cdc-acm.c | 2 ++
> drivers/usb/serial/usb-serial.c | 6 ++++--
> include/uapi/asm-generic/termbits.h | 1 +
> net/bluetooth/rfcomm/tty.c | 2 ++
> 21 files changed, 40 insertions(+), 4 deletions(-)
>
> diff --git a/arch/alpha/include/uapi/asm/termbits.h b/arch/alpha/include/uapi/asm/termbits.h
> index 4575ba34a0ea..0c123e715486 100644
> --- a/arch/alpha/include/uapi/asm/termbits.h
> +++ b/arch/alpha/include/uapi/asm/termbits.h
> @@ -180,6 +180,7 @@ struct ktermios {
> #define HUPCL 00040000
>
> #define CLOCAL 00100000
> +#define ADDRB 004000000000 /* address bit */
> #define CMSPAR 010000000000 /* mark or space (stick) parity */
> #define CRTSCTS 020000000000 /* flow control */
>
> diff --git a/arch/mips/include/uapi/asm/termbits.h b/arch/mips/include/uapi/asm/termbits.h
> index dfeffba729b7..4732d31b0e4e 100644
> --- a/arch/mips/include/uapi/asm/termbits.h
> +++ b/arch/mips/include/uapi/asm/termbits.h
> @@ -182,6 +182,7 @@ struct ktermios {
> #define B3500000 0010016
> #define B4000000 0010017
> #define CIBAUD 002003600000 /* input baud rate */
> +#define ADDRB 004000000000 /* address bit */
> #define CMSPAR 010000000000 /* mark or space (stick) parity */
> #define CRTSCTS 020000000000 /* flow control */
>
> diff --git a/arch/parisc/include/uapi/asm/termbits.h b/arch/parisc/include/uapi/asm/termbits.h
> index 40e920f8d683..d6bbd10d92ba 100644
> --- a/arch/parisc/include/uapi/asm/termbits.h
> +++ b/arch/parisc/include/uapi/asm/termbits.h
> @@ -159,6 +159,7 @@ struct ktermios {
> #define B3500000 0010016
> #define B4000000 0010017
> #define CIBAUD 002003600000 /* input baud rate */
> +#define ADDRB 004000000000 /* address bit */

tabs where the rest were not?

> #define CMSPAR 010000000000 /* mark or space (stick) parity */
> #define CRTSCTS 020000000000 /* flow control */
>
> diff --git a/arch/powerpc/include/uapi/asm/termbits.h b/arch/powerpc/include/uapi/asm/termbits.h
> index ed18bc61f63d..c6a033732f39 100644
> --- a/arch/powerpc/include/uapi/asm/termbits.h
> +++ b/arch/powerpc/include/uapi/asm/termbits.h
> @@ -171,6 +171,7 @@ struct ktermios {
> #define HUPCL 00040000
>
> #define CLOCAL 00100000
> +#define ADDRB 004000000000 /* address bit */
> #define CMSPAR 010000000000 /* mark or space (stick) parity */
> #define CRTSCTS 020000000000 /* flow control */
>
> diff --git a/arch/sparc/include/uapi/asm/termbits.h b/arch/sparc/include/uapi/asm/termbits.h
> index ce5ad5d0f105..5eb1d547b5c4 100644
> --- a/arch/sparc/include/uapi/asm/termbits.h
> +++ b/arch/sparc/include/uapi/asm/termbits.h
> @@ -201,6 +201,7 @@ struct ktermios {
> #define B3500000 0x00001012
> #define B4000000 0x00001013 */
> #define CIBAUD 0x100f0000 /* input baud rate (not used) */
> +#define ADDRB 0x20000000 /* address bit */
> #define CMSPAR 0x40000000 /* mark or space (stick) parity */
> #define CRTSCTS 0x80000000 /* flow control */

Why all the different values? Can't we pick one and use it for all
arches? Having these be different in different arches and userspace
should not be a thing for new fields, right?

> diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
> index 78baba55a8b5..d179b9b57a25 100644
> --- a/drivers/char/pcmcia/synclink_cs.c
> +++ b/drivers/char/pcmcia/synclink_cs.c
> @@ -2287,6 +2287,8 @@ static void mgslpc_set_termios(struct tty_struct *tty, struct ktermios *old_term
> == RELEVANT_IFLAG(old_termios->c_iflag)))
> return;
>
> + tty->termios.c_cflag &= ~ADDRB;

Having to do this for all drivers feels wrong. It isn't needed for any
other flag, right? That makes me really not like this change as it
feels very ackward and
yet-another-thing-a-serial-driver-has-to-remember.

And as you are wanting to pass this bit to userspace, where is that
documented?

thanks,

greg k-h