Re: [PATCH v5 05/10] serial: termbits: ADDRB to indicate 9th bit addressing mode

Ilpo Järvinen
2022-04-26T16:37:08Z

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

On Tue, 26 Apr 2022, Greg KH wrote:

> On Tue, Apr 26, 2022 at 05:01:31PM +0300, Ilpo Järvinen wrote:
> >
> > ADDRB value is the same for all archs (it's just this octal vs hex
> > notation I've followed as per the nearby defines within the same file
> > which makes them look different).
> >
> > Should I perhaps add to my cleanup list conversion of all those octal ones
> > to hex?
>
> Argh, yes, please, let's do that now, I totally missed that. Will let
> us see how to unify them as well.

Unifying them might turn out impractical, here's a rough idea now many
copies ... | uniq -c finds for the defines (based on more aggressively
cleaned up lines than the patch will have):
89 1
74 2
14 3
58 4
11 5
54 6
There just tends to be 1 or 2 archs which are different from the others.

...I'll send the actual octal-to-hex patch once the arch builds complete.

--
i.