From: Akira Yokosawa <akiyks@gmail.com>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
"Paul E. McKenney" <paulmck@kernel.org>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Andrea Parri <parri.andrea@gmail.com>,
Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Boqun Feng <boqun.feng@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
David Howells <dhowells@redhat.com>,
Jade Alglave <j.alglave@ucl.ac.uk>,
Luc Maranget <luc.maranget@inria.fr>,
Daniel Lustig <dlustig@nvidia.com>,
Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH] tools: memory-model: Rename litmus test to avoid confusion with similar-named test
Date: Mon, 10 Apr 2023 10:31:50 +0900 [thread overview]
Message-ID: <9c21f8ec-4f1d-9658-bf5b-682be16d9321@gmail.com> (raw)
In-Reply-To: <20230409044823.775760-1-joel@joelfernandes.org>
Hi Joel,
On Sun, 9 Apr 2023 04:48:22 +0000, Joel Fernandes (Google) wrote:
> In order to differentiate the test
> Z6.0+pooncelock+poonceLock+pombonce.litmus from another test that only
> differs by a capital L, the following file has been renamed:
>
> renamed: litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus ->
> litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus
>
> This change should help avoid confusion between the two tests.
>
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> ---
> ...mbonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename tools/memory-model/litmus-tests/{Z6.0+pooncelock+poonceLock+pombonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} (100%)
>
> diff --git a/tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus b/tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus
> similarity index 100%
> rename from tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus
> rename to tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus
I must say simply changing the file name is only part of the job.
You need to update comments/docs as well.
There are 4 hits after this patch is applied:
$ find . -type f -exec grep -nH --null -F -e Z6.0+pooncelock+poonceLock \{\} +
./tools/memory-model/Documentation/locking.txt187: /* See Z6.0+pooncelock+poonceLock+pombonce.litmus. */
./tools/memory-model/Documentation/recipes.txt162: /* See Z6.0+pooncelock+poonceLock+pombonce.litmus. */
./tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus1:C Z6.0+pooncelock+poonceLock+pombonce
./tools/memory-model/litmus-tests/README152:Z6.0+pooncelock+poonceLock+pombonce.litmus
Thanks, Akira
prev parent reply other threads:[~2023-04-10 1:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-09 4:48 [PATCH] tools: memory-model: Rename litmus test to avoid confusion with similar-named test Joel Fernandes (Google)
2023-04-10 1:31 ` Akira Yokosawa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c21f8ec-4f1d-9658-bf5b-682be16d9321@gmail.com \
--to=akiyks@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).