From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions Date: Tue, 22 Feb 2011 12:47:09 -0800 Message-ID: References: <20110217.140119.39175251.davem@davemloft.net> <20110217221957.GA11244@dtor-ws.eng.vmware.com> <20110217.142320.102554706.davem@davemloft.net> <1298074455.2460.85.camel@pasglop> <87pqqmrq9q.fsf@rustcorp.com.au> <1298339909.8833.135.camel@pasglop> <20110222070240.GA21765@dtor-ws.eng.vmware.com> <20110222170849.GW13204@axis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <20110222170849.GW13204@axis.com> Sender: linux-m68k-owner@vger.kernel.org To: Jesper Nilsson Cc: Dmitry Torokhov , Benjamin Herrenschmidt , Rusty Russell , David Miller , "linux-kernel@vger.kernel.org" , "geert@linux-m68k.org" , "linux-m68k@vger.kernel.org" , "linux-arch@vger.kernel.org" , Mikael Starvik List-Id: linux-arch.vger.kernel.org On Tue, Feb 22, 2011 at 9:08 AM, Jesper Nilsson wrote: > > That's probably just a legacy from when I combined the linkscripts > for the two architectures. If I remember correctly, RODATA brings > in RO_DATA_SECTION which in turn brings in __param and __modver > for both architectures. CRISv32 then duplicates the __param stuff > for some historical reason. Hmm. This makes it sound like the patch should be to remove the __param thing rather than to add the _modver thing. And I can definitely confirm that cris seems to use RODATA, which brings in the RO_DATA_SECTION() thing with proper page alignment. But: > True, at least until I've made sure that there isn't any > underlying reason for CRISv32 to put __param in a different place... > > Acked-by: Jesper Nilsson I really am not going to apply a patch that likely just adds another redundant field to the linker scripts. So the ack I'm just ignoring, But it would be good to get the "remove the legacy __param thing because it's already there from the asm-generic version" confirmed by testing, and not just looking at the source code. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:42406 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890Ab1BVUxf (ORCPT ); Tue, 22 Feb 2011 15:53:35 -0500 MIME-Version: 1.0 In-Reply-To: <20110222170849.GW13204@axis.com> References: <20110217.140119.39175251.davem@davemloft.net> <20110217221957.GA11244@dtor-ws.eng.vmware.com> <20110217.142320.102554706.davem@davemloft.net> <1298074455.2460.85.camel@pasglop> <87pqqmrq9q.fsf@rustcorp.com.au> <1298339909.8833.135.camel@pasglop> <20110222070240.GA21765@dtor-ws.eng.vmware.com> <20110222170849.GW13204@axis.com> From: Linus Torvalds Date: Tue, 22 Feb 2011 12:47:09 -0800 Message-ID: Subject: Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Jesper Nilsson Cc: Dmitry Torokhov , Benjamin Herrenschmidt , Rusty Russell , David Miller , "linux-kernel@vger.kernel.org" , "geert@linux-m68k.org" , "linux-m68k@vger.kernel.org" , "linux-arch@vger.kernel.org" , Mikael Starvik Message-ID: <20110222204709.btvFIJ6dT8XcSmoS7XdDppmbuOl6I00eexwvfS196KA@z> On Tue, Feb 22, 2011 at 9:08 AM, Jesper Nilsson wrote: > > That's probably just a legacy from when I combined the linkscripts > for the two architectures. If I remember correctly, RODATA brings > in RO_DATA_SECTION which in turn brings in __param and __modver > for both architectures. CRISv32 then duplicates the __param stuff > for some historical reason. Hmm. This makes it sound like the patch should be to remove the __param thing rather than to add the _modver thing. And I can definitely confirm that cris seems to use RODATA, which brings in the RO_DATA_SECTION() thing with proper page alignment. But: > True, at least until I've made sure that there isn't any > underlying reason for CRISv32 to put __param in a different place... > > Acked-by: Jesper Nilsson I really am not going to apply a patch that likely just adds another redundant field to the linker scripts. So the ack I'm just ignoring, But it would be good to get the "remove the legacy __param thing because it's already there from the asm-generic version" confirmed by testing, and not just looking at the source code. Linus