* [PATCH 1/2] fcntl.h comment: FD_CLOEXEC is for F_[GET|SET]FD
@ 2010-07-15 17:29 Ted Percival
2010-07-15 17:29 ` [PATCH 2/2] fcntl.h comment: Fix typo regarding O_SYNC Ted Percival
2010-07-16 10:00 ` David Howells
0 siblings, 2 replies; 5+ messages in thread
From: Ted Percival @ 2010-07-15 17:29 UTC (permalink / raw)
To: linux-arch; +Cc: Ted Percival
Not for F_[GET|SET]FL
Signed-off-by: Ted Percival <ted@tedp.id.au>
---
include/asm-generic/fcntl.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/asm-generic/fcntl.h b/include/asm-generic/fcntl.h
index 4d3e483..65e18d3 100644
--- a/include/asm-generic/fcntl.h
+++ b/include/asm-generic/fcntl.h
@@ -74,7 +74,7 @@
#define F_GETSIG 11 /* for sockets. */
#endif
-/* for F_[GET|SET]FL */
+/* for F_[GET|SET]FD */
#define FD_CLOEXEC 1 /* actually anything with low bit set goes */
/* for posix fcntl() and lockf() */
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] fcntl.h comment: Fix typo regarding O_SYNC
2010-07-15 17:29 [PATCH 1/2] fcntl.h comment: FD_CLOEXEC is for F_[GET|SET]FD Ted Percival
@ 2010-07-15 17:29 ` Ted Percival
2010-07-16 10:00 ` David Howells
1 sibling, 0 replies; 5+ messages in thread
From: Ted Percival @ 2010-07-15 17:29 UTC (permalink / raw)
To: linux-arch; +Cc: Ted Percival
Signed-off-by: Ted Percival <ted@tedp.id.au>
---
include/asm-generic/fcntl.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/asm-generic/fcntl.h b/include/asm-generic/fcntl.h
index 65e18d3..d6e84ba 100644
--- a/include/asm-generic/fcntl.h
+++ b/include/asm-generic/fcntl.h
@@ -3,7 +3,7 @@
#include <linux/types.h>
-/* open/fcntl - O_SYNC is only implemented on blocks devices and on files
+/* open/fcntl - O_SYNC is only implemented on block devices and on files
located on an ext2 file system */
#define O_ACCMODE 00000003
#define O_RDONLY 00000000
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] fcntl.h comment: Fix typo regarding O_SYNC
2010-07-15 17:29 [PATCH 1/2] fcntl.h comment: FD_CLOEXEC is for F_[GET|SET]FD Ted Percival
2010-07-15 17:29 ` [PATCH 2/2] fcntl.h comment: Fix typo regarding O_SYNC Ted Percival
@ 2010-07-16 10:00 ` David Howells
2010-07-16 11:56 ` Jamie Lokier
1 sibling, 1 reply; 5+ messages in thread
From: David Howells @ 2010-07-16 10:00 UTC (permalink / raw)
To: Ted Percival; +Cc: dhowells, linux-arch, Ted Percival
Ted Percival <ted@midg3t.net> wrote:
> +/* open/fcntl - O_SYNC is only implemented on block devices and on files
> located on an ext2 file system */
Is this comment still true about the fact that, with respect to files, this is
only implemented on ext2?
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] fcntl.h comment: Fix typo regarding O_SYNC
2010-07-16 10:00 ` David Howells
@ 2010-07-16 11:56 ` Jamie Lokier
2010-07-16 20:51 ` Ted Percival
0 siblings, 1 reply; 5+ messages in thread
From: Jamie Lokier @ 2010-07-16 11:56 UTC (permalink / raw)
To: David Howells; +Cc: Ted Percival, linux-arch, Ted Percival
David Howells wrote:
>
> Ted Percival <ted@midg3t.net> wrote:
>
> > +/* open/fcntl - O_SYNC is only implemented on block devices and on files
> > located on an ext2 file system */
>
> Is this comment still true about the fact that, with respect to files, this is
> only implemented on ext2?
No, it isn't.
-- Jamie
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] fcntl.h comment: Fix typo regarding O_SYNC
2010-07-16 11:56 ` Jamie Lokier
@ 2010-07-16 20:51 ` Ted Percival
0 siblings, 0 replies; 5+ messages in thread
From: Ted Percival @ 2010-07-16 20:51 UTC (permalink / raw)
To: Jamie Lokier; +Cc: David Howells, linux-arch
Jamie Lokier <jamie@shareable.org> wrote:
> David Howells wrote:
>>
>> Ted Percival <ted@midg3t.net> wrote:
>>
>> > +/* open/fcntl - O_SYNC is only implemented on block devices and on files
>> > located on an ext2 file system */
>>
>> Is this comment still true about the fact that, with respect to files, this is
>> only implemented on ext2?
>
> No, it isn't.
Christoph Hellwig has since removed that comment (commit 6b2f3d1f,
"vfs: Implement proper O_SYNC semantics") so this patch (2/2) can be
ignored.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-07-16 20:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-15 17:29 [PATCH 1/2] fcntl.h comment: FD_CLOEXEC is for F_[GET|SET]FD Ted Percival
2010-07-15 17:29 ` [PATCH 2/2] fcntl.h comment: Fix typo regarding O_SYNC Ted Percival
2010-07-16 10:00 ` David Howells
2010-07-16 11:56 ` Jamie Lokier
2010-07-16 20:51 ` Ted Percival
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).