From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 02/17] mm: mmu_gather rework Date: Wed, 16 Mar 2011 21:15:58 +0100 Message-ID: References: <20110217162327.434629380@chello.nl> <20110217163234.823185666@chello.nl> <20110310155032.GB32302@csn.ul.ie> <1300301742.2203.1899.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1300301742.2203.1899.camel@twins> Sender: owner-linux-mm@kvack.org To: Peter Zijlstra Cc: Mel Gorman , Andrea Arcangeli , Avi Kivity , Thomas Gleixner , Rik van Riel , Ingo Molnar , akpm@linux-foundation.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Benjamin Herrenschmidt , David Miller , Hugh Dickins , Nick Piggin , Paul McKenney , Yanmin Zhang , Martin Schwidefsky , Russell King , Paul Mundt , Jeff Dike , Tony Luck , Hugh Dickins List-Id: linux-arch.vger.kernel.org On Wed, Mar 16, 2011 at 19:55, Peter Zijlstra wrot= e: > On Thu, 2011-03-10 at 15:50 +0000, Mel Gorman wrote: > >> > +static inline void >> > +tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm, unsigned= int full_mm_flush) >> > =C2=A0{ >> >> checkpatch will bitch about line length. > > I did a s/full_mm_flush/fullmm/ which puts the line length at 81. At > which point I'll ignore it ;-) But what does "fullmm" mean here? Shouldn't that be documented. BTW, the function no longer returns a struct, but void, so the documentatio= n should be updated for sure. Gr{oetje,eeting}s, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 -- Linus Torvalds -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:45499 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753971Ab1CPUQr convert rfc822-to-8bit (ORCPT ); Wed, 16 Mar 2011 16:16:47 -0400 MIME-Version: 1.0 In-Reply-To: <1300301742.2203.1899.camel@twins> References: <20110217162327.434629380@chello.nl> <20110217163234.823185666@chello.nl> <20110310155032.GB32302@csn.ul.ie> <1300301742.2203.1899.camel@twins> Date: Wed, 16 Mar 2011 21:15:58 +0100 Message-ID: Subject: Re: [PATCH 02/17] mm: mmu_gather rework From: Geert Uytterhoeven Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Mel Gorman , Andrea Arcangeli , Avi Kivity , Thomas Gleixner , Rik van Riel , Ingo Molnar , akpm@linux-foundation.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Benjamin Herrenschmidt , David Miller , Hugh Dickins , Nick Piggin , Paul McKenney , Yanmin Zhang , Martin Schwidefsky , Russell King , Paul Mundt , Jeff Dike , Tony Luck , Hugh Dickins Message-ID: <20110316201558.WgetqQcin5RViMa7ebbOF2uEnUn1BTMCQoTlffd4i0c@z> On Wed, Mar 16, 2011 at 19:55, Peter Zijlstra wrote: > On Thu, 2011-03-10 at 15:50 +0000, Mel Gorman wrote: > >> > +static inline void >> > +tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm, unsigned int full_mm_flush) >> >  { >> >> checkpatch will bitch about line length. > > I did a s/full_mm_flush/fullmm/ which puts the line length at 81. At > which point I'll ignore it ;-) But what does "fullmm" mean here? Shouldn't that be documented. BTW, the function no longer returns a struct, but void, so the documentation should be updated for sure. Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds