Re: [PATCH 4/7] ARM: oprofile: Move non-ARM code into separate init/exit

[Grant Likely <grant.likely@secretlab.ca>]

On Wed, Oct 6, 2010 at 12:44 PM, Robert Richter <robert.richter@amd.com> wrote:
> On 06.10.10 14:23:17, Grant Likely wrote:
>> >> diff --git a/drivers/oprofile/oprof.c b/drivers/oprofile/oprof.c
>> >> index b336cd9..76d97a5 100644
>> >> --- a/drivers/oprofile/oprof.c
>> >> +++ b/drivers/oprofile/oprof.c
>> >> @@ -252,6 +252,8 @@ static int __init oprofile_init(void)
>> >>  {
>> >>       int err;
>> >>
>> >> +     memset(&oprofile_ops, 0, sizeof(struct oprofile_operations));
>> >> +
>> >
>> > Yes, this looks much better. Thanks Paul.
>>
>> oprofile_ops is allocated in bss and so is already zeroed.  No need to
>> do it explicitly.
>
> Before oprofile_arch_init() it isn't necessarily needed, but we should
> definitely add it before oprofile_timer_init(). For code readability I
> would rather tend to let the first in too.

?  Sorry, I don't understand what you're trying to say.  Because
oprofile_ops is statically allocated in bss; it will be zeroed before
*any* of the init hooks is called.

g.

>
> -Robert
>
> --
> Advanced Micro Devices, Inc.
> Operating System Research Center
>
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.