From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akinobu Mita Subject: Re: [PATCH v4 00/24] Introduce little endian bitops Date: Mon, 17 Jan 2011 11:37:19 +0900 Message-ID: References: <1295183333-13802-1-git-send-email-akinobu.mita@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-qy0-f181.google.com ([209.85.216.181]:56901 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515Ab1AQChU (ORCPT ); Sun, 16 Jan 2011 21:37:20 -0500 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, akpm@linux-foundation.org, Russell King , Arnd Bergmann 2011/1/17 Linus Torvalds : > On Sun, Jan 16, 2011 at 5:08 AM, Akinobu Mita wrote: >> >> This problem is not touched. > > So why not? The thing is supposed to be a cleanup, but it generates > uglier code and more lines added than removed. Why should I pull > something like that? Changing *_bit_le() to take "void *" instead of "unsigned long *" makes this patch series acceptable? Or do we also need to change *_bit_le() to handle unaligned address correctly? (i.e. not only long aligned address but also byte aligned address)