From: Tony Luck <tony.luck@intel.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org
Subject: Re: ia64 broken by transparent huge pages - other arches too?
Date: Fri, 14 Jan 2011 10:50:26 -0800 [thread overview]
Message-ID: <AANLkTinpg9pWWas8+UngC=sRruxM6KASDPZtE6MmV=xp@mail.gmail.com> (raw)
In-Reply-To: <20110114183058.GN9506@random.random>
On Fri, Jan 14, 2011 at 10:30 AM, Andrea Arcangeli <aarcange@redhat.com> wrote:
> Would you be willing to implement __pmd for ia64 to fix this? Can you
> check if this works?
>
> Thanks a lot,
> Andrea
>
> ========
> Subject: fix ia64 build failure in pmdp_get_and_clear
>
> From: Andrea Arcangeli <aarcange@redhat.com>
>
> Implement __pmd macro for ia64 too.
>
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
> ---
>
> diff --git a/arch/ia64/include/asm/page.h b/arch/ia64/include/asm/page.h
> index 41b6d31..961a16f 100644
> --- a/arch/ia64/include/asm/page.h
> +++ b/arch/ia64/include/asm/page.h
> @@ -189,6 +189,7 @@ get_order (unsigned long size)
> # define pgprot_val(x) ((x).pgprot)
>
> # define __pte(x) ((pte_t) { (x) } )
> +# define __pmd(x) ((pmd_t) { (x) } )
> # define __pgprot(x) ((pgprot_t) { (x) } )
>
> #else /* !STRICT_MM_TYPECHECKS */
Yes that works. Thanks. I'll apply to my ia64 tree and ask Linus to pull it.
-Tony
next prev parent reply other threads:[~2011-01-14 18:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 17:50 ia64 broken by transparent huge pages - other arches too? Luck, Tony
2011-01-14 17:50 ` Luck, Tony
2011-01-14 18:30 ` Andrea Arcangeli
2011-01-14 18:50 ` Tony Luck [this message]
2011-01-14 19:03 ` Andrea Arcangeli
2011-01-15 7:21 ` Benjamin Herrenschmidt
2011-01-15 15:59 ` Andrea Arcangeli
2011-01-15 16:47 ` James Bottomley
2011-01-15 17:23 ` Andrea Arcangeli
2011-01-15 19:02 ` Geert Uytterhoeven
2011-01-15 21:31 ` Benjamin Herrenschmidt
2011-01-16 21:05 ` Linus Torvalds
2011-01-16 21:10 ` Andrew Morton
2011-01-16 22:06 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinpg9pWWas8+UngC=sRruxM6KASDPZtE6MmV=xp@mail.gmail.com' \
--to=tony.luck@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).