From mboxrd@z Thu Jan 1 00:00:00 1970 From: richard -rw- weinberger Subject: Re: [PATCH] lib: Consolidate DEBUG_STACK_USAGE option Date: Sat, 7 May 2011 11:34:13 +0200 Message-ID: References: <1304747831-2098-1-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1304747831-2098-1-git-send-email-sboyd@codeaurora.org> Sender: sparclinux-owner@vger.kernel.org To: Stephen Boyd Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, uclinux-dist-devel@blackfin.uclinux.org, linux-m32r@ml.linux-m32r.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, Chris Metcalf , user-mode-linux-devel@lists.sourceforge.net, x86@kernel.org List-Id: linux-arch.vger.kernel.org On Sat, May 7, 2011 at 7:57 AM, Stephen Boyd wrote: > Most arches define CONFIG_DEBUG_STACK_USAGE exactly the same way. > Move it to lib/Kconfig.debug so each arch doesn't have to define > it. This obviously makes the option generic, but that's fine > because the config is already used in generic code. > > It's not obvious to me that sysrq-P actually does anything > different with this option enabled, but I erred on the side of > caution by keeping the most inclusive wording. > > Cc: linux-arch@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: uclinux-dist-devel@blackfin.uclinux.org > Cc: linux-m32r@ml.linux-m32r.org > Cc: linux-mips@linux-mips.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org > Cc: Chris Metcalf > Cc: user-mode-linux-devel@lists.sourceforge.net > Cc: x86@kernel.org > Signed-off-by: Stephen Boyd > --- Acked-by: Richard Weinberger -- Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:61431 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753737Ab1EGJeP (ORCPT ); Sat, 7 May 2011 05:34:15 -0400 MIME-Version: 1.0 In-Reply-To: <1304747831-2098-1-git-send-email-sboyd@codeaurora.org> References: <1304747831-2098-1-git-send-email-sboyd@codeaurora.org> Date: Sat, 7 May 2011 11:34:13 +0200 Message-ID: Subject: Re: [PATCH] lib: Consolidate DEBUG_STACK_USAGE option From: richard -rw- weinberger Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Stephen Boyd Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, uclinux-dist-devel@blackfin.uclinux.org, linux-m32r@ml.linux-m32r.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, Chris Metcalf , user-mode-linux-devel@lists.sourceforge.net, x86@kernel.org Message-ID: <20110507093413.41XjmJ3QJlyx4bFQtXqgpu-LT7dfFqwOGZbt4Bd8irg@z> On Sat, May 7, 2011 at 7:57 AM, Stephen Boyd wrote: > Most arches define CONFIG_DEBUG_STACK_USAGE exactly the same way. > Move it to lib/Kconfig.debug so each arch doesn't have to define > it. This obviously makes the option generic, but that's fine > because the config is already used in generic code. > > It's not obvious to me that sysrq-P actually does anything > different with this option enabled, but I erred on the side of > caution by keeping the most inclusive wording. > > Cc: linux-arch@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: uclinux-dist-devel@blackfin.uclinux.org > Cc: linux-m32r@ml.linux-m32r.org > Cc: linux-mips@linux-mips.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org > Cc: Chris Metcalf > Cc: user-mode-linux-devel@lists.sourceforge.net > Cc: x86@kernel.org > Signed-off-by: Stephen Boyd > --- Acked-by: Richard Weinberger -- Thanks, //richard