From: Mike Frysinger <vapier.adi@gmail.com>
To: Sven Eckelmann <sven@narfation.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mips@linux-mips.org, linux-m32r@ml.linux-m32r.org,
linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-cris-kernel@axis.com, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, x86@kernel.org,
Chris Metcalf <cmetcalf@tilera.com>,
David Howells <dhowells@redhat.com>,
linux-m68k@lists.linux-m68k.org, linux-am33-list@redhat.com,
linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] atomic: add *_dec_not_zero
Date: Sun, 8 May 2011 22:38:43 -0400 [thread overview]
Message-ID: <BANLkTim+z0mv7oXZHr0YnoxtfnoDZTEr9Q@mail.gmail.com> (raw)
In-Reply-To: <201105081133.50824.sven@narfation.org>
On Sun, May 8, 2011 at 05:33, Sven Eckelmann wrote:
> Russell King - ARM Linux wrote:
> [...]
>> Do we need atomic_dec_not_zero() et.al. in every arch header - is there no
>> generic header which it could be added to?
>
> Mike Frysinger already tried to answer it in
> <BANLkTimctgbto3dsnJ3d3r7NggS0KF9_Sw@mail.gmail.com>:
>> that's what asm-generic is for. if the arch isnt using it, it's
>> either because the arch needs to convert to it, or they're using SMP
>> and asm-generic doesnt yet support that for atomic.h.
>>
>> for example, the Blackfin port only needed updating for the SMP case.
>> in the non-SMP case, we're getting the def from asm-generic/atomic.h.
>
> Feel free to change that but I just followed the style used by all other
> macros and will not redesign the complete atomic*.h idea.
what you're doing is currently correct. i think merging SMP support
into asm-generic for atomic* will take a bit of pondering first.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Mike Frysinger <vapier.adi@gmail.com>
To: Sven Eckelmann <sven@narfation.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mips@linux-mips.org, linux-m32r@ml.linux-m32r.org,
linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-cris-kernel@axis.com, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, x86@kernel.org,
Chris Metcalf <cmetcalf@tilera.com>,
David Howells <dhowells@redhat.com>,
linux-m68k@lists.linux-m68k.org, linux-am33-list@redhat.com,
linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] atomic: add *_dec_not_zero
Date: Sun, 8 May 2011 22:38:43 -0400 [thread overview]
Message-ID: <BANLkTim+z0mv7oXZHr0YnoxtfnoDZTEr9Q@mail.gmail.com> (raw)
Message-ID: <20110509023843.wfLIMeEkYcxtlo_moLpLhcU834QEHVApdLzcyQol9qg@z> (raw)
In-Reply-To: <201105081133.50824.sven@narfation.org>
On Sun, May 8, 2011 at 05:33, Sven Eckelmann wrote:
> Russell King - ARM Linux wrote:
> [...]
>> Do we need atomic_dec_not_zero() et.al. in every arch header - is there no
>> generic header which it could be added to?
>
> Mike Frysinger already tried to answer it in
> <BANLkTimctgbto3dsnJ3d3r7NggS0KF9_Sw@mail.gmail.com>:
>> that's what asm-generic is for. if the arch isnt using it, it's
>> either because the arch needs to convert to it, or they're using SMP
>> and asm-generic doesnt yet support that for atomic.h.
>>
>> for example, the Blackfin port only needed updating for the SMP case.
>> in the non-SMP case, we're getting the def from asm-generic/atomic.h.
>
> Feel free to change that but I just followed the style used by all other
> macros and will not redesign the complete atomic*.h idea.
what you're doing is currently correct. i think merging SMP support
into asm-generic for atomic* will take a bit of pondering first.
-mike
next prev parent reply other threads:[~2011-05-09 2:38 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 21:30 [PATCH] atomic: add *_dec_not_zero Sven Eckelmann
2011-05-03 21:30 ` Sven Eckelmann
2011-05-04 4:44 ` Mike Frysinger
2011-05-04 4:44 ` Mike Frysinger
2011-05-04 15:04 ` James Bottomley
2011-05-04 15:04 ` James Bottomley
2011-05-04 6:12 ` David Miller
2011-05-04 6:12 ` David Miller
2011-05-04 7:03 ` Ingo Molnar
2011-05-04 7:03 ` Ingo Molnar
2011-05-04 8:05 ` David Laight
2011-05-04 8:05 ` David Laight
2011-05-04 8:21 ` Sven Eckelmann
2011-05-04 8:21 ` Sven Eckelmann
2011-05-04 8:33 ` Mike Frysinger
[not found] ` <1304458235-28473-1-git-send-email-sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>
2011-05-04 10:48 ` Jesper Nilsson
2011-05-04 11:02 ` Ralf Baechle
2011-05-04 11:02 ` Ralf Baechle
2011-05-04 11:53 ` David Howells
2011-05-04 11:53 ` David Howells
2011-05-08 22:15 ` Benjamin Herrenschmidt
2011-05-08 22:15 ` Benjamin Herrenschmidt
2011-05-04 12:09 ` Chris Metcalf
2011-05-04 12:09 ` Chris Metcalf
2011-05-04 12:17 ` Geert Uytterhoeven
2011-05-04 12:17 ` Geert Uytterhoeven
2011-05-04 17:27 ` Will Deacon
2011-05-04 17:27 ` Will Deacon
2011-05-04 18:13 ` Matt Turner
2011-05-08 9:24 ` Russell King - ARM Linux
2011-05-08 9:24 ` Russell King - ARM Linux
2011-05-08 9:33 ` Sven Eckelmann
2011-05-08 9:33 ` Sven Eckelmann
2011-05-09 2:38 ` Mike Frysinger [this message]
2011-05-09 2:38 ` Mike Frysinger
2011-05-18 19:49 ` [PATCHv2] " Sven Eckelmann
2011-05-23 7:13 ` Paul Mundt
2011-05-23 7:13 ` Paul Mundt
2011-05-23 7:27 ` Heiko Carstens
2011-05-29 7:13 ` [PATCHv3] " Sven Eckelmann
2011-05-29 7:13 ` Sven Eckelmann
2011-06-02 5:44 ` Hirokazu Takata
2011-06-02 5:44 ` Hirokazu Takata
2011-06-17 10:38 ` [PATCHv3-resend] " Sven Eckelmann
2011-06-17 10:38 ` Sven Eckelmann
2011-06-17 15:13 ` Arnd Bergmann
2011-06-17 17:32 ` Sven Eckelmann
2011-06-17 17:32 ` Sven Eckelmann
2011-06-17 21:20 ` Arnd Bergmann
2011-06-17 21:20 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim+z0mv7oXZHr0YnoxtfnoDZTEr9Q@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=cmetcalf@tilera.com \
--cc=dhowells@redhat.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-am33-list@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r@ml.linux-m32r.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sparclinux@vger.kernel.org \
--cc=sven@narfation.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).