From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 7/7] ns: Wire up the setns system call Date: Sat, 7 May 2011 20:22:19 +0200 Message-ID: References: <1304735101-1824-1-git-send-email-ebiederm@xmission.com> <1304735101-1824-7-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Eric W. Biederman" Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, jamal , Daniel Lezcano , Linux Containers , Renato Westphal List-Id: linux-arch.vger.kernel.org On Sat, May 7, 2011 at 16:09, Eric W. Biederman = wrote: > Geert Uytterhoeven writes: > >> On Sat, May 7, 2011 at 04:25, Eric W. Biederman wrote: >>> =C2=A0arch/m68k/include/asm/unistd.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 | = =C2=A0 =C2=A03 ++- >>> =C2=A0arch/m68k/kernel/syscalltable.S =C2=A0 =C2=A0 =C2=A0 =C2=A0| = =C2=A0 =C2=A01 + >> >> As the unified syscalltable for m68k/m68knommu is not yet in mainlin= e >> (planned for >> 2.6.40), you should also add it to arch/m68k/kernel/entry_mm.S. >> >> Gr{oetje,eeting}s, > > Like so? > > From c06a03281d944ed36e2da02f5374ec6c650e4988 Mon Sep 17 00:00:00 200= 1 > From: "Eric W. Biederman" > Date: Sat, 7 May 2011 07:00:24 -0700 > Subject: [PATCH] m68knommu: Wire up the setns system call > > It seems I overlooked m68knommu where I wired up this syscall. You overlooked m68k with MMU. syscalltable.s is used by m68knommu. > Reported-by: =C2=A0Geert Uytterhoeven > Signed-off-by: Eric W. Biederman > --- > =C2=A0arch/m68k/kernel/entry_mm.S | =C2=A0 =C2=A01 + > =C2=A01 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/m68k/kernel/entry_mm.S b/arch/m68k/kernel/entry_mm.= S > index 1359ee6..e048015 100644 > --- a/arch/m68k/kernel/entry_mm.S > +++ b/arch/m68k/kernel/entry_mm.S > @@ -754,4 +754,5 @@ sys_call_table: > =C2=A0 =C2=A0 =C2=A0 =C2=A0.long sys_open_by_handle_at > =C2=A0 =C2=A0 =C2=A0 =C2=A0.long sys_clock_adjtime > =C2=A0 =C2=A0 =C2=A0 =C2=A0.long sys_syncfs > + =C2=A0 =C2=A0 =C2=A0 .long sys_setns Yep. Gr{oetje,eeting}s, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-= m68k.org In personal conversations with technical people, I call myself a hacker= =2E But when I'm talking to journalists I just say "programmer" or something li= ke that. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:53812 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755901Ab1EGSWV convert rfc822-to-8bit (ORCPT ); Sat, 7 May 2011 14:22:21 -0400 MIME-Version: 1.0 In-Reply-To: References: <1304735101-1824-1-git-send-email-ebiederm@xmission.com> <1304735101-1824-7-git-send-email-ebiederm@xmission.com> Date: Sat, 7 May 2011 20:22:19 +0200 Message-ID: Subject: Re: [PATCH 7/7] ns: Wire up the setns system call From: Geert Uytterhoeven Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Eric W. Biederman" Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, jamal , Daniel Lezcano , Linux Containers , Renato Westphal Message-ID: <20110507182219.E3fRroVRtsS3z9d1gC24F7Y3apl4T4dnH43tZEMhG3A@z> On Sat, May 7, 2011 at 16:09, Eric W. Biederman wrote: > Geert Uytterhoeven writes: > >> On Sat, May 7, 2011 at 04:25, Eric W. Biederman wrote: >>>  arch/m68k/include/asm/unistd.h         |    3 ++- >>>  arch/m68k/kernel/syscalltable.S        |    1 + >> >> As the unified syscalltable for m68k/m68knommu is not yet in mainline >> (planned for >> 2.6.40), you should also add it to arch/m68k/kernel/entry_mm.S. >> >> Gr{oetje,eeting}s, > > Like so? > > From c06a03281d944ed36e2da02f5374ec6c650e4988 Mon Sep 17 00:00:00 2001 > From: "Eric W. Biederman" > Date: Sat, 7 May 2011 07:00:24 -0700 > Subject: [PATCH] m68knommu: Wire up the setns system call > > It seems I overlooked m68knommu where I wired up this syscall. You overlooked m68k with MMU. syscalltable.s is used by m68knommu. > Reported-by:  Geert Uytterhoeven > Signed-off-by: Eric W. Biederman > --- >  arch/m68k/kernel/entry_mm.S |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/m68k/kernel/entry_mm.S b/arch/m68k/kernel/entry_mm.S > index 1359ee6..e048015 100644 > --- a/arch/m68k/kernel/entry_mm.S > +++ b/arch/m68k/kernel/entry_mm.S > @@ -754,4 +754,5 @@ sys_call_table: >        .long sys_open_by_handle_at >        .long sys_clock_adjtime >        .long sys_syncfs > +       .long sys_setns Yep. Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.                                 -- Linus Torvalds