linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martijn Coenen <maco@android.com>
To: Jessica Yu <jeyu@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Oliver Neukum <oneukum@suse.com>, Arnd Bergmann <arnd@arndb.de>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-kbuild@vger.kernel.org,
	linux-m68k <linux-m68k@lists.linux-m68k.org>,
	USB list <linux-usb@vger.kernel.org>USB
Subject: Re: [PATCH 2/6] module: add support for symbol namespaces.
Date: Tue, 24 Jul 2018 09:44:25 +0200	[thread overview]
Message-ID: <CAB0TPYHu2tDuefRCfdUd_A8XqRQ_ym811ua-Cu3C=xUPnyHTGw@mail.gmail.com> (raw)
In-Reply-To: <20180723111251.x2cam6bcuglr4hhz@linux-8ccs>

On Mon, Jul 23, 2018 at 1:12 PM, Jessica Yu <jeyu@kernel.org> wrote:
> IMO I don't think we should bend over backwards to accommodate
> out-of-tree modules - modifying the module loader to recognize even
> more special sections to accommodate these OOT modules would be where
> we'd draw the line I think.

I agree with you, I really don't like making the module loader more
complex (which is why I didn't opt to create separate sections in the
first place), and in the end this change will in some ways benefit
out-of-tree drivers too, even though it will be a bit painful now.

> I think going forward I would prefer to have export namespaces to be a
> normal and regular part of kernel API (as in, we shouldn't require a
> new option for it), and that the warnings for 1-2 cycles are courteous
> enough - but anyone with stronger opinions about this should speak up.

That aligns with how I think about this; if we want this to be a
standard thing in the kernel, we should at some point enforce it,
because it's pretty easy to ignore the warning. The good thing is that
it's not a big on/off switch, but subsystem maintainers can just
introduce namespaces when it makes sense.

Thanks,
Martijn

>
> Thanks,
>
> Jessica

WARNING: multiple messages have this Message-ID (diff)
From: Martijn Coenen <maco@android.com>
To: Jessica Yu <jeyu@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Oliver Neukum <oneukum@suse.com>, Arnd Bergmann <arnd@arndb.de>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-kbuild@vger.kernel.org,
	linux-m68k <linux-m68k@lists.linux-m68k.org>,
	USB list <linux-usb@vger.kernel.org>,
	USB Storage list <usb-storage@lists.one-eyed-alien.net>,
	linux-scsi@vger.kernel.org,
	Linux-Arch <linux-arch@vger.kernel.org>,
	Martijn Coenen <maco@google.com>,
	Sandeep Patil <sspatil@google.com>,
	Iliyan Malchev <malchev@google.com>,
	Joel Fernandes <joelaf@google.com>
Subject: Re: [PATCH 2/6] module: add support for symbol namespaces.
Date: Tue, 24 Jul 2018 09:44:25 +0200	[thread overview]
Message-ID: <CAB0TPYHu2tDuefRCfdUd_A8XqRQ_ym811ua-Cu3C=xUPnyHTGw@mail.gmail.com> (raw)
Message-ID: <20180724074425.UjaNr90J0V34-78dH32_lEc0iGvNgPffgJLVBgfLCQA@z> (raw)
In-Reply-To: <20180723111251.x2cam6bcuglr4hhz@linux-8ccs>

On Mon, Jul 23, 2018 at 1:12 PM, Jessica Yu <jeyu@kernel.org> wrote:
> IMO I don't think we should bend over backwards to accommodate
> out-of-tree modules - modifying the module loader to recognize even
> more special sections to accommodate these OOT modules would be where
> we'd draw the line I think.

I agree with you, I really don't like making the module loader more
complex (which is why I didn't opt to create separate sections in the
first place), and in the end this change will in some ways benefit
out-of-tree drivers too, even though it will be a bit painful now.

> I think going forward I would prefer to have export namespaces to be a
> normal and regular part of kernel API (as in, we shouldn't require a
> new option for it), and that the warnings for 1-2 cycles are courteous
> enough - but anyone with stronger opinions about this should speak up.

That aligns with how I think about this; if we want this to be a
standard thing in the kernel, we should at some point enforce it,
because it's pretty easy to ignore the warning. The good thing is that
it's not a big on/off switch, but subsystem maintainers can just
introduce namespaces when it makes sense.

Thanks,
Martijn

>
> Thanks,
>
> Jessica

  parent reply	other threads:[~2018-07-24  7:44 UTC|newest]

Thread overview: 182+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16 12:21 [PATCH 0/6] Symbol namespaces Martijn Coenen
2018-07-16 12:21 ` Martijn Coenen
2018-07-16 12:21 ` [PATCH 1/6] export: explicitly align struct kernel_symbol Martijn Coenen
2018-07-16 12:21   ` Martijn Coenen
2018-07-16 12:21 ` [PATCH 2/6] module: add support for symbol namespaces Martijn Coenen
2018-07-16 12:21   ` Martijn Coenen
2018-07-19 16:32   ` Jessica Yu
2018-07-19 16:32     ` Jessica Yu
2018-07-20  7:54     ` Martijn Coenen
2018-07-20  7:54       ` Martijn Coenen
2018-07-20 14:49       ` Jessica Yu
2018-07-20 14:49         ` Jessica Yu
2018-07-20 15:42         ` Martijn Coenen
2018-07-20 15:42           ` Martijn Coenen
2018-07-23 11:12           ` Jessica Yu
2018-07-23 11:12             ` Jessica Yu
2018-07-24  7:44             ` Martijn Coenen [this message]
2018-07-24  7:44               ` Martijn Coenen
2018-07-24  7:56   ` Martijn Coenen
2018-07-24  7:56     ` Martijn Coenen
2018-07-25 15:55     ` Jessica Yu
2018-07-25 15:55       ` Jessica Yu
2018-07-25 16:48       ` Lucas De Marchi
2018-07-25 16:48         ` Lucas De Marchi
2018-07-26  7:44         ` Martijn Coenen
2018-07-26  7:44           ` Martijn Coenen
2018-07-16 12:21 ` [PATCH 3/6] modpost: add support for checking " Martijn Coenen
2018-07-16 12:21   ` Martijn Coenen
2018-07-16 12:21 ` [PATCH 4/6] modpost: add support for generating namespace dependencies Martijn Coenen
2018-07-16 12:21   ` Martijn Coenen
2018-07-23  6:49   ` Jessica Yu
2018-07-23  6:49     ` Jessica Yu
2018-07-16 12:21 ` [PATCH 5/6] scripts: Coccinelle script for " Martijn Coenen
2018-07-16 12:21   ` Martijn Coenen
2018-07-16 12:21 ` [PATCH 6/6] RFC: USB: storage: move symbols into USB_STORAGE namespace Martijn Coenen
2018-07-16 12:21   ` Martijn Coenen
2018-07-16 15:33 ` [PATCH 0/6] Symbol namespaces Greg Kroah-Hartman
2018-07-16 15:33   ` Greg Kroah-Hartman
2018-07-23 14:28 ` Arnd Bergmann
2018-07-23 14:28   ` Arnd Bergmann
2018-07-24  8:09   ` Martijn Coenen
2018-07-24  8:09     ` Martijn Coenen
2018-07-24  9:08     ` Arnd Bergmann
2018-07-24  9:08       ` Arnd Bergmann
2019-08-13 12:16 ` [PATCH v2 0/10] Symbol namespaces - RFC Matthias Maennich
2019-08-13 12:16   ` Matthias Maennich
2019-08-13 12:16   ` [PATCH v2 01/10] module: support reading multiple values per modinfo tag Matthias Maennich
2019-08-13 12:16     ` Matthias Maennich
2019-08-13 12:40     ` Greg KH
2019-08-13 12:40       ` Greg KH
2019-08-13 12:16   ` [PATCH v2 02/10] export: explicitly align struct kernel_symbol Matthias Maennich
2019-08-13 12:16     ` Matthias Maennich
2019-08-13 12:41     ` Greg KH
2019-08-13 12:41       ` Greg KH
2019-08-13 12:17   ` [PATCH v2 03/10] module: add support for symbol namespaces Matthias Maennich
2019-08-13 12:17     ` Matthias Maennich
2019-08-13 15:26     ` Greg KH
2019-08-13 15:26       ` Greg KH
2019-08-13 12:17   ` [PATCH v2 04/10] modpost: " Matthias Maennich
2019-08-13 12:17     ` Matthias Maennich
2019-08-13 15:27     ` Greg KH
2019-08-13 15:27       ` Greg KH
2019-08-13 12:17   ` [PATCH v2 05/10] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS Matthias Maennich
2019-08-13 12:17     ` Matthias Maennich
2019-08-13 18:17     ` Greg KH
2019-08-13 18:17       ` Greg KH
2019-08-13 20:15     ` Saravana Kannan
2019-08-13 20:15       ` Saravana Kannan
2019-08-14 12:54       ` Matthias Maennich
2019-08-14 12:54         ` Matthias Maennich
2019-08-14 17:34         ` Saravana Kannan
2019-08-14 17:34           ` Saravana Kannan
2019-08-13 12:17   ` [PATCH v2 06/10] export: allow definition default namespaces in Makefiles or sources Matthias Maennich
2019-08-13 12:17     ` Matthias Maennich
2019-08-13 18:16     ` Greg KH
2019-08-13 18:16       ` Greg KH
2019-08-13 18:16     ` Greg KH
2019-08-13 18:16       ` Greg KH
2019-08-13 12:17   ` [PATCH v2 07/10] modpost: add support for generating namespace dependencies Matthias Maennich
2019-08-13 12:17     ` Matthias Maennich
2019-08-13 18:21     ` Greg KH
2019-08-13 18:21       ` Greg KH
2019-08-13 12:17   ` [PATCH v2 08/10] scripts: Coccinelle script for " Matthias Maennich
2019-08-13 12:17     ` Matthias Maennich
2019-08-13 12:31     ` Julia Lawall
2019-08-13 12:31       ` Julia Lawall
2019-08-13 12:44     ` Greg KH
2019-08-13 12:44       ` Greg KH
2019-08-14  6:36     ` [Cocci] " Himanshu Jha
2019-08-14  6:36       ` Himanshu Jha
2019-08-14  8:03       ` Matthias Maennich
2019-08-14  8:03         ` Matthias Maennich
2019-08-14 12:00     ` [v2 " Markus Elfring
2019-08-14 12:00       ` Markus Elfring
2019-08-14 12:20       ` Matthias Maennich
2019-08-15 13:50     ` Markus Elfring
2019-08-15 13:50       ` Markus Elfring
2019-08-22  9:18       ` Matthias Maennich
2019-08-22  9:18         ` Matthias Maennich
2019-08-22 11:00         ` Markus Elfring
2019-08-22 11:00           ` Markus Elfring
2019-08-13 12:17   ` [PATCH v2 09/10] usb-storage: remove single-use define for debugging Matthias Maennich
2019-08-13 12:17     ` Matthias Maennich
2019-08-13 12:42     ` Greg KH
2019-08-13 12:42       ` Greg KH
2019-08-13 13:12       ` Greg KH
2019-08-13 13:12         ` Greg KH
2019-08-13 12:17   ` [PATCH v2 10/10] RFC: usb-storage: export symbols in USB_STORAGE namespace Matthias Maennich
2019-08-13 12:17     ` Matthias Maennich
2019-08-13 12:45     ` Greg KH
2019-08-13 12:45       ` Greg KH
2019-08-13 12:47     ` Greg KH
2019-08-13 12:47       ` Greg KH
2019-08-13 15:02       ` Matthias Maennich
2019-08-13 15:02         ` Matthias Maennich
     [not found]   ` <20190813121733.52480-1-maennich-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-08-21 11:49     ` [PATCH v3 00/11] Symbol Namespaces Matthias Maennich
2019-08-21 11:49       ` [PATCH v3 01/11] module: support reading multiple values per modinfo tag Matthias Maennich
2019-08-21 11:49         ` Matthias Maennich
2019-08-21 11:49       ` [PATCH v3 02/11] export: explicitly align struct kernel_symbol Matthias Maennich
2019-08-21 11:49         ` Matthias Maennich
2019-08-21 11:49       ` [PATCH v3 03/11] module: add support for symbol namespaces Matthias Maennich
2019-08-21 11:49         ` Matthias Maennich
2019-08-27 15:37         ` Jessica Yu
2019-08-27 15:37           ` Jessica Yu
2019-08-27 16:04           ` Matthias Maennich
2019-08-27 16:04             ` Matthias Maennich
2019-08-21 11:49       ` [PATCH v3 04/11] modpost: " Matthias Maennich
2019-08-21 11:49         ` Matthias Maennich
2019-08-26 16:21         ` Jessica Yu
2019-08-26 16:21           ` Jessica Yu
2019-08-27 14:41           ` Matthias Maennich
2019-08-27 14:41             ` Matthias Maennich
2019-08-28  9:43             ` Jessica Yu
2019-08-28  9:43               ` Jessica Yu
2019-08-28  9:55               ` Matthias Maennich
2019-08-28  9:55                 ` Matthias Maennich
2019-08-28 10:16                 ` Jessica Yu
2019-08-28 10:16                   ` Jessica Yu
2019-08-21 11:49       ` [PATCH v3 05/11] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS Matthias Maennich
2019-08-21 11:49         ` Matthias Maennich
2019-08-21 11:49       ` [PATCH v3 06/11] export: allow definition default namespaces in Makefiles or sources Matthias Maennich
2019-08-21 11:49         ` Matthias Maennich
2019-08-28 10:49         ` Jessica Yu
2019-08-28 10:49           ` Jessica Yu
2019-08-28 10:56           ` Matthias Maennich
2019-08-28 10:56             ` Matthias Maennich
2019-08-21 11:49       ` [PATCH v3 07/11] modpost: add support for generating namespace dependencies Matthias Maennich
2019-08-21 11:49         ` Matthias Maennich
2019-08-21 11:49       ` [PATCH v3 08/11] scripts: Coccinelle script for " Matthias Maennich
2019-08-21 11:49         ` Matthias Maennich
2019-08-22  6:09         ` [v3 " Markus Elfring
2019-08-22  6:09           ` Markus Elfring
2019-08-29 12:13         ` [PATCH v3 " Jessica Yu
2019-08-29 12:13           ` Jessica Yu
2019-08-21 11:49       ` [PATCH v3 09/11] usb-storage: remove single-use define for debugging Matthias Maennich
2019-08-21 11:49         ` Matthias Maennich
2019-08-21 12:37         ` Greg KH
2019-08-21 12:37           ` Greg KH
2019-08-21 13:21         ` Thomas Gleixner
2019-08-21 13:21           ` Thomas Gleixner
2019-08-21 13:32           ` Greg KH
2019-08-21 13:32             ` Greg KH
2019-08-21 11:49       ` [PATCH v3 10/11] RFC: usb-storage: export symbols in USB_STORAGE namespace Matthias Maennich
2019-08-21 11:49         ` Matthias Maennich
2019-08-21 12:38         ` Greg KH
2019-08-21 12:38           ` Greg KH
2019-08-21 14:36           ` Jessica Yu
2019-08-21 14:36             ` Jessica Yu
2019-08-21 23:13         ` Christoph Hellwig
2019-08-21 23:13           ` Christoph Hellwig
2019-08-22  8:32           ` Matthias Maennich
2019-08-22  8:32             ` Matthias Maennich
     [not found]       ` <20190821114955.12788-1-maennich-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-08-21 11:49         ` [PATCH v3 11/11] RFC: watchdog: export core symbols in WATCHDOG_CORE namespace Matthias Maennich
     [not found]           ` <20190821114955.12788-12-maennich-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-08-21 12:39             ` Greg KH
2019-08-21 14:59             ` Guenter Roeck
     [not found]               ` <20190821145911.GA6521-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2019-08-21 16:28                 ` Matthias Maennich
2019-08-21 12:46         ` [PATCH v3 00/11] Symbol Namespaces Nicolas Pitre
     [not found]           ` <nycvar.YSQ.7.76.1908210840490.19480-fMhRO7WWcppj+hNMo8g0rg@public.gmane.org>
2019-08-21 13:37             ` Greg KH
     [not found]               ` <20190821133737.GB4890-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2019-08-21 20:48                 ` Nicolas Pitre
2019-08-21 13:11         ` Peter Zijlstra
     [not found]           ` <20190821131140.GC2349-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2019-08-21 13:38             ` Greg KH
     [not found]               ` <20190821133846.GC4890-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2019-08-21 14:03                 ` Matthias Maennich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB0TPYHu2tDuefRCfdUd_A8XqRQ_ym811ua-Cu3C=xUPnyHTGw@mail.gmail.com' \
    --to=maco@android.com \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jeyu@kernel.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=mingo@redhat.com \
    --cc=oneukum@suse.com \
    --cc=pombredanne@nexb.com \
    --cc=sam@ravnborg.org \
    --cc=sboyd@codeaurora.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).