From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martijn Coenen Subject: Re: [PATCH 2/6] module: add support for symbol namespaces. Date: Tue, 24 Jul 2018 09:44:25 +0200 Message-ID: References: <20180716122125.175792-1-maco@android.com> <20180716122125.175792-3-maco@android.com> <20180719163208.5xvrafugpcbhh7kj@linux-8ccs> <20180720144916.fyqpmrtgt23sax6n@linux-8ccs> <20180723111251.x2cam6bcuglr4hhz@linux-8ccs> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180723111251.x2cam6bcuglr4hhz@linux-8ccs> Sender: linux-kernel-owner@vger.kernel.org To: Jessica Yu Cc: LKML , Masahiro Yamada , Michal Marek , Geert Uytterhoeven , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , Alan Stern , Greg Kroah-Hartman , Oliver Neukum , Arnd Bergmann , Stephen Boyd , Philippe Ombredanne , Kate Stewart , Sam Ravnborg , linux-kbuild@vger.kernel.org, linux-m68k , USB list USB List-Id: linux-arch.vger.kernel.org On Mon, Jul 23, 2018 at 1:12 PM, Jessica Yu wrote: > IMO I don't think we should bend over backwards to accommodate > out-of-tree modules - modifying the module loader to recognize even > more special sections to accommodate these OOT modules would be where > we'd draw the line I think. I agree with you, I really don't like making the module loader more complex (which is why I didn't opt to create separate sections in the first place), and in the end this change will in some ways benefit out-of-tree drivers too, even though it will be a bit painful now. > I think going forward I would prefer to have export namespaces to be a > normal and regular part of kernel API (as in, we shouldn't require a > new option for it), and that the warnings for 1-2 cycles are courteous > enough - but anyone with stronger opinions about this should speak up. That aligns with how I think about this; if we want this to be a standard thing in the kernel, we should at some point enforce it, because it's pretty easy to ignore the warning. The good thing is that it's not a big on/off switch, but subsystem maintainers can just introduce namespaces when it makes sense. Thanks, Martijn > > Thanks, > > Jessica From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f65.google.com ([209.85.214.65]:34869 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388421AbeGXItf (ORCPT ); Tue, 24 Jul 2018 04:49:35 -0400 Received: by mail-it0-f65.google.com with SMTP id q20-v6so2427954ith.0 for ; Tue, 24 Jul 2018 00:44:26 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180723111251.x2cam6bcuglr4hhz@linux-8ccs> References: <20180716122125.175792-1-maco@android.com> <20180716122125.175792-3-maco@android.com> <20180719163208.5xvrafugpcbhh7kj@linux-8ccs> <20180720144916.fyqpmrtgt23sax6n@linux-8ccs> <20180723111251.x2cam6bcuglr4hhz@linux-8ccs> From: Martijn Coenen Date: Tue, 24 Jul 2018 09:44:25 +0200 Message-ID: Subject: Re: [PATCH 2/6] module: add support for symbol namespaces. Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Jessica Yu Cc: LKML , Masahiro Yamada , Michal Marek , Geert Uytterhoeven , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , Alan Stern , Greg Kroah-Hartman , Oliver Neukum , Arnd Bergmann , Stephen Boyd , Philippe Ombredanne , Kate Stewart , Sam Ravnborg , linux-kbuild@vger.kernel.org, linux-m68k , USB list , USB Storage list , linux-scsi@vger.kernel.org, Linux-Arch , Martijn Coenen , Sandeep Patil , Iliyan Malchev , Joel Fernandes Message-ID: <20180724074425.UjaNr90J0V34-78dH32_lEc0iGvNgPffgJLVBgfLCQA@z> On Mon, Jul 23, 2018 at 1:12 PM, Jessica Yu wrote: > IMO I don't think we should bend over backwards to accommodate > out-of-tree modules - modifying the module loader to recognize even > more special sections to accommodate these OOT modules would be where > we'd draw the line I think. I agree with you, I really don't like making the module loader more complex (which is why I didn't opt to create separate sections in the first place), and in the end this change will in some ways benefit out-of-tree drivers too, even though it will be a bit painful now. > I think going forward I would prefer to have export namespaces to be a > normal and regular part of kernel API (as in, we shouldn't require a > new option for it), and that the warnings for 1-2 cycles are courteous > enough - but anyone with stronger opinions about this should speak up. That aligns with how I think about this; if we want this to be a standard thing in the kernel, we should at some point enforce it, because it's pretty easy to ignore the warning. The good thing is that it's not a big on/off switch, but subsystem maintainers can just introduce namespaces when it makes sense. Thanks, Martijn > > Thanks, > > Jessica