From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greentime Hu Subject: Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings Date: Mon, 22 Jan 2018 21:55:25 +0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: netdev-owner@vger.kernel.org To: Arnd Bergmann Cc: Geert Uytterhoeven , Greentime , Linux Kernel Mailing List , linux-arch , Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Networking , Vincent Chen , DTML , Al Viro , David Howells , Will Deacon , Daniel Lezcano , linux-serial@vger.kernel.org, Linus Walleij , Mark Rutland , Greg KH , Guo Ren List-Id: linux-arch.vger.kernel.org Hi, Arnd: 2018-01-22 19:15 GMT+08:00 Arnd Bergmann : > On Mon, Jan 22, 2018 at 10:53 AM, Greentime Hu wrote: >> 2018-01-19 23:37 GMT+08:00 Geert Uytterhoeven : >>> On Fri, Jan 19, 2018 at 4:35 PM, Greentime Hu wrote: >>>> 2018-01-19 23:29 GMT+08:00 Geert Uytterhoeven : >>>>> On Fri, Jan 19, 2018 at 4:18 PM, Greentime Hu wrote: > >>>> Thank you and your example. >>>> I get it. I will update this document like this. >>>> - compatible: Should be "andestech,", "andestech,nds32v3" >>>> as fallback. >>> >>> And please keep a list of supported values of "andestech," >>> in the DT binding document, so checkpatch can validate compatible values. >>> >> >> Thank you for reminding me this. >> I will list it like this. >> >> - compatible: >> Usage: required >> Value type: >> Definition: Should be "andestech,", >> "andestech,nds32v3" as fallback. >> Examlpes with core_names are: >> "andestech,n13" >> "andestech,n15" >> "andestech,d15" >> "andestech,n10" >> "andestech,d10" > > This is still not written as a proper specification, you should not > give "examples" > but give a complete list of the available options. You could write it like: > > Must contain "andestech,nds32v3" as the most generic value, in addition to > one of the following identifiers for a particular CPU core: > "andestech,n13" > "andestech,n15" > "andestech,d15" > "andestech,n10" > "andestech,d10" > > It might be helpful to also list all other existing nds32v3 cores, > even those that the > current Linux port does not support them. > Thank you for the clear explanation. I will update it just like you wrote. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f179.google.com ([209.85.217.179]:45337 "EHLO mail-ua0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbeAVN4H (ORCPT ); Mon, 22 Jan 2018 08:56:07 -0500 MIME-Version: 1.0 In-Reply-To: References: From: Greentime Hu Date: Mon, 22 Jan 2018 21:55:25 +0800 Message-ID: Subject: Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: Geert Uytterhoeven , Greentime , Linux Kernel Mailing List , linux-arch , Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Networking , Vincent Chen , DTML , Al Viro , David Howells , Will Deacon , Daniel Lezcano , linux-serial@vger.kernel.org, Linus Walleij , Mark Rutland , Greg KH , Guo Ren , Randy Dunlap , David Miller , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Vincent Chen , Rick Chen , Zong Li Message-ID: <20180122135525.mi_TCH6H4ZBx4wM-QTdDABWvh50xm29AruDjjfSfLqA@z> Hi, Arnd: 2018-01-22 19:15 GMT+08:00 Arnd Bergmann : > On Mon, Jan 22, 2018 at 10:53 AM, Greentime Hu wrote: >> 2018-01-19 23:37 GMT+08:00 Geert Uytterhoeven : >>> On Fri, Jan 19, 2018 at 4:35 PM, Greentime Hu wrote: >>>> 2018-01-19 23:29 GMT+08:00 Geert Uytterhoeven : >>>>> On Fri, Jan 19, 2018 at 4:18 PM, Greentime Hu wrote: > >>>> Thank you and your example. >>>> I get it. I will update this document like this. >>>> - compatible: Should be "andestech,", "andestech,nds32v3" >>>> as fallback. >>> >>> And please keep a list of supported values of "andestech," >>> in the DT binding document, so checkpatch can validate compatible values. >>> >> >> Thank you for reminding me this. >> I will list it like this. >> >> - compatible: >> Usage: required >> Value type: >> Definition: Should be "andestech,", >> "andestech,nds32v3" as fallback. >> Examlpes with core_names are: >> "andestech,n13" >> "andestech,n15" >> "andestech,d15" >> "andestech,n10" >> "andestech,d10" > > This is still not written as a proper specification, you should not > give "examples" > but give a complete list of the available options. You could write it like: > > Must contain "andestech,nds32v3" as the most generic value, in addition to > one of the following identifiers for a particular CPU core: > "andestech,n13" > "andestech,n15" > "andestech,d15" > "andestech,n10" > "andestech,d10" > > It might be helpful to also list all other existing nds32v3 cores, > even those that the > current Linux port does not support them. > Thank you for the clear explanation. I will update it just like you wrote.