From: Matt Turner <mattst88@gmail.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-alpha@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Subject: Re: [PATCH] Move most arches to asm-generic/current.h
Date: Mon, 30 Apr 2012 13:11:25 -0400 [thread overview]
Message-ID: <CAEdQ38GUKdAxEhAUWCUGv_4znmYANEgd0TY2vYOaO6Y2=p2vog@mail.gmail.com> (raw)
In-Reply-To: <4F9EC6E9.9000102@codeaurora.org>
On Mon, Apr 30, 2012 at 1:07 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 04/30/12 09:38, Arnd Bergmann wrote:
>
>> On Monday 30 April 2012, Stephen Boyd wrote:
>>> I admit I haven't compile tested this on all the affected architectures.
>>> Looking at the architectures that are migrated here I don't see any that
>>> are defining get_current() as a macro except for alpha. Should I drop
>>> alpha from the patch? Or would it be easier if someone threw this into
>>> linux-next and see if it blows up?
>>>
>>> In the meantime I can scrounge around for those kernel.org
>>> cross-compilers and see if I can compile alpha.
>> I'd say either get an Ack from the Alpha maintainers or drop that
>> hunk from your patch.
>>
>
> Ok. Alpha maintainers, do you see any problem with a static inline
> function for get_current() instead of the current macro? My compile of
> alpha with the kernel.org 4.6.3 compilers doesn't show any new build
> failures than what is already there:
>
> LD .tmp_vmlinux1
> drivers/built-in.o: In function `ide_set_disk_chs':
> drivers/ide/ide.c:269:(.text+0x732a8): relocation truncated to fit: GPREL16 against `.sbss'
> drivers/ide/ide.c:269:(.text+0x732b0): relocation truncated to fit: GPREL16 against `.sbss'
> drivers/ide/ide.c:267:(.text+0x73310): relocation truncated to fit: GPREL16 against `.sbss'
> drivers/ide/ide.c:267:(.text+0x73318): relocation truncated to fit: GPREL16 against `.sbss'
> drivers/built-in.o: In function `ide_dev_apply_params':
> drivers/ide/ide.c:299:(.text+0x73714): relocation truncated to fit: GPREL16 against `.sbss'
> drivers/ide/ide.c:303:(.text+0x73724): relocation truncated to fit: GPREL16 against `.sbss'
> drivers/ide/ide.c:308:(.text+0x73734): relocation truncated to fit: GPREL16 against `.sbss'
> drivers/ide/ide.c:315:(.text+0x73744): relocation truncated to fit: GPREL16 against `.sbss'
> drivers/built-in.o: In function `unexpected_intr':
> drivers/ide/ide-io.c:734:(.text+0x74dfc): relocation truncated to fit: GPREL16 against `.sbss'
> drivers/ide/ide-io.c:736:(.text+0x74e00): relocation truncated to fit: GPREL16 against `.sbss'
> drivers/ide/ide-io.c:734:(.text+0x74e10): additional relocation overflows omitted from the output
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [sub-make] Error 2
I'll take a look later this week.
The relocation truncated to fit: GPREL16 against ... error is caused
by the kernel being too large and compiling with -msmall-data. We've
really got to do something about this -- this happens way too often to
way too many people.
Matt
next prev parent reply other threads:[~2012-04-30 17:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 3:18 [PATCH] Move most arches to asm-generic/current.h Stephen Boyd
2012-04-24 3:30 ` David Miller
2012-04-26 17:51 ` Stephen Boyd
2012-04-30 9:08 ` David Howells
2012-04-30 12:51 ` Chris Metcalf
2012-04-30 14:15 ` Arnd Bergmann
2012-04-30 16:35 ` Stephen Boyd
2012-04-30 16:38 ` Arnd Bergmann
2012-04-30 17:07 ` Stephen Boyd
2012-04-30 17:07 ` Stephen Boyd
2012-04-30 17:11 ` Matt Turner [this message]
2012-04-30 19:52 ` Arnd Bergmann
2012-08-22 19:25 ` [PATCH/RESEND] " Stephen Boyd
2012-08-22 19:25 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEdQ38GUKdAxEhAUWCUGv_4znmYANEgd0TY2vYOaO6Y2=p2vog@mail.gmail.com' \
--to=mattst88@gmail.com \
--cc=arnd@arndb.de \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).