From: Bjorn Helgaas <bhelgaas@google.com>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, Adam Belay <abelay@mit.edu>
Subject: Re: [PATCH 43/57] PNP: irq: Remove IRQF_DISABLED
Date: Wed, 21 Sep 2011 14:20:46 -0600 [thread overview]
Message-ID: <CAErSpo7VR8+AGgWABb2c0uU_bgcmg43dxui41JFzmCQPvC7bGg@mail.gmail.com> (raw)
In-Reply-To: <1316597339-29861-44-git-send-email-yong.zhang0@gmail.com>
On Wed, Sep 21, 2011 at 3:28 AM, Yong Zhang <yong.zhang0@gmail.com> wrote:
> Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled],
> We run all interrupt handlers with interrupts disabled
> and we even check and yell when an interrupt handler
> returns with interrupts enabled (see commit [b738a50a:
> genirq: Warn when handler enables interrupts]).
>
> So now this flag is a NOOP and can be removed.
>
> Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/pnp/resource.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
> index b0ecacb..3669821 100644
> --- a/drivers/pnp/resource.c
> +++ b/drivers/pnp/resource.c
> @@ -385,7 +385,7 @@ int pnp_check_irq(struct pnp_dev *dev, struct resource *res)
> * device is active because it itself may be in use */
> if (!dev->active) {
> if (request_irq(*irq, pnp_test_handler,
> - IRQF_DISABLED | IRQF_PROBE_SHARED, "pnp", NULL))
> + IRQF_PROBE_SHARED, "pnp", NULL))
> return 0;
> free_irq(*irq, NULL);
> }
> --
> 1.7.4.1
>
>
next prev parent reply other threads:[~2011-09-21 20:21 UTC|newest]
Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 9:28 [PATCH V1 00/57] Tree wide: cleanup IRQF_DISABLED Yong Zhang
2011-09-21 9:28 ` [PATCH 01/57] usb/hcd: Remove tricky code dealing with IRQF_DISABLED && IRQF_SHARED Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 02/57] alpha: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 04/57] avr32: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 05/57] cris: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 06/57] frv: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 07/57] h8300: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 08/57] ia64: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 09/57] m32r: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 10/57] m68k: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 11/57] microblaze: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 12/57] MIPS: " Yong Zhang
2011-09-21 9:28 ` [PATCH 13/57] mn10300: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 14/57] parisc: irq: remove IRQF_DISABLED Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 15/57] powerpc: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 16/57] score: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 17/57] SH: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 18/57] sparc: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 17:40 ` David Miller
2011-09-21 9:28 ` [PATCH 19/57] um: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 20/57] unicore32: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 21/57] x86: irq: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 22/57] xtensa: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 23/57] clocksource: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 24/57] SCSI: " Yong Zhang
2011-09-21 9:28 ` [PATCH 25/57] ata: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 10:35 ` Wolfram Sang
2011-09-21 9:28 ` [PATCH 26/57] block: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 27/57] cdrom: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 28/57] driver/char: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 29/57] crypto: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 30/57] dmaengine: " Yong Zhang
2011-09-21 9:28 ` [PATCH 31/57] EDAC: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 32/57] i2c: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 33/57] infiniband: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 34/57] ISDN: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 36/57] drivers:misc:irq: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 37/57] mmc: irq: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 10:16 ` Guennadi Liakhovetski
2011-09-21 10:16 ` Guennadi Liakhovetski
2011-09-22 14:50 ` Kadiyala, Kishore
2011-09-22 14:50 ` Kadiyala, Kishore
2011-09-21 9:28 ` [PATCH 38/57] mtd: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 40/57] dirvers/parisc: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 10:07 ` James Bottomley
2011-09-21 10:07 ` James Bottomley
2011-09-21 12:07 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 41/57] pcmcia: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 42/57] sony-laptop:irq: " Yong Zhang
2011-09-21 9:28 ` [PATCH 43/57] PNP: irq: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 20:20 ` Bjorn Helgaas [this message]
2011-09-21 9:28 ` [PATCH 44/57] power_supply:irq: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 45/57] powerpc/ps3: irq: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 46/57] rtc: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:52 ` Wan ZongShun
2011-09-21 10:31 ` [rtc-linux] " Wolfram Sang
[not found] ` <1316597339-29861-1-git-send-email-yong.zhang0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-09-21 9:28 ` [PATCH 39/57] net: " Yong Zhang
2011-09-21 17:40 ` David Miller
2011-09-21 9:28 ` [PATCH 47/57] spi: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 48/57] TTY: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 49/57] video: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 20:22 ` David Brown
2011-09-21 9:28 ` [PATCH 50/57] w1: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 10:06 ` Evgeniy Polyakov
2011-09-21 10:06 ` Evgeniy Polyakov
2011-09-21 9:28 ` [PATCH 51/57] watchdog: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 52/57] xen: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 53/57] sound: " Yong Zhang
2011-09-21 9:52 ` Takashi Iwai
2011-09-21 9:55 ` Thomas Gleixner
2011-09-21 12:12 ` Yong Zhang
2011-09-22 9:42 ` Takashi Iwai
2011-09-21 12:10 ` Yong Zhang
2011-09-21 10:21 ` Ujfalusi, Peter
2011-09-21 9:28 ` [PATCH 54/57] Documentation: irq: Change documents related to IRQF_DISABLED Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-28 22:33 ` Bjorn Helgaas
2011-09-28 22:33 ` Bjorn Helgaas
2011-10-08 2:34 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 55/57] hexagon: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-21 15:35 ` Richard Kuo
2011-09-22 8:08 ` Yong Zhang
2011-09-21 9:28 ` [PATCH 56/57] hwmon: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
2011-09-21 19:07 ` Guenter Roeck
2011-09-21 9:28 ` [PATCH 57/57] genirq: " Yong Zhang
2011-09-21 9:28 ` Yong Zhang
[not found] ` <1316597339-29861-36-git-send-email-yong.zhang0@gmail.com>
2011-09-21 10:16 ` [PATCH 35/57] media: irq: " Guennadi Liakhovetski
2011-09-21 10:27 ` Wolfram Sang
2011-09-21 12:13 ` Yong Zhang
[not found] ` <4E79DF04.8060209@infradead.org>
2011-09-21 13:02 ` Thomas Gleixner
2011-09-21 12:27 ` [PATCH V1 00/57] Tree wide: cleanup IRQF_DISABLED Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAErSpo7VR8+AGgWABb2c0uU_bgcmg43dxui41JFzmCQPvC7bGg@mail.gmail.com \
--to=bhelgaas@google.com \
--cc=abelay@mit.edu \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).