From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ley Foon Tan Subject: Re: [PATCH v2 02/29] nios2: Kernel booting and initialization Date: Wed, 30 Jul 2014 18:58:16 +0800 Message-ID: References: <1405413956-2772-1-git-send-email-lftan@altera.com> <1405413956-2772-3-git-send-email-lftan@altera.com> <20140730091215.GE10301@distanz.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20140730091215.GE10301@distanz.ch> Sender: linux-doc-owner@vger.kernel.org To: Tobias Klauser Cc: Linux-Arch , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , Chung-Lin Tang List-Id: linux-arch.vger.kernel.org On Wed, Jul 30, 2014 at 5:12 PM, Tobias Klauser wrote: >> +/* >> + * Stack layout in 'ret_from_exception': >> + * >> + * This allows access to the syscall arguments in registers r4-r8 >> + * >> + * 0(sp) - r8 >> + * 4(sp) - r9 >> + * 8(sp) - r10 >> + * C(sp) - r11 >> + * 10(sp) - r12 >> + * 14(sp) - r13 >> + * 18(sp) - r14 >> + * 1C(sp) - r15 >> + * 20(sp) - r1 >> + * 24(sp) - r2 >> + * 28(sp) - r3 >> + * 2C(sp) - r4 >> + * 30(sp) - r5 >> + * 34(sp) - r6 >> + * 38(sp) - r7 >> + * 3C(sp) - orig_r2 >> + * 40(sp) - ra >> + * 44(sp) - fp >> + * 48(sp) - sp >> + * 4C(sp) - gp >> + * 50(sp) - estatus >> + * 54(sp) - status_extension (NOMMU only) >> + * 58(sp) - ea >> + */ > > status_extension no longer exists and orig_r7 is missing in the list > above. Since this corresponds to the order of struct pt_regs anyhow, > this comment seems rather pointless to me, so you might as well want to > remove it altogether. Okay, I will remove these comments. Thanks for review. Regards Ley Foon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f54.google.com ([209.85.192.54]:35840 "EHLO mail-qg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbaG3K6R (ORCPT ); Wed, 30 Jul 2014 06:58:17 -0400 MIME-Version: 1.0 In-Reply-To: <20140730091215.GE10301@distanz.ch> References: <1405413956-2772-1-git-send-email-lftan@altera.com> <1405413956-2772-3-git-send-email-lftan@altera.com> <20140730091215.GE10301@distanz.ch> Date: Wed, 30 Jul 2014 18:58:16 +0800 Message-ID: Subject: Re: [PATCH v2 02/29] nios2: Kernel booting and initialization From: Ley Foon Tan Content-Type: text/plain; charset=UTF-8 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Tobias Klauser Cc: Linux-Arch , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , Chung-Lin Tang Message-ID: <20140730105816.8yrdjv8Yo4qSGN3NlkBLywEUl5hlOTGkdlHNS9VwQF0@z> On Wed, Jul 30, 2014 at 5:12 PM, Tobias Klauser wrote: >> +/* >> + * Stack layout in 'ret_from_exception': >> + * >> + * This allows access to the syscall arguments in registers r4-r8 >> + * >> + * 0(sp) - r8 >> + * 4(sp) - r9 >> + * 8(sp) - r10 >> + * C(sp) - r11 >> + * 10(sp) - r12 >> + * 14(sp) - r13 >> + * 18(sp) - r14 >> + * 1C(sp) - r15 >> + * 20(sp) - r1 >> + * 24(sp) - r2 >> + * 28(sp) - r3 >> + * 2C(sp) - r4 >> + * 30(sp) - r5 >> + * 34(sp) - r6 >> + * 38(sp) - r7 >> + * 3C(sp) - orig_r2 >> + * 40(sp) - ra >> + * 44(sp) - fp >> + * 48(sp) - sp >> + * 4C(sp) - gp >> + * 50(sp) - estatus >> + * 54(sp) - status_extension (NOMMU only) >> + * 58(sp) - ea >> + */ > > status_extension no longer exists and orig_r7 is missing in the list > above. Since this corresponds to the order of struct pt_regs anyhow, > this comment seems rather pointless to me, so you might as well want to > remove it altogether. Okay, I will remove these comments. Thanks for review. Regards Ley Foon