From: Kees Cook <keescook@chromium.org> To: Laura Abbott <labbott@redhat.com> Cc: LKML <linux-kernel@vger.kernel.org>, Rik van Riel <riel@redhat.com>, Casey Schaufler <casey@schaufler-ca.com>, PaX Team <pageexec@freemail.hu>, Brad Spengler <spender@grsecurity.net>, Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Michael Ellerman <mpe@ellerman.id.au>, Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, "David S. Miller" <davem@davemloft.net>, "x86@kernel.org" <x86@kernel.org>, Christoph Lameter <cl@linux.com>, Pekka Enberg <penberg@kernel.org>, David Rientjes <rientjes@google.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Andrew Morton <akpm@linux-foundation.org>, Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>, Mathias Krause <minipli@googlemail.com>J Subject: Re: [PATCH] mm: Add is_migrate_cma_page Date: Tue, 19 Jul 2016 15:40:46 -0700 [thread overview] Message-ID: <CAGXu5jLRkRMutEauAg7dWV9CeDP3nzE4d71Fqt6H2d7OHTy71w@mail.gmail.com> (raw) In-Reply-To: <1468965604-25023-1-git-send-email-labbott@redhat.com> On Tue, Jul 19, 2016 at 3:00 PM, Laura Abbott <labbott@redhat.com> wrote: > Code such as hardened user copy[1] needs a way to tell if a > page is CMA or not. Add is_migrate_cma_page in a similar way > to is_migrate_isolate_page. > > [1]http://article.gmane.org/gmane.linux.kernel.mm/155238 > > Signed-off-by: Laura Abbott <labbott@redhat.com> Great, thanks! > --- > Here's an explicit patch, slightly different than what I posted before. It can > be kept separate or folded in as needed. Assuming there's no objection, I'll add it to my tree and use the new macro. -Kees > --- > include/linux/mmzone.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 02069c2..c8478b2 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -68,8 +68,10 @@ extern char * const migratetype_names[MIGRATE_TYPES]; > > #ifdef CONFIG_CMA > # define is_migrate_cma(migratetype) unlikely((migratetype) == MIGRATE_CMA) > +# define is_migrate_cma_page(_page) (get_pageblock_migratetype(_page) == MIGRATE_CMA) > #else > # define is_migrate_cma(migratetype) false > +# define is_migrate_cma_page(_page) false > #endif > > #define for_each_migratetype_order(order, type) \ > -- > 2.7.4 > -- Kees Cook Chrome OS & Brillo Security
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org> To: Laura Abbott <labbott@redhat.com> Cc: LKML <linux-kernel@vger.kernel.org>, Rik van Riel <riel@redhat.com>, Casey Schaufler <casey@schaufler-ca.com>, PaX Team <pageexec@freemail.hu>, Brad Spengler <spender@grsecurity.net>, Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Michael Ellerman <mpe@ellerman.id.au>, Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, "David S. Miller" <davem@davemloft.net>, "x86@kernel.org" <x86@kernel.org>, Christoph Lameter <cl@linux.com>, Pekka Enberg <penberg@kernel.org>, David Rientjes <rientjes@google.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Andrew Morton <akpm@linux-foundation.org>, Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>, Mathias Krause <minipli@googlemail.com>, Jan Kara <jack@suse.cz>, Vitaly Wool <vitalywool@gmail.com>, Andrea Arcangeli <aarcange@redhat.com>, Dmitry Vyukov <dvyukov@google.com>, Laura Abbott <labbott@fedoraproject.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, linux-ia64@vger.kernel.org, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, sparclinux <sparclinux@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>, "kernel-hardening@lists.openwall.com" <kernel-hardening@lists.openwall.com> Subject: Re: [PATCH] mm: Add is_migrate_cma_page Date: Tue, 19 Jul 2016 15:40:46 -0700 [thread overview] Message-ID: <CAGXu5jLRkRMutEauAg7dWV9CeDP3nzE4d71Fqt6H2d7OHTy71w@mail.gmail.com> (raw) Message-ID: <20160719224046.8WC2EzSGuUKO2b3gQ40Je2fiflLEcget2LyNx3oqsWU@z> (raw) In-Reply-To: <1468965604-25023-1-git-send-email-labbott@redhat.com> On Tue, Jul 19, 2016 at 3:00 PM, Laura Abbott <labbott@redhat.com> wrote: > Code such as hardened user copy[1] needs a way to tell if a > page is CMA or not. Add is_migrate_cma_page in a similar way > to is_migrate_isolate_page. > > [1]http://article.gmane.org/gmane.linux.kernel.mm/155238 > > Signed-off-by: Laura Abbott <labbott@redhat.com> Great, thanks! > --- > Here's an explicit patch, slightly different than what I posted before. It can > be kept separate or folded in as needed. Assuming there's no objection, I'll add it to my tree and use the new macro. -Kees > --- > include/linux/mmzone.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 02069c2..c8478b2 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -68,8 +68,10 @@ extern char * const migratetype_names[MIGRATE_TYPES]; > > #ifdef CONFIG_CMA > # define is_migrate_cma(migratetype) unlikely((migratetype) == MIGRATE_CMA) > +# define is_migrate_cma_page(_page) (get_pageblock_migratetype(_page) == MIGRATE_CMA) > #else > # define is_migrate_cma(migratetype) false > +# define is_migrate_cma_page(_page) false > #endif > > #define for_each_migratetype_order(order, type) \ > -- > 2.7.4 > -- Kees Cook Chrome OS & Brillo Security
next prev parent reply other threads:[~2016-07-19 22:40 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-15 21:44 [PATCH v3 00/11] mm: Hardened usercopy Kees Cook 2016-07-15 21:44 ` Kees Cook 2016-07-15 21:44 ` [PATCH v3 01/11] mm: Implement stack frame object validation Kees Cook 2016-07-15 21:44 ` Kees Cook 2016-07-15 21:44 ` [PATCH v3 02/11] mm: Hardened usercopy Kees Cook 2016-07-15 21:44 ` Kees Cook 2016-07-19 1:06 ` Laura Abbott 2016-07-19 1:06 ` Laura Abbott 2016-07-19 18:48 ` Kees Cook 2016-07-19 18:48 ` Kees Cook 2016-07-19 22:00 ` [PATCH] mm: Add is_migrate_cma_page Laura Abbott 2016-07-19 22:00 ` Laura Abbott 2016-07-19 22:40 ` Kees Cook [this message] 2016-07-19 22:40 ` Kees Cook 2016-07-20 10:24 ` [PATCH v3 02/11] mm: Hardened usercopy Balbir Singh 2016-07-20 10:24 ` Balbir Singh 2016-07-20 15:36 ` Laura Abbott 2016-07-20 15:36 ` Laura Abbott 2016-07-19 1:52 ` Laura Abbott 2016-07-19 1:52 ` Laura Abbott 2016-07-19 19:12 ` Kees Cook 2016-07-19 19:12 ` Kees Cook 2016-07-19 22:55 ` Kees Cook 2016-07-19 22:55 ` Kees Cook 2016-07-19 9:21 ` Christian Borntraeger 2016-07-19 9:21 ` Christian Borntraeger 2016-07-19 19:31 ` Kees Cook 2016-07-19 19:31 ` Kees Cook 2016-07-19 20:14 ` Christian Borntraeger 2016-07-19 20:14 ` Christian Borntraeger 2016-07-19 20:34 ` Kees Cook 2016-07-19 20:34 ` Kees Cook 2016-07-19 20:44 ` Christian Borntraeger 2016-07-19 20:44 ` Christian Borntraeger 2016-07-21 6:52 ` Michael Ellerman 2016-07-21 6:52 ` Michael Ellerman 2016-07-21 6:52 ` Michael Ellerman 2016-07-21 6:52 ` Michael Ellerman 2016-07-21 6:52 ` Michael Ellerman [not found] ` <5790711f.2350420a.b4287.2cc0SMTPIN_ADDED_BROKEN@mx.google.com> 2016-07-21 18:34 ` Kees Cook 2016-07-21 18:34 ` Kees Cook 2016-07-22 17:45 ` Josh Poimboeuf 2016-07-22 17:45 ` Josh Poimboeuf 2016-07-25 9:27 ` David Laight 2016-07-25 9:27 ` David Laight 2016-07-26 2:09 ` Michael Ellerman 2016-07-26 2:09 ` Michael Ellerman 2016-07-26 2:03 ` Michael Ellerman 2016-07-26 4:46 ` Kees Cook 2016-07-26 4:46 ` Kees Cook 2016-07-15 21:44 ` [PATCH v3 03/11] x86/uaccess: Enable hardened usercopy Kees Cook 2016-07-15 21:44 ` Kees Cook 2016-07-15 21:44 ` [PATCH v3 04/11] ARM: uaccess: " Kees Cook 2016-07-15 21:44 ` Kees Cook 2016-07-15 21:44 ` [PATCH v3 05/11] arm64/uaccess: " Kees Cook 2016-07-15 21:44 ` Kees Cook 2016-07-15 21:44 ` [PATCH v3 06/11] ia64/uaccess: " Kees Cook 2016-07-15 21:44 ` Kees Cook 2016-07-15 21:44 ` [PATCH v3 07/11] powerpc/uaccess: " Kees Cook 2016-07-15 21:44 ` Kees Cook 2016-07-15 21:44 ` [PATCH v3 08/11] sparc/uaccess: " Kees Cook 2016-07-15 21:44 ` Kees Cook 2016-07-15 21:44 ` [PATCH v3 09/11] s390/uaccess: " Kees Cook 2016-07-15 21:44 ` Kees Cook 2016-07-15 21:44 ` [PATCH v3 10/11] mm: SLAB hardened usercopy support Kees Cook 2016-07-15 21:44 ` Kees Cook 2016-07-15 21:44 ` [PATCH v3 11/11] mm: SLUB " Kees Cook 2016-07-15 21:44 ` Kees Cook 2016-07-18 8:26 ` [PATCH v3 00/11] mm: Hardened usercopy Balbir Singh 2016-07-18 8:26 ` Balbir Singh 2016-07-20 9:52 ` David Laight 2016-07-20 9:52 ` David Laight 2016-07-20 15:31 ` Kees Cook 2016-07-20 15:31 ` Kees Cook 2016-07-20 16:02 ` David Laight 2016-07-20 16:02 ` David Laight 2016-07-20 16:22 ` Rik van Riel 2016-07-20 16:22 ` Rik van Riel 2016-07-20 17:44 ` Kees Cook 2016-07-20 17:44 ` Kees Cook
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGXu5jLRkRMutEauAg7dWV9CeDP3nzE4d71Fqt6H2d7OHTy71w@mail.gmail.com \ --to=keescook@chromium.org \ --cc=akpm@linux-foundation.org \ --cc=ard.biesheuvel@linaro.org \ --cc=benh@kernel.crashing.org \ --cc=bp@suse.de \ --cc=casey@schaufler-ca.com \ --cc=catalin.marinas@arm.com \ --cc=cl@linux.com \ --cc=davem@davemloft.net \ --cc=fenghua.yu@intel.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=labbott@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=luto@kernel.org \ --cc=minipli@googlemail.com \ --cc=mpe@ellerman.id.au \ --cc=pageexec@freemail.hu \ --cc=penberg@kernel.org \ --cc=riel@redhat.com \ --cc=rientjes@google.com \ --cc=spender@grsecurity.net \ --cc=tony.luck@intel.com \ --cc=will.deacon@arm.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).