From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v18 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 Date: Tue, 3 Jul 2018 20:36:40 +0300 Message-ID: References: <20180622194752.11221-1-logang@deltatee.com> <20180622194752.11221-7-logang@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Fabio Estevam Cc: Logan Gunthorpe , Andrew Morton , linux-kernel , Linux-Arch , linux-ntb@googlegroups.com, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Arnd Bergmann , Greg Kroah-Hartman , =?UTF-8?Q?Horia_Geant=C4=83?= , Dan Douglass , Herbert Xu , "David S. Miller" List-Id: linux-arch.vger.kernel.org On Tue, Jul 3, 2018 at 6:31 PM, Fabio Estevam wrote: > Hi Logan, > > On Fri, Jun 22, 2018 at 4:47 PM, Logan Gunthorpe wr= ote: >> Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64 >> functions in non-64bit cases in favour of the new common >> io-64-nonatomic-lo-hi header. >> >> To be consistent with CAAM engine HW spec: in case of 64-bit registers, >> irrespective of device endianness, the lower address should be read from >> / written to first, followed by the upper address. Indeed the I/O >> accessors in CAAM driver currently don't follow the spec, however this >> is a good opportunity to fix the code. >> >> Signed-off-by: Logan Gunthorpe >> Reviewed-by: Horia Geant=C4=83 >> Reviewed-by: Andy Shevchenko >> Cc: Dan Douglass >> Cc: Herbert Xu >> Cc: "David S. Miller" > > This is now in linux-next as commit 46e4bf08f6388 and it breaks > booting imx6 (32-bit ARM): > Any ideas on how to fix this issue? Oops, first of all the header should be hi-lo instead of lo-hi. Does it fix it? Otherwise I didn't (briefly) see what can be the issue. --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f195.google.com ([209.85.217.195]:46496 "EHLO mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934141AbeGCRgm (ORCPT ); Tue, 3 Jul 2018 13:36:42 -0400 MIME-Version: 1.0 In-Reply-To: References: <20180622194752.11221-1-logang@deltatee.com> <20180622194752.11221-7-logang@deltatee.com> From: Andy Shevchenko Date: Tue, 3 Jul 2018 20:36:40 +0300 Message-ID: Subject: Re: [PATCH v18 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-arch-owner@vger.kernel.org List-ID: To: Fabio Estevam Cc: Logan Gunthorpe , Andrew Morton , linux-kernel , Linux-Arch , linux-ntb@googlegroups.com, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Arnd Bergmann , Greg Kroah-Hartman , =?UTF-8?Q?Horia_Geant=C4=83?= , Dan Douglass , Herbert Xu , "David S. Miller" Message-ID: <20180703173640.p0UEyiAgNk_Cwg3l9AeusYcQ3fUdN_7OOiII5XoZpog@z> On Tue, Jul 3, 2018 at 6:31 PM, Fabio Estevam wrote: > Hi Logan, > > On Fri, Jun 22, 2018 at 4:47 PM, Logan Gunthorpe wr= ote: >> Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64 >> functions in non-64bit cases in favour of the new common >> io-64-nonatomic-lo-hi header. >> >> To be consistent with CAAM engine HW spec: in case of 64-bit registers, >> irrespective of device endianness, the lower address should be read from >> / written to first, followed by the upper address. Indeed the I/O >> accessors in CAAM driver currently don't follow the spec, however this >> is a good opportunity to fix the code. >> >> Signed-off-by: Logan Gunthorpe >> Reviewed-by: Horia Geant=C4=83 >> Reviewed-by: Andy Shevchenko >> Cc: Dan Douglass >> Cc: Herbert Xu >> Cc: "David S. Miller" > > This is now in linux-next as commit 46e4bf08f6388 and it breaks > booting imx6 (32-bit ARM): > Any ideas on how to fix this issue? Oops, first of all the header should be hi-lo instead of lo-hi. Does it fix it? Otherwise I didn't (briefly) see what can be the issue. --=20 With Best Regards, Andy Shevchenko