From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v18 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 Date: Wed, 4 Jul 2018 20:16:01 +0300 Message-ID: References: <20180622194752.11221-1-logang@deltatee.com> <13ea3f97-4a33-3a24-1b7e-b819be73d867@deltatee.com> <6e5224b9-343f-990c-19bd-fe37c6fbdc9b@deltatee.com> <7ddda181-6337-32cc-7a0d-43fc6a7ba78b@deltatee.com> <991b2298-bb3f-dad3-c93b-b43ee5f372de@deltatee.com> <55236e2b-a2a5-493a-5696-19c5926885b3@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Logan Gunthorpe Cc: Fabio Estevam , Horia Geanta , Aymen Sghaier , Andrew Morton , linux-kernel , Linux-Arch , "linux-ntb@googlegroups.com" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Arnd Bergmann , Greg Kroah-Hartman , Dan Douglass , Herbert Xu , "David S. Miller" List-Id: linux-arch.vger.kernel.org On Wed, Jul 4, 2018 at 8:13 PM, Logan Gunthorpe wrote: > On 7/4/2018 11:10 AM, Andy Shevchenko wrote: >> We have an iDMA 32-bit hardware (see drivers/dma/dw/) which has an >> extension 64-bit registers where only one of them has a specific bit >> to "commit" the changes written to all of them. And by some very >> unknown reason that bit is in lo part which automatically means we >> must to write it last. > > And it supports both BE and LE? And in both cases it's the lo part? It's only LE for now. P.S. If you more interested in code in kernel look for idma32_fifo_partition() (While the bit is set in each of 32-bit part, it's actually present in only one place) -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f193.google.com ([209.85.217.193]:33269 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752251AbeGDRQD (ORCPT ); Wed, 4 Jul 2018 13:16:03 -0400 MIME-Version: 1.0 In-Reply-To: References: <20180622194752.11221-1-logang@deltatee.com> <13ea3f97-4a33-3a24-1b7e-b819be73d867@deltatee.com> <6e5224b9-343f-990c-19bd-fe37c6fbdc9b@deltatee.com> <7ddda181-6337-32cc-7a0d-43fc6a7ba78b@deltatee.com> <991b2298-bb3f-dad3-c93b-b43ee5f372de@deltatee.com> <55236e2b-a2a5-493a-5696-19c5926885b3@deltatee.com> From: Andy Shevchenko Date: Wed, 4 Jul 2018 20:16:01 +0300 Message-ID: Subject: Re: [PATCH v18 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Logan Gunthorpe Cc: Fabio Estevam , Horia Geanta , Aymen Sghaier , Andrew Morton , linux-kernel , Linux-Arch , "linux-ntb@googlegroups.com" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Arnd Bergmann , Greg Kroah-Hartman , Dan Douglass , Herbert Xu , "David S. Miller" Message-ID: <20180704171601.QC_kMRGwR9dCnbgsP0fuyztFauEOwmJsoyqKLvjXjhw@z> On Wed, Jul 4, 2018 at 8:13 PM, Logan Gunthorpe wrote: > On 7/4/2018 11:10 AM, Andy Shevchenko wrote: >> We have an iDMA 32-bit hardware (see drivers/dma/dw/) which has an >> extension 64-bit registers where only one of them has a specific bit >> to "commit" the changes written to all of them. And by some very >> unknown reason that bit is in lo part which automatically means we >> must to write it last. > > And it supports both BE and LE? And in both cases it's the lo part? It's only LE for now. P.S. If you more interested in code in kernel look for idma32_fifo_partition() (While the bit is set in each of 32-bit part, it's actually present in only one place) -- With Best Regards, Andy Shevchenko