From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v18 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 Date: Tue, 3 Jul 2018 22:58:52 +0300 Message-ID: References: <20180622194752.11221-1-logang@deltatee.com> <20180622194752.11221-7-logang@deltatee.com> <13ea3f97-4a33-3a24-1b7e-b819be73d867@deltatee.com> <6e5224b9-343f-990c-19bd-fe37c6fbdc9b@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Fabio Estevam Cc: Logan Gunthorpe , Andrew Morton , linux-kernel , Linux-Arch , linux-ntb@googlegroups.com, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Arnd Bergmann , Greg Kroah-Hartman , =?UTF-8?Q?Horia_Geant=C4=83?= , Dan Douglass , Herbert Xu , "David S. Miller" List-Id: linux-arch.vger.kernel.org On Tue, Jul 3, 2018 at 10:40 PM, Fabio Estevam wrote: > On Tue, Jul 3, 2018 at 3:47 PM, Logan Gunthorpe wrote: > >> Ok, I'm at a bit of a loss... When I look at the assembly before and >> after the patch, it looks pretty much the same. Additionally, the >> function where the undefined exception occurs (caam_jr_interrupt()) >> doesn't make any use of wr_reg64 or rd_reg64 which is the only thing the >> patch changes... >> >> Also, it looks like the nonatomic headers are doing what they are >> supposed to on this arch and generating two 32-bit ios and not a 64 bit one. >> >> So I have no idea what's going on here... Are we sure this is the patch >> causing the problem? Did you bisect? > > Yes, I am sure that 46e4bf08f6388ba748 is the one causing the kernel boot issue. > > If I revert 46e4bf08f6388ba748 in linux-next then I can boot mx6 just fine. > Interesting... > kernelci.org reports also confirm the same: > > https://storage.kernelci.org/next/master/next-20180629/arm/imx_v6_v7_defconfig/lab-baylibre-seattle/boot-imx6q-wandboard.html By the way, is there any URL which contains dmesg out of kernel with this commit reverted? (It would be even better if we would have 'ignore_loglevel ' there when CONFIG_CRYPTO_DEV_FSL_CAAM_DEBUG=y) -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f195.google.com ([209.85.217.195]:39254 "EHLO mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753048AbeGCT6y (ORCPT ); Tue, 3 Jul 2018 15:58:54 -0400 MIME-Version: 1.0 In-Reply-To: References: <20180622194752.11221-1-logang@deltatee.com> <20180622194752.11221-7-logang@deltatee.com> <13ea3f97-4a33-3a24-1b7e-b819be73d867@deltatee.com> <6e5224b9-343f-990c-19bd-fe37c6fbdc9b@deltatee.com> From: Andy Shevchenko Date: Tue, 3 Jul 2018 22:58:52 +0300 Message-ID: Subject: Re: [PATCH v18 6/7] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64 Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Fabio Estevam Cc: Logan Gunthorpe , Andrew Morton , linux-kernel , Linux-Arch , linux-ntb@googlegroups.com, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Arnd Bergmann , Greg Kroah-Hartman , =?UTF-8?Q?Horia_Geant=C4=83?= , Dan Douglass , Herbert Xu , "David S. Miller" Message-ID: <20180703195852.FH2o1jP1hpO7QmAtljU-5fijXtsVTjAN3G5KV73gqA4@z> On Tue, Jul 3, 2018 at 10:40 PM, Fabio Estevam wrote: > On Tue, Jul 3, 2018 at 3:47 PM, Logan Gunthorpe wrote: > >> Ok, I'm at a bit of a loss... When I look at the assembly before and >> after the patch, it looks pretty much the same. Additionally, the >> function where the undefined exception occurs (caam_jr_interrupt()) >> doesn't make any use of wr_reg64 or rd_reg64 which is the only thing the >> patch changes... >> >> Also, it looks like the nonatomic headers are doing what they are >> supposed to on this arch and generating two 32-bit ios and not a 64 bit one. >> >> So I have no idea what's going on here... Are we sure this is the patch >> causing the problem? Did you bisect? > > Yes, I am sure that 46e4bf08f6388ba748 is the one causing the kernel boot issue. > > If I revert 46e4bf08f6388ba748 in linux-next then I can boot mx6 just fine. > Interesting... > kernelci.org reports also confirm the same: > > https://storage.kernelci.org/next/master/next-20180629/arm/imx_v6_v7_defconfig/lab-baylibre-seattle/boot-imx6q-wandboard.html By the way, is there any URL which contains dmesg out of kernel with this commit reverted? (It would be even better if we would have 'ignore_loglevel ' there when CONFIG_CRYPTO_DEV_FSL_CAAM_DEBUG=y) -- With Best Regards, Andy Shevchenko