From: Guo Ren <guoren@kernel.org>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: arnd@arndb.de, palmer@rivosinc.com, tglx@linutronix.de,
peterz@infradead.org, luto@kernel.org,
conor.dooley@microchip.com, heiko@sntech.de, jszhang@kernel.org,
lazyparser@gmail.com, falcon@tinylab.org, chenhuacai@kernel.org,
apatel@ventanamicro.com, atishp@atishpatra.org,
palmer@dabbelt.com, paul.walmsley@sifive.com,
mark.rutland@arm.com, zouyipeng@huawei.com,
bigeasy@linutronix.de, David.Laight@aculab.com,
chenzhongjin@huawei.com, greentime.hu@sifive.com,
andy.chiu@sifive.com, ben@decadent.org.uk,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH -next V10 05/10] riscv: entry: Remove extra level wrappers of trace_hardirqs_{on,off}
Date: Fri, 9 Dec 2022 10:01:21 +0800 [thread overview]
Message-ID: <CAJF2gTR3Eebw7juPiW4zA122qQKJjw4+7eC54vHgTDpctqJopA@mail.gmail.com> (raw)
In-Reply-To: <87sfhqw6ge.fsf@all.your.base.are.belong.to.us>
On Thu, Dec 8, 2022 at 6:11 PM Björn Töpel <bjorn@kernel.org> wrote:
>
> guoren@kernel.org writes:
>
> > From: Jisheng Zhang <jszhang@kernel.org>
> >
> > Since riscv is converted to generic entry, there's no need for the
> > extra wrappers of trace_hardirqs_{on,off}.
> >
> > Tested with llvm + irqsoff.
>
> What does this mean?
It's just a tested environment description. This is covered by the
generic entry. This patch removes unused code.
I would remove the "Tested with llvm + irqsoff." sentence; it's unnecessary.
>
>
> Björn
--
Best Regards
Guo Ren
next prev parent reply other threads:[~2022-12-09 2:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 2:58 [PATCH -next V10 00/10] riscv: Add GENERIC_ENTRY support and related features guoren
2022-12-08 2:58 ` [PATCH -next V10 01/10] compiler_types.h: Add __noinstr_section() for noinstr guoren
2022-12-08 2:58 ` [PATCH -next V10 02/10] riscv: ptrace: Remove duplicate operation guoren
2022-12-08 2:58 ` [PATCH -next V10 03/10] riscv: entry: Add noinstr to prevent instrumentation inserted guoren
2022-12-08 2:58 ` [PATCH -next V10 04/10] riscv: entry: Convert to generic entry guoren
2022-12-08 10:11 ` Björn Töpel
2022-12-10 10:27 ` Guo Ren
2022-12-10 16:05 ` Björn Töpel
2022-12-08 2:58 ` [PATCH -next V10 05/10] riscv: entry: Remove extra level wrappers of trace_hardirqs_{on,off} guoren
2022-12-08 10:11 ` Björn Töpel
2022-12-09 2:01 ` Guo Ren [this message]
2022-12-08 2:58 ` [PATCH -next V10 06/10] riscv: entry: Consolidate ret_from_kernel_thread into ret_from_fork guoren
2022-12-08 10:12 ` Björn Töpel
2022-12-09 2:01 ` Guo Ren
2022-12-08 2:58 ` [PATCH -next V10 07/10] riscv: entry: Consolidate general regs saving/restoring guoren
2022-12-08 2:58 ` [PATCH -next V10 08/10] riscv: stack: Support HAVE_IRQ_EXIT_ON_IRQ_STACK guoren
2022-12-08 10:12 ` Björn Töpel
2022-12-09 2:06 ` Guo Ren
2022-12-08 2:58 ` [PATCH -next V10 09/10] riscv: stack: Support HAVE_SOFTIRQ_ON_OWN_STACK guoren
2022-12-08 10:12 ` Björn Töpel
2022-12-09 2:09 ` Guo Ren
2022-12-09 7:49 ` Björn Töpel
2022-12-10 10:21 ` Guo Ren
2022-12-08 2:58 ` [PATCH -next V10 10/10] riscv: stack: Add config of thread stack size guoren
2022-12-08 10:12 ` Björn Töpel
2022-12-09 2:11 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJF2gTR3Eebw7juPiW4zA122qQKJjw4+7eC54vHgTDpctqJopA@mail.gmail.com \
--to=guoren@kernel.org \
--cc=David.Laight@aculab.com \
--cc=andy.chiu@sifive.com \
--cc=apatel@ventanamicro.com \
--cc=arnd@arndb.de \
--cc=atishp@atishpatra.org \
--cc=ben@decadent.org.uk \
--cc=bigeasy@linutronix.de \
--cc=bjorn@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenzhongjin@huawei.com \
--cc=conor.dooley@microchip.com \
--cc=falcon@tinylab.org \
--cc=greentime.hu@sifive.com \
--cc=heiko@sntech.de \
--cc=jszhang@kernel.org \
--cc=lazyparser@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=zouyipeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).