From: Guo Ren <guoren@kernel.org>
To: Andy Chiu <andy.chiu@sifive.com>
Cc: arnd@arndb.de, palmer@rivosinc.com, rostedt@goodmis.org,
greentime.hu@sifive.com, zong.li@sifive.com, jrtc27@jrtc27.com,
mingo@redhat.com, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/3] riscv: ftrace: Fixup panic by disabling preemption
Date: Sat, 17 Sep 2022 18:46:24 +0800 [thread overview]
Message-ID: <CAJF2gTT-TOdoGuFdbR8Xwmfur-LNOCUq_sThr9ZpJeMKxudH1A@mail.gmail.com> (raw)
In-Reply-To: <CABgGipWdm+-pOrj-ROR8fsVO7JEr4m64z7+zNW1_NszW74e5SA@mail.gmail.com>
Thanks! I would add your Signed-off-by: Andy Chiu
<andy.chiu@sifive.com> as the first author, next.
On Sat, Sep 17, 2022 at 9:32 AM Andy Chiu <andy.chiu@sifive.com> wrote:
>
> Yes, by disabling preemption and ensuring all sub-functions called by
> the busy waiting loop of stop_machine, which happens to be true on
> non-preemptive kernels, solve the problem from the original
> implementation.
>
> Andy Chiu <andy.chiu@sifive.com>
--
Best Regards
Guo Ren
next prev parent reply other threads:[~2022-09-17 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 10:38 [PATCH 0/3] riscv: ftrace: Fixup ftrace detour code guoren
2022-09-16 10:38 ` [PATCH 1/3] riscv: ftrace: Fixup panic by disabling preemption guoren
2022-09-17 1:32 ` Andy Chiu
2022-09-17 10:46 ` Guo Ren [this message]
2022-09-16 10:38 ` [PATCH 2/3] riscv: ftrace: Remove wasted nops for !RISCV_ISA_C guoren
2022-09-16 10:38 ` [PATCH 3/3] riscv: ftrace: Reduce the detour code size to half guoren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJF2gTT-TOdoGuFdbR8Xwmfur-LNOCUq_sThr9ZpJeMKxudH1A@mail.gmail.com \
--to=guoren@kernel.org \
--cc=andy.chiu@sifive.com \
--cc=arnd@arndb.de \
--cc=greentime.hu@sifive.com \
--cc=jrtc27@jrtc27.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mingo@redhat.com \
--cc=palmer@rivosinc.com \
--cc=rostedt@goodmis.org \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).