From: Jassi Brar <jaswinder.singh@linaro.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Alessandro Rubini <rubini@gnudd.com>,
linux-arch@vger.kernel.org, giancarlo.asnaghi@st.com,
arnd@arndb.de, gregkh@linuxfoundation.org, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
hpa@zytor.com, linux-arm-kernel@lists.infradead.org,
alan@linux.intel.com
Subject: Re: [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11
Date: Sun, 1 Jul 2012 17:28:16 +0530 [thread overview]
Message-ID: <CAJe_ZheynaBcMiQiwnxPrEoGxhhAJyHDD6VM-uDEN_5Yg1vVpA@mail.gmail.com> (raw)
In-Reply-To: <20120701105934.GD16319@n2100.arm.linux.org.uk>
On 1 July 2012 16:29, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Sun, Jul 01, 2012 at 12:44:01PM +0200, Alessandro Rubini wrote:
>> How should I address the problem? (original code, published on
>> sourceforge was simply replicating a number of amba drivers into pci
>> drivers, but I don't think massive code duplication is ever sensible,
>> thus I preferred to reuse the existing drivers).
>
> I think the answer is... those primecell drivers need fixing in some way.
> Re-defining CS, DS and ES in drivers is rather silly given that they're
> x86 segment register names - so if PL330 can be fixed to make its names
> more specific, that sorts it out.
>
I am OK prefixing the regs with PL330_ or somesuch.
The CS, DS and ES regs were named so as to match exactly the
terminology of the PL330 manual. So apparently even the ARM Ltd didn't
imagine ARM and X86 galaxies colliding so soon :)
Regards.
next prev parent reply other threads:[~2012-07-01 11:58 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1338222460.git.rubini@gnudd.com>
2012-05-28 16:37 ` [PATCH V2 1/6] sizes.h: move from asm-generic to <linux/sizes.h> Alessandro Rubini
2012-05-28 16:37 ` Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 2/6] amba: use the new linux/sizes.h Alessandro Rubini
2012-05-28 16:37 ` Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 3/6] ARM: " Alessandro Rubini
2012-05-28 16:37 ` Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 4/6] serial: " Alessandro Rubini
2012-05-28 16:37 ` [PATCH V2 5/6] x86: add CONFIG_ARM_AMBA, selected by STA2X11 Alessandro Rubini
2012-05-28 16:37 ` Alessandro Rubini
2012-06-28 20:06 ` H. Peter Anvin
2012-07-01 10:44 ` Alessandro Rubini
2012-07-01 10:59 ` Russell King - ARM Linux
2012-07-01 10:59 ` Russell King - ARM Linux
2012-07-01 11:58 ` Jassi Brar [this message]
2012-07-01 11:58 ` Jassi Brar
2012-07-01 12:10 ` Russell King - ARM Linux
2012-07-01 13:11 ` Jassi Brar
2012-07-01 11:04 ` Alessandro Rubini
2012-07-01 11:11 ` Russell King - ARM Linux
2012-07-01 14:13 ` H. Peter Anvin
2012-07-02 16:58 ` Arnd Bergmann
2012-07-02 18:05 ` Mark Brown
2012-07-02 18:07 ` H. Peter Anvin
2012-07-02 18:07 ` H. Peter Anvin
2012-07-02 18:33 ` Mark Brown
2012-07-02 18:33 ` Mark Brown
2012-07-02 19:41 ` H. Peter Anvin
2012-07-03 11:05 ` Mark Brown
2012-07-03 13:00 ` Alessandro Rubini
2012-07-03 13:19 ` Arnd Bergmann
2012-07-03 19:34 ` Russell King - ARM Linux
2012-07-03 19:34 ` Russell King - ARM Linux
2012-08-05 20:28 ` Linus Walleij
2012-08-07 10:06 ` Kukjin Kim
2012-07-03 13:26 ` Alessandro Rubini
2012-07-03 19:46 ` Russell King - ARM Linux
2012-07-03 19:46 ` Russell King - ARM Linux
2012-05-28 16:38 ` [PATCH V2 6/6] drivers/amba: add support for a PCI bridge Alessandro Rubini
2012-05-28 16:38 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJe_ZheynaBcMiQiwnxPrEoGxhhAJyHDD6VM-uDEN_5Yg1vVpA@mail.gmail.com \
--to=jaswinder.singh@linaro.org \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=giancarlo.asnaghi@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rubini@gnudd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).