From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB9AC433FE for ; Tue, 31 May 2022 20:41:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240376AbiEaUlV (ORCPT ); Tue, 31 May 2022 16:41:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237511AbiEaUlU (ORCPT ); Tue, 31 May 2022 16:41:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EDAB2A7; Tue, 31 May 2022 13:41:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C9EBB80FB3; Tue, 31 May 2022 20:41:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EB82C341C6; Tue, 31 May 2022 20:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654029676; bh=pJkA28MYtLxRIxdBNIGyaIzZMHuixKblkEVeOXjCztQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=VWcfGezUwRb/Zeq9RJ8smztfHBwzyZ1MsKlThN8toiLSmD4YS2YZDI6zDF+nAytnF WayKbiamfjtPPDyhJAZmH6zzZUDLkGKX9QihnTbUQEDkSWMtvkztUHmBwSYWCGozg3 K36CM/wriFIpVrmtk6+QnmNan8mZs5G+SoHv2jZ3SNDJQ3ikRNGKJIZ4SGFu8sUHFe pASO8hYwSZ+HCLZmxCZCy+i1h5uvPjW2nUYF/RsHvDRY2CImnb9KSORB4t/3AvhtPG VyOLv69ZL/kplDjJCqp4HG4pBmdmUNzEZJgmb/cnwtQSGNLzSj5YQa/bOPud1qtw/w bnLvmGyk3nGmg== Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-2f83983782fso152892057b3.6; Tue, 31 May 2022 13:41:16 -0700 (PDT) X-Gm-Message-State: AOAM532dObBDBH2J2JR9TBO36aLggL9p+w435Q6W0VRL2wDwgJaEP/Zb Mxpw7YQNgDUaj9q9DC+YfOXKPECjlwL79aMIwQM= X-Google-Smtp-Source: ABdhPJxXa52JB96dEGmMMbjyWZgKzuSGhmh2BklKLjs5FBCGtGzMkaptgm5Aoiqqleh0v4fR3TR1BO1ls94gmjh98Ck= X-Received: by 2002:a81:ad7:0:b0:2e6:84de:3223 with SMTP id 206-20020a810ad7000000b002e684de3223mr67745984ywk.209.1654029675316; Tue, 31 May 2022 13:41:15 -0700 (PDT) MIME-Version: 1.0 References: <358025d1-28e6-708b-d23d-3f22ae12a800@xen0n.name> In-Reply-To: From: Arnd Bergmann Date: Tue, 31 May 2022 22:40:58 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [musl] Re: [GIT PULL] asm-generic changes for 5.19 To: Huacai Chen Cc: musl@lists.openwall.com, WANG Xuerui , Linus Torvalds , linux-arch , GNU C Library , Yoshinori Sato , Peter Zijlstra , Marc Zyngier , Masahiro Yamada , Linux Kernel Mailing List , Jiaxun Yang , ACPI Devel Maling List , Jianmin Lv , linux-pci , Ard Biesheuvel , Huacai Chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Tue, May 31, 2022 at 10:07 PM Arnd Bergmann wrote: > > On Tue, May 31, 2022 at 6:01 PM Huacai Chen wrote: > > On Tue, May 31, 2022 at 7:15 PM Arnd Bergmann wrote: > > > On Tue, May 31, 2022 at 10:17 AM Huacai Chen wrote: > > > https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/log/?h=loongarch-next > > has been updated. Now this branch droped irqchip drivers and pci > > drivers. But the existing irqchip drivers need some small adjustment > > to avoid build errors [1], and I hope Marc can give an Acked-by. > > Ok, glad you got that working. > >From an allmodconfig build, I see two more things that could be addressed first: drivers/pci/probe.c: In function 'pci_scan_bridge_extend': drivers/pci/probe.c:1298:44: error: implicit declaration of function 'pcibios_assign_all_busses' [-Werror=implicit-function-declaration] 1298 | if ((secondary || subordinate) && !pcibios_assign_all_busses() && | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/pci/setup-res.c: In function '__pci_assign_resource': drivers/pci/setup-res.c:257:46: error: 'PCIBIOS_MIN_IO' undeclared (first use in this function) 257 | min = (res->flags & IORESOURCE_IO) ? PCIBIOS_MIN_IO : PCIBIOS_MIN_MEM; | ^~~~~~~~~~~~~~ drivers/pci/setup-res.c:257:46: note: each undeclared identifier is reported only once for each function it appears in drivers/pci/setup-res.c:257:63: error: 'PCIBIOS_MIN_MEM' undeclared (first use in this function) 257 | min = (res->flags & IORESOURCE_IO) ? PCIBIOS_MIN_IO : PCIBIOS_MIN_MEM; | ^~~~~~~~~~~~~~~ drivers/pci/quirks.c: In function 'quirk_isa_dma_hangs': drivers/pci/quirks.c:252:14: error: 'isa_dma_bridge_buggy' undeclared (first use in this function) 252 | if (!isa_dma_bridge_buggy) { | ^~~~~~~~~~~~~~~~~~~~ I think you accidentally dropped the asm/pci.h header, so adding that one back should make it build again. lib/test_printf.c:215: warning: "PTR" redefined 215 | #define PTR ((void *)0xffff0123456789abUL) | In file included from /git/arm-soc/arch/loongarch/include/asm/vdso/vdso.h:9, from /git/arm-soc/arch/loongarch/include/asm/vdso/gettimeofday.h:13, from /git/arm-soc/include/vdso/datapage.h:137, from /git/arm-soc/arch/loongarch/include/asm/vdso.h:11, from /git/arm-soc/arch/loongarch/include/asm/elf.h:13, from /git/arm-soc/include/linux/elf.h:6, from /git/arm-soc/include/linux/module.h:19, from /git/arm-soc/lib/test_printf.c:10: /git/arm-soc/arch/loongarch/include/asm/asm.h:182: note: this is the location of the previous definition 182 | #define PTR .dword | Not sure what the best fix is for this, maybe the contents of asm/asm.h could just be hidden in an "#idef __ASSEMBLER__" check. This can be a follow-up patch when the branch is merged. Arnd