From: Arnd Bergmann <arnd@arndb.de>
To: Guo Ren <ren_guo@c-sky.com>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Jason Cooper <jason@lakedaemon.net>,
c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com,
thomas.petazzoni@bootlin.com, wbx@uclibc-ng.org
Subject: Re: [PATCH 12/19] csky: Debug and Ptrace GDB
Date: Mon, 26 Mar 2018 15:06:21 +0200 [thread overview]
Message-ID: <CAK8P3a276dfzFE8kxYFx_RgJWx31px6M24tf+h7eRowma69Fhg@mail.gmail.com> (raw)
In-Reply-To: <31d854396de0d279cdd3bc621806362e79cca60e.1521399976.git.ren_guo@c-sky.com>
On Sun, Mar 18, 2018 at 8:51 PM, Guo Ren <ren_guo@c-sky.com> wrote:
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> + */
> +long arch_ptrace(struct task_struct *child, long request, unsigned long addr,
> + unsigned long data)
> +{
> + unsigned long tmp = 0, ret = 0;
> + int i;
> +
> + switch (request) {
> + /* read the word at location addr in the USER area. */
> + case PTRACE_PEEKUSR:
> +
> + case PTRACE_POKEUSR: /* write the word at location addr in the USER area */
> + case PTRACE_GETREGS: /* Get all gp regs from the child. */
> + case PTRACE_SETREGS: /* Set all gp regs in the child. */
> + for (i = 0; i <= CSKY_GREG_NUM; i++) {
> + ret = get_user(tmp, (unsigned long *)data);
I think all of these should use the regset code like arch/riscv/kernel/ptrace.c
does.
Arnd
next prev parent reply other threads:[~2018-03-26 13:06 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 19:51 [PATCH 00/19] C-SKY(csky) Linux Kernel Port Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-18 19:51 ` [PATCH 01/19] csky: Kernel booting Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-18 19:51 ` [PATCH 02/19] csky: Exception handling and syscall Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-19 1:48 ` Mark Rutland
2018-03-19 1:48 ` Mark Rutland
2018-03-19 6:47 ` Guo Ren
2018-03-19 6:47 ` Guo Ren
2018-03-19 8:50 ` Dominik Brodowski
2018-03-19 8:50 ` Dominik Brodowski
2018-03-19 11:03 ` Guo Ren
2018-03-19 11:03 ` Guo Ren
2018-03-18 19:51 ` [PATCH 03/19] csky: Cache and TLB routines Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-18 19:51 ` [PATCH 04/19] csky: MMU and page talbe management Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-18 19:51 ` [PATCH 05/19] csky: Process management Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-18 19:51 ` [PATCH 06/19] csky: IRQ handling Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-19 13:16 ` Thomas Gleixner
2018-03-19 13:16 ` Thomas Gleixner
2018-03-20 2:06 ` Guo Ren
2018-03-20 2:06 ` Guo Ren
2018-03-18 19:51 ` [PATCH 07/19] csky: Atomic operations Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-18 19:51 ` [PATCH 08/19] csky: ELF and module probe Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-18 19:51 ` [PATCH 09/19] csky: VDSO and rt_sigreturn Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-18 19:51 ` [PATCH 10/19] csky: Signal handling Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-26 13:04 ` Arnd Bergmann
2018-03-26 13:04 ` Arnd Bergmann
2018-03-27 2:41 ` Guo Ren
2018-03-27 2:41 ` Guo Ren
2018-03-18 19:51 ` [PATCH 11/19] csky: Library functions Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-18 19:51 ` [PATCH 12/19] csky: Debug and Ptrace GDB Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-26 13:06 ` Arnd Bergmann [this message]
2018-03-26 13:06 ` Arnd Bergmann
2018-03-18 19:51 ` [PATCH 13/19] csky: User access Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-18 19:51 ` [PATCH 14/19] csky: Misc headers Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-19 16:11 ` Arnd Bergmann
2018-03-19 16:11 ` Arnd Bergmann
2018-03-20 3:36 ` Guo Ren
2018-03-20 3:36 ` Guo Ren
2018-03-20 7:54 ` Arnd Bergmann
2018-03-20 7:54 ` Arnd Bergmann
2018-03-20 13:22 ` Guo Ren
2018-03-20 13:22 ` Guo Ren
2018-03-18 19:51 ` [PATCH 15/19] csky: Build infrastructure Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-19 15:45 ` Arnd Bergmann
2018-03-19 15:45 ` Arnd Bergmann
2018-03-20 13:13 ` Guo Ren
2018-03-20 13:13 ` Guo Ren
2018-03-21 7:36 ` Arnd Bergmann
2018-03-21 7:36 ` Arnd Bergmann
2018-03-21 12:41 ` Guo Ren
2018-03-21 12:41 ` Guo Ren
2018-03-26 13:00 ` Arnd Bergmann
2018-03-26 13:00 ` Arnd Bergmann
2018-03-27 2:39 ` Guo Ren
2018-03-27 2:39 ` Guo Ren
2018-03-27 7:38 ` Arnd Bergmann
2018-03-27 7:38 ` Arnd Bergmann
2018-03-28 3:49 ` Guo Ren
2018-03-28 3:49 ` Guo Ren
2018-03-28 7:40 ` Arnd Bergmann
2018-03-28 7:40 ` Arnd Bergmann
2018-03-28 8:04 ` Guo Ren
2018-03-28 8:04 ` Guo Ren
2018-03-18 19:51 ` [PATCH 16/19] csky: Device tree Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-19 15:28 ` Arnd Bergmann
2018-03-19 15:28 ` Arnd Bergmann
2018-03-20 13:55 ` Guo Ren
2018-03-20 13:55 ` Guo Ren
2018-03-18 19:51 ` [PATCH 17/19] csky: defconfig Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-26 13:16 ` Arnd Bergmann
2018-03-26 13:16 ` Arnd Bergmann
2018-03-27 2:21 ` Guo Ren
2018-03-27 2:21 ` Guo Ren
2018-03-27 7:48 ` Arnd Bergmann
2018-03-27 7:48 ` Arnd Bergmann
2018-03-28 3:59 ` Guo Ren
2018-03-28 3:59 ` Guo Ren
2018-03-18 19:51 ` [PATCH 18/19] clocksource: add timer-nationalchip.c Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-18 22:07 ` Daniel Lezcano
2018-03-18 22:07 ` Daniel Lezcano
2018-03-19 6:59 ` Guo Ren
2018-03-19 6:59 ` Guo Ren
2018-03-19 4:15 ` Mark Rutland
2018-03-19 4:15 ` Mark Rutland
2018-03-19 7:03 ` Guo Ren
2018-03-19 7:03 ` Guo Ren
2018-03-18 19:51 ` [PATCH 19/19] irqchip: add irq-nationalchip.c and irq-csky.c Guo Ren
2018-03-18 19:51 ` Guo Ren
2018-03-19 4:26 ` Mark Rutland
2018-03-19 4:26 ` Mark Rutland
2018-03-19 7:08 ` Guo Ren
2018-03-19 7:08 ` Guo Ren
2018-03-19 13:30 ` Thomas Gleixner
2018-03-19 13:30 ` Thomas Gleixner
2018-03-20 14:23 ` Guo Ren
2018-03-20 14:23 ` Guo Ren
2018-03-18 20:25 ` [PATCH 00/19] C-SKY(csky) Linux Kernel Port Joe Perches
2018-03-18 20:25 ` Joe Perches
2018-03-19 7:11 ` Guo Ren
2018-03-19 7:11 ` Guo Ren
2018-03-26 13:30 ` Arnd Bergmann
2018-03-26 13:30 ` Arnd Bergmann
2018-03-26 15:06 ` [gnu-csky] " Sandra Loosemore
2018-03-26 15:06 ` Sandra Loosemore
2018-03-26 15:11 ` Arnd Bergmann
2018-03-26 15:11 ` Arnd Bergmann
2018-03-27 1:58 ` Guo Ren
2018-03-27 1:58 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a276dfzFE8kxYFx_RgJWx31px6M24tf+h7eRowma69Fhg@mail.gmail.com \
--to=arnd@arndb.de \
--cc=c-sky_gcc_upstream@c-sky.com \
--cc=daniel.lezcano@linaro.org \
--cc=gnu-csky@mentor.com \
--cc=jason@lakedaemon.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ren_guo@c-sky.com \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@uclibc-ng.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).