From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 7/7] ia64: wire up system calls Date: Thu, 11 Oct 2018 17:09:02 +0200 Message-ID: References: <1539231895-4118-1-git-send-email-firoz.khan@linaro.org> <1539231895-4118-8-git-send-email-firoz.khan@linaro.org> <20181011150654.GB22118@asgard.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20181011150654.GB22118@asgard.redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Eugene Syromiatnikov Cc: Firoz Khan , linux-ia64@vger.kernel.org, Tony Luck , Fenghua Yu , Thomas Gleixner , gregkh , Philippe Ombredanne , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz List-Id: linux-arch.vger.kernel.org On 10/11/18, Eugene Syromiatnikov wrote: > On Thu, Oct 11, 2018 at 09:24:43AM +0200, Arnd Bergmann wrote: >> On Thu, Oct 11, 2018 at 6:26 AM Firoz Khan wrote: > >> > +# pkey_mprotect requires an architecture specific implementation >> > +328 common pkey_mprotect sys_pkey_mprotect >> > +# pkey_alloc requires an architecture specific implementation >> > +329 common pkey_alloc sys_pkey_alloc >> > +# pkey_free requires an architecture specific implementation >> > +330 common pkey_free sys_pkey_free >> >> One comment for all pkey calls would be sufficient. More importantly >> it requires hardware support that ia64 does not have AFAICT. > > Except it has[1]. > Ok, then we should definitely assign the system call numbers. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f196.google.com ([209.85.160.196]:36048 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726664AbeJKWgy (ORCPT ); Thu, 11 Oct 2018 18:36:54 -0400 MIME-Version: 1.0 In-Reply-To: <20181011150654.GB22118@asgard.redhat.com> References: <1539231895-4118-1-git-send-email-firoz.khan@linaro.org> <1539231895-4118-8-git-send-email-firoz.khan@linaro.org> <20181011150654.GB22118@asgard.redhat.com> From: Arnd Bergmann Date: Thu, 11 Oct 2018 17:09:02 +0200 Message-ID: Subject: Re: [PATCH v3 7/7] ia64: wire up system calls Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Eugene Syromiatnikov Cc: Firoz Khan , linux-ia64@vger.kernel.org, Tony Luck , Fenghua Yu , Thomas Gleixner , gregkh , Philippe Ombredanne , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz Message-ID: <20181011150902.E9pb7E-LeWnwLEKzCZ0MCxLy-fayxmKxvAb6bEwejos@z> On 10/11/18, Eugene Syromiatnikov wrote: > On Thu, Oct 11, 2018 at 09:24:43AM +0200, Arnd Bergmann wrote: >> On Thu, Oct 11, 2018 at 6:26 AM Firoz Khan wrote: > >> > +# pkey_mprotect requires an architecture specific implementation >> > +328 common pkey_mprotect sys_pkey_mprotect >> > +# pkey_alloc requires an architecture specific implementation >> > +329 common pkey_alloc sys_pkey_alloc >> > +# pkey_free requires an architecture specific implementation >> > +330 common pkey_free sys_pkey_free >> >> One comment for all pkey calls would be sufficient. More importantly >> it requires hardware support that ia64 does not have AFAICT. > > Except it has[1]. > Ok, then we should definitely assign the system call numbers. Arnd